Re: [PATCH 6/6] ARM: mvebu: import DT files for Dove SoC and SolidRun CuBox

[Sascha Hauer <s.hauer@pengutronix.de>]

On Fri, Jun 28, 2013 at 08:25:47PM +0200, Sebastian Hesselbarth wrote:
> This imports dove.dtsi and dove-cubox.dts from Linux kernel with timer
> node added.
> 
> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> ---
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: barebox@lists.infradead.org
> ---
>  arch/arm/dts/dove-cubox.dts |  154 +++++++++++++++++++++++
>  arch/arm/dts/dove.dtsi      |  285 +++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 439 insertions(+), 0 deletions(-)
>  create mode 100644 arch/arm/dts/dove-cubox.dts
>  create mode 100644 arch/arm/dts/dove.dtsi
> 
> diff --git a/arch/arm/dts/dove-cubox.dts b/arch/arm/dts/dove-cubox.dts
> new file mode 100644
> index 0000000..b7dc243
> --- /dev/null
> +++ b/arch/arm/dts/dove-cubox.dts
> @@ -0,0 +1,154 @@
> +/dts-v1/;
> +
> +/include/ "dove.dtsi"
> +
> +/ {
> +	compatible = "solidrun,cubox", "marvell,dove";
> +	model = "SolidRun CuBox";
> +
> +	memory {
> +		device_type = "memory";
> +		reg = <0x00000000 0x3f000000>;
> +	};
> +
> +	chosen {
> +		bootargs = "console=ttyS0,115200n8 earlyprintk";
> +	};

I would add a linux,stdoutpath property here. Then you can switch to
CONFIG_CONSOLE_ACTIVATE_NONE in the defconfig and enable multiple uarts
in the dts without risking that the first one to be activated is not the
console port.

> +
> +&sdio0 {
> +	status = "okay";
> +        bus-width = <4>;

Use tab here.

> +		};
> +		
> +		lcd0: lcd-controller@820000 {
> +			compatible = "marvell,dove-lcd";
> +			reg = <0x820000 0x200>;
> +			interrupts = <47>;
> +			clocks = <0>;
> +			status = "disabled";
> +		};
> +		

Trailing whitespaces.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox