Re: [PATCH 2/6] clocksource: orion: add DT support

[Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>]

On 06/29/2013 10:49 AM, Sascha Hauer wrote:
> On Fri, Jun 28, 2013 at 08:25:43PM +0200, Sebastian Hesselbarth wrote:
>> This adds device tree support to orion timer and also converts clk_get
>> to clk_lookup to find TCLK without device name reference.
>>
>> Signed-off-by: Sebastian Hesselbarth<sebastian.hesselbarth@gmail.com>
>> ---
>> Cc: Thomas Petazzoni<thomas.petazzoni@free-electrons.com>
>> Cc: barebox@lists.infradead.org
>> ---
>>   drivers/clocksource/orion.c |    8 +++++++-
>>   1 files changed, 7 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/clocksource/orion.c b/drivers/clocksource/orion.c
>> index e3db845..ed71fa4 100644
>> --- a/drivers/clocksource/orion.c
>> +++ b/drivers/clocksource/orion.c
>> @@ -49,7 +49,7 @@ static int orion_timer_probe(struct device_d *dev)
>>   	uint32_t val;
>>
>>   	timer_base = dev_request_mem_region(dev, 0);
>> -	tclk = clk_get(dev, "tclk");
>> +	tclk = clk_lookup("tclk");
>
> Please don't do this. I don't know how it is done in the kernel
> for orion atm, but you could for example help yourself with
> clkdev_add_physbase until the clocks can be properly looked up from
> the devicetree.

Ok, clock provider for MVEBU barebox is still missing. But in the
meantime, I will use clkdev_add_physbase or any equivalent workaround
until full clock provider will be available.

Sebastian


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox