From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Stehle Vincent-B46079 <B46079-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Cc: Christian Ruppert
<christian.ruppert-ux6zf3SgZrrQT0dZR+AlfA@public.gmane.org>,
Pierrick Hascoet
<pierrick.hascoet-ux6zf3SgZrrQT0dZR+AlfA@public.gmane.org>,
Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>,
"devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org"
<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
"linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"Ben Dooks (embedded platforms)"
<ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>,
Mika Westerberg
<mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Vineet Gupta
<Vineet.Gupta1-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH v10] i2c-designware: make SDA hold time configurable
Date: Wed, 3 Jul 2013 17:26:41 +0200 [thread overview]
Message-ID: <201307031726.42167.arnd@arndb.de> (raw)
In-Reply-To: <F7C43F8B2814514CA05F3436BC68046EF379F0-RL0Hj/+nBVCMXPU/2EZmt64g8xLGJsHaLnY5E4hWTkheoWH0uzbU5w@public.gmane.org>
On Wednesday 03 July 2013, Stehle Vincent-B46079 wrote:
> > From: Christian Ruppert [mailto:christian.ruppert-ux6zf3SgZrrQT0dZR+AlfA@public.gmane.org]
> (..)
> > Although this doesn't explicitly state what the function returns to me
> > this sounds more like the quotient is returned rather than the remainder?
>
> Hi,
>
> Yes div_u64() returns the quotient.
>
> It is defined in linux/math64.h as:
>
> static inline u64 div_u64(u64 dividend, u32 divisor)
> {
> u32 remainder;
> return div_u64_rem(dividend, divisor, &remainder);
> }
>
> The remainder is probably fully optimized out.
Ah, you are right, sorry for the confusion on my part.
I thought you had used do_div() rather than div_u64().
Everything's fine then, feel free to add my
Acked-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
to your patch.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: "Stehle Vincent-B46079" <B46079@freescale.com>
Cc: Christian Ruppert <christian.ruppert@abilis.com>,
Wolfram Sang <wsa@the-dreams.de>,
Rob Herring <robherring2@gmail.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"Ben Dooks (embedded platforms)" <ben-linux@fluff.org>,
Grant Likely <grant.likely@secretlab.ca>,
Rob Landley <rob@landley.net>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Vineet Gupta <Vineet.Gupta1@synopsys.com>,
Pierrick Hascoet <pierrick.hascoet@abilis.com>
Subject: Re: [PATCH v10] i2c-designware: make SDA hold time configurable
Date: Wed, 3 Jul 2013 17:26:41 +0200 [thread overview]
Message-ID: <201307031726.42167.arnd@arndb.de> (raw)
In-Reply-To: <F7C43F8B2814514CA05F3436BC68046EF379F0@039-SN2MPN1-011.039d.mgd.msft.net>
On Wednesday 03 July 2013, Stehle Vincent-B46079 wrote:
> > From: Christian Ruppert [mailto:christian.ruppert@abilis.com]
> (..)
> > Although this doesn't explicitly state what the function returns to me
> > this sounds more like the quotient is returned rather than the remainder?
>
> Hi,
>
> Yes div_u64() returns the quotient.
>
> It is defined in linux/math64.h as:
>
> static inline u64 div_u64(u64 dividend, u32 divisor)
> {
> u32 remainder;
> return div_u64_rem(dividend, divisor, &remainder);
> }
>
> The remainder is probably fully optimized out.
Ah, you are right, sorry for the confusion on my part.
I thought you had used do_div() rather than div_u64().
Everything's fine then, feel free to add my
Acked-by: Arnd Bergmann <arnd@arndb.de>
to your patch.
Arnd
next prev parent reply other threads:[~2013-07-03 15:26 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130327084158.GB11010@ab42.lan>
[not found] ` <1364373760-12469-1-git-send-email-christian.ruppert@abilis.com>
[not found] ` <1364373760-12469-1-git-send-email-christian.ruppert-ux6zf3SgZrrQT0dZR+AlfA@public.gmane.org>
2013-05-14 11:07 ` [PATCH v7] i2c-designware: make SDA hold time configurable Mika Westerberg
2013-05-14 11:07 ` Mika Westerberg
[not found] ` <20130514110745.GA10906-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-05-14 13:04 ` [PATCH REBASE] " Christian Ruppert
2013-05-14 13:04 ` Christian Ruppert
2013-06-10 15:29 ` Wolfram Sang
2013-06-12 14:47 ` Christian Ruppert
2013-06-12 14:47 ` Christian Ruppert
2013-06-17 8:23 ` Mika Westerberg
2013-06-19 9:45 ` Wolfram Sang
2013-06-19 13:58 ` Christian Ruppert
2013-06-19 15:20 ` Wolfram Sang
2013-06-20 8:44 ` Christian Ruppert
2013-06-17 20:55 ` Rob Herring
[not found] ` <51BF77C2.70004-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-06-18 7:44 ` [PATCH v8] " Christian Ruppert
2013-06-18 7:44 ` Christian Ruppert
2013-06-20 20:04 ` Wolfram Sang
2013-06-20 20:37 ` Wolfram Sang
2013-06-21 9:53 ` [PATCH v9] " Christian Ruppert
2013-06-25 16:39 ` Wolfram Sang
2013-06-26 4:23 ` Vineet Gupta
2013-06-26 4:23 ` Vineet Gupta
2013-06-26 8:55 ` [PATCH v10] " Christian Ruppert
[not found] ` <1372236906-6933-1-git-send-email-christian.ruppert-ux6zf3SgZrrQT0dZR+AlfA@public.gmane.org>
2013-06-26 8:57 ` Vineet Gupta
2013-06-26 8:57 ` Vineet Gupta
2013-06-26 14:07 ` Wolfram Sang
2013-07-03 11:43 ` Arnd Bergmann
2013-07-03 11:43 ` Arnd Bergmann
[not found] ` <201307031343.11647.arnd-r2nGTMty4D4@public.gmane.org>
2013-07-03 13:29 ` Christian Ruppert
2013-07-03 13:29 ` Christian Ruppert
[not found] ` <20130703132905.GC3929-7oYq3qWSd+k@public.gmane.org>
2013-07-03 14:20 ` Arnd Bergmann
2013-07-03 14:20 ` Arnd Bergmann
[not found] ` <201307031620.03785.arnd-r2nGTMty4D4@public.gmane.org>
2013-07-03 14:38 ` Christian Ruppert
2013-07-03 14:38 ` Christian Ruppert
[not found] ` <20130703143835.GD3929-7oYq3qWSd+k@public.gmane.org>
2013-07-03 14:42 ` Arnd Bergmann
2013-07-03 14:42 ` Arnd Bergmann
[not found] ` <201307031642.30380.arnd-r2nGTMty4D4@public.gmane.org>
2013-07-03 14:44 ` Arnd Bergmann
2013-07-03 14:44 ` Arnd Bergmann
2013-07-03 14:59 ` Christian Ruppert
2013-07-03 15:07 ` Stehle Vincent-B46079
[not found] ` <F7C43F8B2814514CA05F3436BC68046EF379F0-RL0Hj/+nBVCMXPU/2EZmt64g8xLGJsHaLnY5E4hWTkheoWH0uzbU5w@public.gmane.org>
2013-07-03 15:26 ` Arnd Bergmann [this message]
2013-07-03 15:26 ` Arnd Bergmann
2013-06-18 10:32 ` [PATCH REBASE] " Andy Shevchenko
2013-05-17 8:29 ` [PATCH v7] " Wolfram Sang
2013-05-17 8:44 ` Mika Westerberg
2013-05-17 8:56 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201307031726.42167.arnd@arndb.de \
--to=arnd-r2ngtmty4d4@public.gmane.org \
--cc=B46079-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=Vineet.Gupta1-HKixBCOQz3hWk0Htik3J/w@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=christian.ruppert-ux6zf3SgZrrQT0dZR+AlfA@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=pierrick.hascoet-ux6zf3SgZrrQT0dZR+AlfA@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.