All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Jean Delvare <khali@linux-fr.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: [lm-sensors] [RFC PATCH 3/5] hwmon: (ds1621) Convert to use hwmon_device_register_groups
Date: Sat, 06 Jul 2013 20:45:54 +0000	[thread overview]
Message-ID: <20130706204554.GA25674@roeck-us.net> (raw)
In-Reply-To: <20130706215458.64753cd0@endymion.delvare>

On Sat, Jul 06, 2013 at 09:54:58PM +0200, Jean Delvare wrote:
> On Sat, 6 Jul 2013 12:31:42 -0700, Greg Kroah-Hartman wrote:
> > On Sat, Jul 06, 2013 at 12:18:16PM -0700, Guenter Roeck wrote:
> > > Yes, and I tested it with the new nct6775 driver to make sure that it works.
> > > The i2c and spi drivers need some more work, though - the name attribute is
> > > now missing and will have to be created for the hwmon device itself. If you have
> > > an idea how to do that without adding it in every driver, please let me know.
> > 
> > Why do you need a name attribute at all?  Shouldn't that just be the
> > name of the device, or the parent?
> 
> libsensors expects the hwmon attributes and the name attribute at the
> same place.
> 
> > Can you make the name be part of the groups always?
> 
> Sounds good, but then we have to make the hwmon core handles it. So far
> each driver (or its bus type subsystem) was responsible for it.
> 
A quick scan suggests this affects some 50+ drivers, which all implement the name
attribute. On the downside a lot of work, on the upside there will be lots of
removed code.

> -- 
> Jean Delvare
> 

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Jean Delvare <khali@linux-fr.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 3/5] hwmon: (ds1621) Convert to use hwmon_device_register_groups
Date: Sat, 6 Jul 2013 13:45:54 -0700	[thread overview]
Message-ID: <20130706204554.GA25674@roeck-us.net> (raw)
In-Reply-To: <20130706215458.64753cd0@endymion.delvare>

On Sat, Jul 06, 2013 at 09:54:58PM +0200, Jean Delvare wrote:
> On Sat, 6 Jul 2013 12:31:42 -0700, Greg Kroah-Hartman wrote:
> > On Sat, Jul 06, 2013 at 12:18:16PM -0700, Guenter Roeck wrote:
> > > Yes, and I tested it with the new nct6775 driver to make sure that it works.
> > > The i2c and spi drivers need some more work, though - the name attribute is
> > > now missing and will have to be created for the hwmon device itself. If you have
> > > an idea how to do that without adding it in every driver, please let me know.
> > 
> > Why do you need a name attribute at all?  Shouldn't that just be the
> > name of the device, or the parent?
> 
> libsensors expects the hwmon attributes and the name attribute at the
> same place.
> 
> > Can you make the name be part of the groups always?
> 
> Sounds good, but then we have to make the hwmon core handles it. So far
> each driver (or its bus type subsystem) was responsible for it.
> 
A quick scan suggests this affects some 50+ drivers, which all implement the name
attribute. On the downside a lot of work, on the upside there will be lots of
removed code.

> -- 
> Jean Delvare
> 

  reply	other threads:[~2013-07-06 20:45 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-06 17:22 [lm-sensors] [RFC PATCH 0/5] Introduce and use device_create_groups Guenter Roeck
2013-07-06 17:22 ` Guenter Roeck
2013-07-06 17:23 ` [lm-sensors] " Guenter Roeck
2013-07-06 17:23   ` Guenter Roeck
2013-07-06 17:24 ` [lm-sensors] " Guenter Roeck
2013-07-06 17:24   ` Guenter Roeck
2013-07-06 17:24   ` [lm-sensors] [RFC PATCH 1/5] driver core: Introduce device_create_groups Guenter Roeck
2013-07-06 17:24     ` Guenter Roeck
2013-07-06 17:47     ` [lm-sensors] " Greg Kroah-Hartman
2013-07-06 17:47       ` Greg Kroah-Hartman
2013-07-06 19:22       ` [lm-sensors] " Guenter Roeck
2013-07-06 19:22         ` Guenter Roeck
2013-07-06 17:24   ` [lm-sensors] [RFC PATCH 2/5] hwmon: Introduce hwmon_device_register_groups Guenter Roeck
2013-07-06 17:24     ` Guenter Roeck
2013-07-06 17:24   ` [lm-sensors] [RFC PATCH 3/5] hwmon: (ds1621) Convert to use hwmon_device_register_groups Guenter Roeck
2013-07-06 17:24     ` Guenter Roeck
2013-07-06 17:57     ` [lm-sensors] " Greg Kroah-Hartman
2013-07-06 17:57       ` Greg Kroah-Hartman
2013-07-06 18:01       ` [lm-sensors] " Jean Delvare
2013-07-06 18:01         ` Jean Delvare
2013-07-06 19:18         ` [lm-sensors] " Guenter Roeck
2013-07-06 19:18           ` Guenter Roeck
2013-07-06 19:31           ` [lm-sensors] " Greg Kroah-Hartman
2013-07-06 19:31             ` Greg Kroah-Hartman
2013-07-06 19:48             ` [lm-sensors] " Guenter Roeck
2013-07-06 19:48               ` Guenter Roeck
2013-07-06 19:59               ` [lm-sensors] " Jean Delvare
2013-07-06 19:59                 ` Jean Delvare
2013-07-06 20:14                 ` [lm-sensors] " Guenter Roeck
2013-07-06 20:14                   ` Guenter Roeck
2013-07-06 19:54             ` [lm-sensors] " Jean Delvare
2013-07-06 19:54               ` Jean Delvare
2013-07-06 20:45               ` Guenter Roeck [this message]
2013-07-06 20:45                 ` Guenter Roeck
2013-07-06 17:24   ` [lm-sensors] [RFC PATCH 4/5] hwmon: (gpio-fan) " Guenter Roeck
2013-07-06 17:24     ` Guenter Roeck
2013-07-06 17:24   ` [lm-sensors] [RFC PATCH 5/5] hwmon: (ltc4245) " Guenter Roeck
2013-07-06 17:24     ` Guenter Roeck
2013-07-06 17:33   ` [lm-sensors] [RFC PATCH 0/5] Introduce and use device_create_groups Greg Kroah-Hartman
2013-07-06 17:33     ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130706204554.GA25674@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.