From: jogo@openwrt.org (Jonas Gorski)
To: linux-arm-kernel@lists.infradead.org
Subject: Second ethernet on kirkwood does not work when probed through DT
Date: Sun, 7 Jul 2013 13:48:53 +0200 [thread overview]
Message-ID: <20130707134853.00003b9d@unknown> (raw)
In-Reply-To: <51D952D3.8070401@gmail.com>
On Sun, 07 Jul 2013 13:36:51 +0200
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> wrote:
> On 07/07/2013 01:26 PM, Jonas Gorski wrote:
> > On Sun, 07 Jul 2013 12:52:52 +0200
> > Sebastian Hesselbarth<sebastian.hesselbarth@gmail.com> wrote:
> >> Anyway, can you please try to have both ports reg properties set
> >> to<0>, with nodes named ethernet0-port at 0 and ethernet1-port at 0,
> >> and the platform_device_alloc in mv643xx_eth modified?
> >
> > In addition I added a static counter for the allocated devs (to not
> > overwrite the pointers in port_platdev[]).
>
> Ok, but that is not required to make it work, is it? IMHO we should
> honor what is passed by reg property, even it will be always zero
> for KW and the other Orion SoCs. Otherwise, we would implicitly put
> the numbering in the order of port nodes.
No, picking the next free "slot" should work, too - it was just the
easiest to fix the name for the alloc to what seems to be expected by
other parts.
> > That seems to work, as now eth1 comes up and works (successfully got a
> > IP through DHCP).
>
> Ok, great. Will prepare a fix for mv643xx_eth on top of net-next. And
> an update of the kirkwood conversion patches.
Thanks,
Jonas
WARNING: multiple messages have this Message-ID (diff)
From: Jonas Gorski <jogo@openwrt.org>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Florian Fainelli <florian@openwrt.org>,
Andrew Lunn <andrew@lunn.ch>, Jason Cooper <jason@lakedaemon.net>
Subject: Re: Second ethernet on kirkwood does not work when probed through DT
Date: Sun, 7 Jul 2013 13:48:53 +0200 [thread overview]
Message-ID: <20130707134853.00003b9d@unknown> (raw)
In-Reply-To: <51D952D3.8070401@gmail.com>
On Sun, 07 Jul 2013 13:36:51 +0200
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> wrote:
> On 07/07/2013 01:26 PM, Jonas Gorski wrote:
> > On Sun, 07 Jul 2013 12:52:52 +0200
> > Sebastian Hesselbarth<sebastian.hesselbarth@gmail.com> wrote:
> >> Anyway, can you please try to have both ports reg properties set
> >> to<0>, with nodes named ethernet0-port@0 and ethernet1-port@0,
> >> and the platform_device_alloc in mv643xx_eth modified?
> >
> > In addition I added a static counter for the allocated devs (to not
> > overwrite the pointers in port_platdev[]).
>
> Ok, but that is not required to make it work, is it? IMHO we should
> honor what is passed by reg property, even it will be always zero
> for KW and the other Orion SoCs. Otherwise, we would implicitly put
> the numbering in the order of port nodes.
No, picking the next free "slot" should work, too - it was just the
easiest to fix the name for the alloc to what seems to be expected by
other parts.
> > That seems to work, as now eth1 comes up and works (successfully got a
> > IP through DHCP).
>
> Ok, great. Will prepare a fix for mv643xx_eth on top of net-next. And
> an update of the kirkwood conversion patches.
Thanks,
Jonas
next prev parent reply other threads:[~2013-07-07 11:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-06 19:54 Second ethernet on kirkwood does not work when probed through DT Jonas Gorski
2013-07-06 19:54 ` Jonas Gorski
2013-07-06 21:22 ` Sebastian Hesselbarth
2013-07-06 21:22 ` Sebastian Hesselbarth
2013-07-06 21:39 ` Jonas Gorski
2013-07-06 21:39 ` Jonas Gorski
2013-07-07 10:52 ` Sebastian Hesselbarth
2013-07-07 10:52 ` Sebastian Hesselbarth
2013-07-07 11:26 ` Jonas Gorski
2013-07-07 11:26 ` Jonas Gorski
2013-07-07 11:36 ` Sebastian Hesselbarth
2013-07-07 11:36 ` Sebastian Hesselbarth
2013-07-07 11:48 ` Jonas Gorski [this message]
2013-07-07 11:48 ` Jonas Gorski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130707134853.00003b9d@unknown \
--to=jogo@openwrt.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.