Re: [PATCH] mmc: omap_hsmmc: use for OMAP5 as well

[Ezequiel Garcia <ezequiel.garcia@free-electrons.com>]

On Mon, Jul 08, 2013 at 02:58:28PM -0500, Nishanth Menon wrote:
> On 10:46-20130708, Felipe Balbi wrote:
> > On Sun, Jul 07, 2013 at 05:13:10PM -0300, Ezequiel Garcia wrote:
> > > Hi guys,
> > > 
> > > On Fri, Jun 28, 2013 at 09:27:20PM +0530, Balaji T K wrote:
> > > > On Friday 28 June 2013 06:04 PM, a-bindra@ti.com wrote:
> > > > > From: Amarinder Bindra <a-bindra@ti.com>
> > > > >
> > > > > OMAP's hs_mmc driver is also used for OMAP5 MMC controller operation.
> > > > > Considering that the device tree entries are already there for this,
> > > > > allow the driver to be built when only OMAP5 is enabled.
> > > > > This allows MMC root filesystems to be available in "OMAP5 only"
> > > > > configurations.
> > > > >
> > > > > Signed-off-by: Amarinder Bindra <a-bindra@ti.com>
> > > > > Acked-by: Felipe Balbi <balbi@ti.com>
> > > > > Acked-by: Nishanth Menon <nm@ti.com>
> > > > 
> > > > Looks good to me,
> > > > Acked-by: Balaji T K <balajitk@ti.com>
> > > > 
> > > 
> > > I came across this same issue while trying MMC patches on AM3xx,
> > > which is nor OMAP3 neither OMAP4.
> > > 
> > > Now, looking at the driver I don't see any OMAP-specific bits
> > > (welcome to the multiplatform world ;-) so I think we can just
> > > remove the 'depends' line. Something like this:
> > 
> > frankly speaking, this driver should be deleted and all users should be
> > moved to sdhci. OMAP's HSMMC controller is compatible with SDHCI except
> > for a couple quirks which can be easily worked around.

@Felipe:
Do you mind giving me some hints about this quirks? I'm not too familiar
with these drivers.

> Do we take that as a NAK to this specific patch?
> 
> I am not complaining about the future migration to a solution that is
> much more generic and scalable, but having fixes for current problems
> should'nt be ignored IMHO.
> 

Of course.

> How about a depends on CONFIG_ARCH_OMAP2PLUS instead? will that solve
> our pains with all OMAP2+ usin this?

Yes, I think that using ARCH_OMAP2PLUS should do. FWIW, until we have
sdhci ready to replace omap_hsmmc, we have no choice but to apply such
a patch.

@Nishant, Balaji: Can you take care of resending this?

Thanks!
-- 
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com