From: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: rnayak-l0cyMroinI0@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
balbi-l0cyMroinI0@public.gmane.org,
grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
Sourav Poddar <sourav.poddar-l0cyMroinI0@public.gmane.org>,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCHv3 2/3] drivers: spi: Add qspi flash controller
Date: Tue, 9 Jul 2013 09:53:21 -0500 [thread overview]
Message-ID: <20130709145321.GA1680@kahuna> (raw)
In-Reply-To: <20130709144043.GV27646-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
On 15:40-20130709, Mark Brown wrote:
> On Tue, Jul 09, 2013 at 07:50:55AM -0500, Nishanth Menon wrote:
>
> > with this input and looking closer, I think I see what you are saying now:
> > dra7xxx_qspi_prepare_xfer -> does a pm_runtime_get_sync
> > dra7xxx_qspi_unprepare_xfer -> does a pm_runtime_mark_last_busy,
> > pm_runtime_put_autosuspend
>
> > In between these calls, you have the remaining xfer calls going on.
> > we are assuming here that autosuspend timeout should be greater than
> > the time to complete the worst case transfer.
>
> No, autosuspend will do nothing so long as there are references to the
> device held. The effect of autosuspend is to delay power down after the
> last reference has been dropped, otherwise things run normally.
Thanks on the clarification. That concludes my confusion on the topic
:).
--
Regards,
Nishanth Menon
------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Menon <nm@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: <balbi@ti.com>, Sourav Poddar <sourav.poddar@ti.com>,
<spi-devel-general@lists.sourceforge.net>,
<grant.likely@linaro.org>, <rnayak@ti.com>,
<linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv3 2/3] drivers: spi: Add qspi flash controller
Date: Tue, 9 Jul 2013 09:53:21 -0500 [thread overview]
Message-ID: <20130709145321.GA1680@kahuna> (raw)
In-Reply-To: <20130709144043.GV27646@sirena.org.uk>
On 15:40-20130709, Mark Brown wrote:
> On Tue, Jul 09, 2013 at 07:50:55AM -0500, Nishanth Menon wrote:
>
> > with this input and looking closer, I think I see what you are saying now:
> > dra7xxx_qspi_prepare_xfer -> does a pm_runtime_get_sync
> > dra7xxx_qspi_unprepare_xfer -> does a pm_runtime_mark_last_busy,
> > pm_runtime_put_autosuspend
>
> > In between these calls, you have the remaining xfer calls going on.
> > we are assuming here that autosuspend timeout should be greater than
> > the time to complete the worst case transfer.
>
> No, autosuspend will do nothing so long as there are references to the
> device held. The effect of autosuspend is to delay power down after the
> last reference has been dropped, otherwise things run normally.
Thanks on the clarification. That concludes my confusion on the topic
:).
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2013-07-09 14:53 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-08 13:42 [PATCH 0/3] spi changes and ti quad spi controller Sourav Poddar
2013-07-08 13:42 ` Sourav Poddar
2013-07-08 13:42 ` Sourav Poddar
[not found] ` <1373290980-17883-1-git-send-email-sourav.poddar-l0cyMroinI0@public.gmane.org>
2013-07-08 13:42 ` [RFC/PATCH 1/3] driver: spi: Modify core to compute the message length Sourav Poddar
2013-07-08 13:42 ` Sourav Poddar
2013-07-08 13:42 ` Sourav Poddar
2013-07-08 15:02 ` Mark Brown
2013-07-08 13:43 ` [RFC/PATCH 3/3] driver: spi: Add quad spi read support Sourav Poddar
2013-07-08 13:43 ` Sourav Poddar
2013-07-08 13:43 ` Sourav Poddar
2013-07-08 14:36 ` Felipe Balbi
2013-07-08 14:36 ` Felipe Balbi
2013-07-08 13:42 ` [PATCHv3 2/3] drivers: spi: Add qspi flash controller Sourav Poddar
2013-07-08 13:42 ` Sourav Poddar
2013-07-08 14:32 ` Felipe Balbi
2013-07-08 14:32 ` Felipe Balbi
[not found] ` <20130708143251.GG31221-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2013-07-09 7:29 ` Sourav Poddar
2013-07-09 7:29 ` Sourav Poddar
2013-07-09 7:29 ` Sourav Poddar
2013-07-11 9:12 ` Sourav Poddar
2013-07-11 9:12 ` Sourav Poddar
2013-07-08 20:33 ` Nishanth Menon
2013-07-08 20:33 ` Nishanth Menon
2013-07-09 6:51 ` Felipe Balbi
2013-07-09 6:51 ` Felipe Balbi
2013-07-09 10:05 ` Mark Brown
[not found] ` <20130709100525.GR27646-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-07-09 12:32 ` Nishanth Menon
2013-07-09 12:32 ` Nishanth Menon
2013-07-09 12:50 ` Nishanth Menon
2013-07-09 12:50 ` Nishanth Menon
2013-07-09 14:40 ` Mark Brown
[not found] ` <20130709144043.GV27646-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-07-09 14:53 ` Nishanth Menon [this message]
2013-07-09 14:53 ` Nishanth Menon
2013-07-09 7:20 ` Sourav Poddar
2013-07-09 7:20 ` Sourav Poddar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130709145321.GA1680@kahuna \
--to=nm-l0cymroini0@public.gmane.org \
--cc=balbi-l0cyMroinI0@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rnayak-l0cyMroinI0@public.gmane.org \
--cc=sourav.poddar-l0cyMroinI0@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.