From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Rob Herring <robherring2@gmail.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, Russell King <linux@arm.linux.org.uk>,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Gregory Clement <gregory.clement@free-electrons.com>,
Lior Amsalem <alior@marvell.com>,
Maen Suleiman <maen@marvell.com>,
Thierry Reding <thierry.reding@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Subject: Re: [PATCHv4 05/11] of: pci: add registry of MSI chips
Date: Tue, 9 Jul 2013 16:01:32 +0200 [thread overview]
Message-ID: <20130709160132.7f5e7a8e@skate> (raw)
In-Reply-To: <CAL_Jsq+h=y5SNo4qO5-5u_w8rW++9MKDZK8rASNjhtVcjh-iyQ@mail.gmail.com>
Rob,
On Tue, 9 Jul 2013 08:43:36 -0500, Rob Herring wrote:
> > +int of_msi_chip_add(struct msi_chip *chip)
>
> Perhaps of_pci_msi_chip_add instead.
Sure, makes sense.
> > +{
> > + struct msi_chip *c;
> > + list_for_each_entry(c, &msi_chip_list, list) {
>
> Need the safe variant here?
As suggested by Bjorn, I've changed this function to grab the
msi_chip_mutex while traversing the list.
Does your e-mail implies that the general approach seems ok? If so,
I'll resend an updated v5 version taking into account the comments
that I have received on this v4.
Thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv4 05/11] of: pci: add registry of MSI chips
Date: Tue, 9 Jul 2013 16:01:32 +0200 [thread overview]
Message-ID: <20130709160132.7f5e7a8e@skate> (raw)
In-Reply-To: <CAL_Jsq+h=y5SNo4qO5-5u_w8rW++9MKDZK8rASNjhtVcjh-iyQ@mail.gmail.com>
Rob,
On Tue, 9 Jul 2013 08:43:36 -0500, Rob Herring wrote:
> > +int of_msi_chip_add(struct msi_chip *chip)
>
> Perhaps of_pci_msi_chip_add instead.
Sure, makes sense.
> > +{
> > + struct msi_chip *c;
> > + list_for_each_entry(c, &msi_chip_list, list) {
>
> Need the safe variant here?
As suggested by Bjorn, I've changed this function to grab the
msi_chip_mutex while traversing the list.
Does your e-mail implies that the general approach seems ok? If so,
I'll resend an updated v5 version taking into account the comments
that I have received on this v4.
Thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-07-09 14:01 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-01 13:42 [PATCHv4 00/11] MSI support for Marvell EBU PCIe driver Thomas Petazzoni
2013-07-01 13:42 ` Thomas Petazzoni
2013-07-01 13:42 ` [PATCHv4 01/11] irqdomain: add irq_alloc_mapping() function Thomas Petazzoni
2013-07-01 13:42 ` Thomas Petazzoni
2013-07-01 13:42 ` [PATCHv4 02/11] pci: use weak functions for MSI arch-specific functions Thomas Petazzoni
2013-07-01 13:42 ` Thomas Petazzoni
2013-07-01 13:42 ` Thomas Petazzoni
2013-07-01 13:42 ` Thomas Petazzoni
2013-07-01 13:42 ` Thomas Petazzoni
2013-07-02 0:53 ` Michael Ellerman
2013-07-02 0:53 ` Michael Ellerman
2013-07-02 0:53 ` Michael Ellerman
2013-07-02 5:30 ` Thomas Petazzoni
2013-07-02 5:30 ` Thomas Petazzoni
2013-07-02 5:30 ` Thomas Petazzoni
2013-07-02 6:52 ` Michael Ellerman
2013-07-02 6:52 ` Michael Ellerman
2013-07-02 6:52 ` Michael Ellerman
2013-07-02 17:14 ` Bjorn Helgaas
2013-07-02 17:14 ` Bjorn Helgaas
2013-07-02 17:14 ` Bjorn Helgaas
2013-07-05 21:32 ` Bjorn Helgaas
2013-07-05 21:32 ` Bjorn Helgaas
2013-07-05 21:32 ` Bjorn Helgaas
2013-07-05 21:34 ` Bjorn Helgaas
2013-07-05 21:34 ` Bjorn Helgaas
2013-07-05 21:34 ` Bjorn Helgaas
2013-07-05 21:40 ` Thomas Petazzoni
2013-07-05 21:40 ` Thomas Petazzoni
2013-07-05 21:40 ` Thomas Petazzoni
2013-07-01 13:42 ` [PATCHv4 03/11] pci: remove ARCH_SUPPORTS_MSI kconfig option Thomas Petazzoni
2013-07-01 13:42 ` Thomas Petazzoni
2013-07-01 13:42 ` Thomas Petazzoni
2013-07-01 13:42 ` Thomas Petazzoni
2013-07-01 13:42 ` Thomas Petazzoni
2013-07-05 21:37 ` Bjorn Helgaas
2013-07-05 21:37 ` Bjorn Helgaas
2013-07-05 21:45 ` Thomas Petazzoni
2013-07-05 21:45 ` Thomas Petazzoni
2013-07-05 21:45 ` Thomas Petazzoni
2013-07-06 13:54 ` Jason Cooper
2013-07-06 13:54 ` Jason Cooper
2013-07-06 13:54 ` Jason Cooper
2013-07-06 15:40 ` Bjorn Helgaas
2013-07-06 15:40 ` Bjorn Helgaas
2013-07-06 15:40 ` Bjorn Helgaas
2013-07-06 16:17 ` Jason Cooper
2013-07-06 16:17 ` Jason Cooper
2013-07-06 16:17 ` Jason Cooper
2013-07-06 16:33 ` Thomas Petazzoni
2013-07-06 16:33 ` Thomas Petazzoni
2013-07-06 16:33 ` Thomas Petazzoni
2013-07-01 13:42 ` [PATCHv4 04/11] PCI: Introduce new MSI chip infrastructure Thomas Petazzoni
2013-07-01 13:42 ` Thomas Petazzoni
2013-07-05 21:51 ` Bjorn Helgaas
2013-07-05 21:51 ` Bjorn Helgaas
2013-07-05 22:08 ` Thomas Petazzoni
2013-07-05 22:08 ` Thomas Petazzoni
2013-07-08 14:51 ` Thomas Petazzoni
2013-07-08 14:51 ` Thomas Petazzoni
2013-07-09 5:05 ` Thierry Reding
2013-07-09 5:05 ` Thierry Reding
2013-07-09 16:34 ` Bjorn Helgaas
2013-07-09 16:34 ` Bjorn Helgaas
2013-07-01 13:42 ` [PATCHv4 05/11] of: pci: add registry of MSI chips Thomas Petazzoni
2013-07-01 13:42 ` Thomas Petazzoni
2013-07-05 21:56 ` Bjorn Helgaas
2013-07-05 21:56 ` Bjorn Helgaas
2013-07-05 22:06 ` Thomas Petazzoni
2013-07-05 22:06 ` Thomas Petazzoni
2013-07-08 11:23 ` Thomas Petazzoni
2013-07-08 11:23 ` Thomas Petazzoni
2013-07-09 13:43 ` Rob Herring
2013-07-09 13:43 ` Rob Herring
2013-07-09 14:01 ` Thomas Petazzoni [this message]
2013-07-09 14:01 ` Thomas Petazzoni
2013-07-09 16:30 ` Bjorn Helgaas
2013-07-09 16:30 ` Bjorn Helgaas
2013-07-09 22:52 ` Rob Herring
2013-07-09 22:52 ` Rob Herring
2013-07-01 13:42 ` [PATCHv4 06/11] irqchip: armada-370-xp: properly request resources Thomas Petazzoni
2013-07-01 13:42 ` Thomas Petazzoni
2013-07-01 13:42 ` [PATCHv4 07/11] irqchip: armada-370-xp: implement MSI support Thomas Petazzoni
2013-07-01 13:42 ` Thomas Petazzoni
2013-07-01 13:42 ` [PATCHv4 08/11] arm: pci: add ->add_bus() and ->remove_bus() hooks to hw_pci Thomas Petazzoni
2013-07-01 13:42 ` Thomas Petazzoni
2013-07-01 13:42 ` [PATCHv4 09/11] arm: mvebu: the MPIC now provides MSI controller features Thomas Petazzoni
2013-07-01 13:42 ` Thomas Petazzoni
2013-07-01 13:42 ` [PATCHv4 10/11] pci: mvebu: add support for MSI Thomas Petazzoni
2013-07-01 13:42 ` Thomas Petazzoni
2013-07-05 21:59 ` Bjorn Helgaas
2013-07-05 21:59 ` Bjorn Helgaas
2013-07-01 13:42 ` [PATCHv4 11/11] arm: mvebu: link PCIe controllers to the MSI controller Thomas Petazzoni
2013-07-01 13:42 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130709160132.7f5e7a8e@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=alior@marvell.com \
--cc=andrew@lunn.ch \
--cc=bhelgaas@google.com \
--cc=ezequiel.garcia@free-electrons.com \
--cc=grant.likely@secretlab.ca \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=maen@marvell.com \
--cc=rob.herring@calxeda.com \
--cc=robherring2@gmail.com \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.