From: Simon Horman <horms@verge.net.au>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 01/02] ARM: shmobile: Introduce r8a7790_read_mode_pins()
Date: Wed, 10 Jul 2013 01:23:10 +0000 [thread overview]
Message-ID: <20130710012309.GS32603@verge.net.au> (raw)
In-Reply-To: <CANqRtoTvSGvNWwBQ9XD43CtdJNJCebzC2xtXUQcFSXxATkuNpQ@mail.gmail.com>
On Tue, Jul 09, 2013 at 10:05:15PM +0900, Magnus Damm wrote:
> Hi Sergei,
>
> On Tue, Jul 9, 2013 at 9:57 PM, Sergei Shtylyov
> <sergei.shtylyov@cogentembedded.com> wrote:
> > Hello.
> >
> >
> > On 09-07-2013 16:50, Magnus Damm wrote:
> >
> >> From: Magnus Damm <damm@opensource.se>
> >
> >
> >> Break out the r8a7790 boot mode code into a separate
> >> function so it can be shared by multiple users.
> >
> >
> >> Signed-off-by: Magnus Damm <damm@opensource.se>
> >> ---
> >
> >
> > [...]
> >
> >
> >> --- 0001/arch/arm/mach-shmobile/setup-r8a7790.c
> >> +++ work/arch/arm/mach-shmobile/setup-r8a7790.c 2013-07-09
> >> 19:59:37.000000000 +0900
> >> @@ -201,6 +201,20 @@ void __init r8a7790_add_standard_devices
> >> r8a7790_register_thermal();
> >> }
> >>
> >> +#define MODEMR 0xe6160060
> >> +
> >> +u32 __init r8a7790_read_mode_pins(void)
> >> +{
> >> + void __iomem *modemr = ioremap_nocache(MODEMR, PAGE_SIZE);
> >
> >
> > Why ioremap the whole page if you only need 4 bytes, and the address is
> > not aligned to page?
>
> Because the original code did so. =)
>
> But yes, indeed, using two pages seems kind of pointless.
Lets fix that up in another patch, it seems orthogonal to this change.
WARNING: multiple messages have this Message-ID (diff)
From: horms@verge.net.au (Simon Horman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 01/02] ARM: shmobile: Introduce r8a7790_read_mode_pins()
Date: Wed, 10 Jul 2013 10:23:10 +0900 [thread overview]
Message-ID: <20130710012309.GS32603@verge.net.au> (raw)
In-Reply-To: <CANqRtoTvSGvNWwBQ9XD43CtdJNJCebzC2xtXUQcFSXxATkuNpQ@mail.gmail.com>
On Tue, Jul 09, 2013 at 10:05:15PM +0900, Magnus Damm wrote:
> Hi Sergei,
>
> On Tue, Jul 9, 2013 at 9:57 PM, Sergei Shtylyov
> <sergei.shtylyov@cogentembedded.com> wrote:
> > Hello.
> >
> >
> > On 09-07-2013 16:50, Magnus Damm wrote:
> >
> >> From: Magnus Damm <damm@opensource.se>
> >
> >
> >> Break out the r8a7790 boot mode code into a separate
> >> function so it can be shared by multiple users.
> >
> >
> >> Signed-off-by: Magnus Damm <damm@opensource.se>
> >> ---
> >
> >
> > [...]
> >
> >
> >> --- 0001/arch/arm/mach-shmobile/setup-r8a7790.c
> >> +++ work/arch/arm/mach-shmobile/setup-r8a7790.c 2013-07-09
> >> 19:59:37.000000000 +0900
> >> @@ -201,6 +201,20 @@ void __init r8a7790_add_standard_devices
> >> r8a7790_register_thermal();
> >> }
> >>
> >> +#define MODEMR 0xe6160060
> >> +
> >> +u32 __init r8a7790_read_mode_pins(void)
> >> +{
> >> + void __iomem *modemr = ioremap_nocache(MODEMR, PAGE_SIZE);
> >
> >
> > Why ioremap the whole page if you only need 4 bytes, and the address is
> > not aligned to page?
>
> Because the original code did so. =)
>
> But yes, indeed, using two pages seems kind of pointless.
Lets fix that up in another patch, it seems orthogonal to this change.
next prev parent reply other threads:[~2013-07-10 1:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-09 12:50 [PATCH 00/02] ARM: shmobile: r8a7790 arch timer frequency update Magnus Damm
2013-07-09 12:50 ` Magnus Damm
2013-07-09 12:50 ` [PATCH 01/02] ARM: shmobile: Introduce r8a7790_read_mode_pins() Magnus Damm
2013-07-09 12:50 ` Magnus Damm
2013-07-09 12:57 ` Sergei Shtylyov
2013-07-09 12:57 ` Sergei Shtylyov
2013-07-09 13:05 ` Magnus Damm
2013-07-09 13:05 ` Magnus Damm
2013-07-10 1:23 ` Simon Horman [this message]
2013-07-10 1:23 ` Simon Horman
2013-07-09 12:50 ` [PATCH 02/02] ARM: shmobile: Setup r8a7790 arch timer based on MD pins Magnus Damm
2013-07-09 12:50 ` Magnus Damm
2013-07-10 1:23 ` [PATCH 00/02] ARM: shmobile: r8a7790 arch timer frequency update Simon Horman
2013-07-10 1:23 ` Simon Horman
2013-07-10 2:12 ` Magnus Damm
2013-07-10 2:12 ` Magnus Damm
2013-07-10 2:21 ` Simon Horman
2013-07-10 2:21 ` Simon Horman
2013-07-11 8:40 ` Ulrich Hecht
2013-07-11 8:40 ` Ulrich Hecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130710012309.GS32603@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.