All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: balbi@ti.com, gregkh@linuxfoundation.org, linux@arm.linux.org.uk,
	eballetbo@gmail.com, javier@dowhile0.org,
	linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v2 1/4] arm: omap: Add phy binding info for musb in plat data
Date: Tue, 16 Jul 2013 05:44:43 -0700	[thread overview]
Message-ID: <20130716124442.GZ7656@atomide.com> (raw)
In-Reply-To: <1373282057-20181-2-git-send-email-kishon@ti.com>

* Kishon Vijay Abraham I <kishon@ti.com> [130708 04:20]:
> In order for controllers to get PHY in case of non dt boot, the phy
> binding information (phy label) should be added in the platform
> data of the controller.
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> Acked-by: Felipe Balbi <balbi@ti.com>
> Tested-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

Acked-by: Tony Lindgren <tony@atomide.com>

> ---
>  arch/arm/mach-omap2/usb-musb.c |    3 +++
>  include/linux/usb/musb.h       |    3 +++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-musb.c
> index 8c4de27..20b42de 100644
> --- a/arch/arm/mach-omap2/usb-musb.c
> +++ b/arch/arm/mach-omap2/usb-musb.c
> @@ -85,6 +85,9 @@ void __init usb_musb_init(struct omap_musb_board_data *musb_board_data)
>  	musb_plat.mode = board_data->mode;
>  	musb_plat.extvbus = board_data->extvbus;
>  
> +	if (cpu_is_omap34xx())
> +		musb_plat.phy_name = "twl4030";
> +
>  	if (soc_is_am35xx()) {
>  		oh_name = "am35x_otg_hs";
>  		name = "musb-am35x";
> diff --git a/include/linux/usb/musb.h b/include/linux/usb/musb.h
> index 053c268..c05d46d 100644
> --- a/include/linux/usb/musb.h
> +++ b/include/linux/usb/musb.h
> @@ -104,6 +104,9 @@ struct musb_hdrc_platform_data {
>  	/* for clk_get() */
>  	const char	*clock;
>  
> +	/* phy device label */
> +	const char	*phy_name;
> +
>  	/* (HOST or OTG) switch VBUS on/off */
>  	int		(*set_vbus)(struct device *dev, int is_on);
>  
> -- 
> 1.7.10.4
> 

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/4] arm: omap: Add phy binding info for musb in plat data
Date: Tue, 16 Jul 2013 05:44:43 -0700	[thread overview]
Message-ID: <20130716124442.GZ7656@atomide.com> (raw)
In-Reply-To: <1373282057-20181-2-git-send-email-kishon@ti.com>

* Kishon Vijay Abraham I <kishon@ti.com> [130708 04:20]:
> In order for controllers to get PHY in case of non dt boot, the phy
> binding information (phy label) should be added in the platform
> data of the controller.
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> Acked-by: Felipe Balbi <balbi@ti.com>
> Tested-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

Acked-by: Tony Lindgren <tony@atomide.com>

> ---
>  arch/arm/mach-omap2/usb-musb.c |    3 +++
>  include/linux/usb/musb.h       |    3 +++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-musb.c
> index 8c4de27..20b42de 100644
> --- a/arch/arm/mach-omap2/usb-musb.c
> +++ b/arch/arm/mach-omap2/usb-musb.c
> @@ -85,6 +85,9 @@ void __init usb_musb_init(struct omap_musb_board_data *musb_board_data)
>  	musb_plat.mode = board_data->mode;
>  	musb_plat.extvbus = board_data->extvbus;
>  
> +	if (cpu_is_omap34xx())
> +		musb_plat.phy_name = "twl4030";
> +
>  	if (soc_is_am35xx()) {
>  		oh_name = "am35x_otg_hs";
>  		name = "musb-am35x";
> diff --git a/include/linux/usb/musb.h b/include/linux/usb/musb.h
> index 053c268..c05d46d 100644
> --- a/include/linux/usb/musb.h
> +++ b/include/linux/usb/musb.h
> @@ -104,6 +104,9 @@ struct musb_hdrc_platform_data {
>  	/* for clk_get() */
>  	const char	*clock;
>  
> +	/* phy device label */
> +	const char	*phy_name;
> +
>  	/* (HOST or OTG) switch VBUS on/off */
>  	int		(*set_vbus)(struct device *dev, int is_on);
>  
> -- 
> 1.7.10.4
> 

  reply	other threads:[~2013-07-16 12:44 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-08 11:14 [PATCH v2 0/4] usb: musb: fix USB enumeration issue in OMAP3 platform Kishon Vijay Abraham I
2013-07-08 11:14 ` Kishon Vijay Abraham I
2013-07-08 11:14 ` Kishon Vijay Abraham I
2013-07-08 11:14 ` [PATCH v2 1/4] arm: omap: Add phy binding info for musb in plat data Kishon Vijay Abraham I
2013-07-08 11:14   ` Kishon Vijay Abraham I
2013-07-08 11:14   ` Kishon Vijay Abraham I
2013-07-16 12:44   ` Tony Lindgren [this message]
2013-07-16 12:44     ` Tony Lindgren
     [not found] ` <1373282057-20181-1-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2013-07-08 11:14   ` [PATCH v2 2/4] usb: phy: add a new API to get PHY ref by label Kishon Vijay Abraham I
2013-07-08 11:14     ` Kishon Vijay Abraham I
2013-07-08 11:14     ` Kishon Vijay Abraham I
2013-07-08 11:14   ` [PATCH v2 3/4] usb: musb: omap: use the new API to get PHY reference " Kishon Vijay Abraham I
2013-07-08 11:14     ` Kishon Vijay Abraham I
2013-07-08 11:14     ` Kishon Vijay Abraham I
2013-07-08 11:14 ` [PATCH v2 4/4] arm: omap: remove using usb_bind_phy for binding musb and phy Kishon Vijay Abraham I
2013-07-08 11:14   ` Kishon Vijay Abraham I
2013-07-08 11:14   ` Kishon Vijay Abraham I
2013-07-16 12:46   ` Tony Lindgren
2013-07-16 12:46     ` Tony Lindgren
2013-07-16  5:52 ` [PATCH v2 0/4] usb: musb: fix USB enumeration issue in OMAP3 platform Kishon Vijay Abraham I
2013-07-16  5:52   ` Kishon Vijay Abraham I
2013-07-16  5:52   ` Kishon Vijay Abraham I
2013-07-16 12:42   ` Felipe Balbi
2013-07-16 12:42     ` Felipe Balbi
2013-07-16 12:42     ` Felipe Balbi
2013-07-16 12:47     ` Tony Lindgren
2013-07-16 12:47       ` Tony Lindgren
2013-07-19  8:45     ` Kishon Vijay Abraham I
2013-07-19  8:45       ` Kishon Vijay Abraham I
2013-07-19  8:45       ` Kishon Vijay Abraham I

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130716124442.GZ7656@atomide.com \
    --to=tony@atomide.com \
    --cc=balbi@ti.com \
    --cc=eballetbo@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=javier@dowhile0.org \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.