* [PATCH 1/2] libceph: For nofail == false, if __map_request failed,it should unregister.
@ 2013-07-16 7:45 majianpeng
2013-07-17 0:43 ` [PATCH 1/2] libceph: For nofail == false, if __map_request failed, it " Sage Weil
0 siblings, 1 reply; 2+ messages in thread
From: majianpeng @ 2013-07-16 7:45 UTC (permalink / raw)
To: sage; +Cc: ceph-devel
For nofail == false request, if __map_request failed, the caller do
cleanup work,like release the relative pages.It doesn't make any sense
to retry this request.So only give up it.
Signed-off-by: Jianpeng Ma <majianpeng@gmail.com>
---
net/ceph/osd_client.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c
index dd47889..7d40a61 100644
--- a/net/ceph/osd_client.c
+++ b/net/ceph/osd_client.c
@@ -2129,7 +2129,8 @@ int ceph_osdc_start_request(struct ceph_osd_client *osdc,
dout("osdc_start_request failed map, "
" will retry %lld\n", req->r_tid);
rc = 0;
- }
+ } else
+ __unregister_request(osdc, req);
goto out_unlock;
}
if (req->r_osd == NULL) {
--
1.8.1.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] libceph: For nofail == false, if __map_request failed, it should unregister.
2013-07-16 7:45 [PATCH 1/2] libceph: For nofail == false, if __map_request failed,it should unregister majianpeng
@ 2013-07-17 0:43 ` Sage Weil
0 siblings, 0 replies; 2+ messages in thread
From: Sage Weil @ 2013-07-17 0:43 UTC (permalink / raw)
To: majianpeng; +Cc: ceph-devel
Applied, thanks!
On Tue, 16 Jul 2013, majianpeng wrote:
> For nofail == false request, if __map_request failed, the caller do
> cleanup work,like release the relative pages.It doesn't make any sense
> to retry this request.So only give up it.
>
> Signed-off-by: Jianpeng Ma <majianpeng@gmail.com>
> ---
> net/ceph/osd_client.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c
> index dd47889..7d40a61 100644
> --- a/net/ceph/osd_client.c
> +++ b/net/ceph/osd_client.c
> @@ -2129,7 +2129,8 @@ int ceph_osdc_start_request(struct ceph_osd_client *osdc,
> dout("osdc_start_request failed map, "
> " will retry %lld\n", req->r_tid);
> rc = 0;
> - }
> + } else
> + __unregister_request(osdc, req);
> goto out_unlock;
> }
> if (req->r_osd == NULL) {
> --
> 1.8.1.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-07-17 0:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-16 7:45 [PATCH 1/2] libceph: For nofail == false, if __map_request failed,it should unregister majianpeng
2013-07-17 0:43 ` [PATCH 1/2] libceph: For nofail == false, if __map_request failed, it " Sage Weil
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.