From: 'Maxime Ripard' <maxime.ripard@free-electrons.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] fb: backlight: HX8357: Add HX8369 support
Date: Tue, 16 Jul 2013 15:46:16 +0000 [thread overview]
Message-ID: <20130716154616.GK3125@lukather> (raw)
In-Reply-To: <003601ce81c8$c2573320$47059960$@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 1039 bytes --]
Hi Jingoo,
On Tue, Jul 16, 2013 at 11:04:09AM +0900, Jingoo Han wrote:
> On Tuesday, July 16, 2013 12:27 AM, Maxime Ripard wrote:
> >
> > From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> >
> > Add support for the Himax HX8369 controller as it is quite similar to the
> > hx8357.
> >
> > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>
> Hi Maxime Ripard,
>
> I reviewed this patch with Himax HX8369 datasheet.
> I cannot find any problems. It looks good.
>
> However, if possible, please add comment on huge delays such as
> msleep(120), msleep(100), etc.
Right. I'll send a follow-up patch if this is merged right away, or
merge the comments in the next iteration of the patches.
> Acked-by: Jingoo Han <jg1.han@samsung.com>
Thanks for taking the time to review this!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com ('Maxime Ripard')
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] fb: backlight: HX8357: Add HX8369 support
Date: Tue, 16 Jul 2013 17:46:16 +0200 [thread overview]
Message-ID: <20130716154616.GK3125@lukather> (raw)
In-Reply-To: <003601ce81c8$c2573320$47059960$@samsung.com>
Hi Jingoo,
On Tue, Jul 16, 2013 at 11:04:09AM +0900, Jingoo Han wrote:
> On Tuesday, July 16, 2013 12:27 AM, Maxime Ripard wrote:
> >
> > From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> >
> > Add support for the Himax HX8369 controller as it is quite similar to the
> > hx8357.
> >
> > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>
> Hi Maxime Ripard,
>
> I reviewed this patch with Himax HX8369 datasheet.
> I cannot find any problems. It looks good.
>
> However, if possible, please add comment on huge delays such as
> msleep(120), msleep(100), etc.
Right. I'll send a follow-up patch if this is merged right away, or
merge the comments in the next iteration of the patches.
> Acked-by: Jingoo Han <jg1.han@samsung.com>
Thanks for taking the time to review this!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130716/67432efb/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: "'Maxime Ripard'" <maxime.ripard@free-electrons.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'Andrew Morton'" <akpm@linux-foundation.org>,
"'Alexandre Belloni'" <alexandre.belloni@free-electrons.com>,
hector.palacios@digi.com,
"'Thomas Petazzoni'" <thomas@free-electrons.com>,
plagnioj@jcrosoft.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 3/3] fb: backlight: HX8357: Add HX8369 support
Date: Tue, 16 Jul 2013 17:46:16 +0200 [thread overview]
Message-ID: <20130716154616.GK3125@lukather> (raw)
In-Reply-To: <003601ce81c8$c2573320$47059960$@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 1039 bytes --]
Hi Jingoo,
On Tue, Jul 16, 2013 at 11:04:09AM +0900, Jingoo Han wrote:
> On Tuesday, July 16, 2013 12:27 AM, Maxime Ripard wrote:
> >
> > From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> >
> > Add support for the Himax HX8369 controller as it is quite similar to the
> > hx8357.
> >
> > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>
> Hi Maxime Ripard,
>
> I reviewed this patch with Himax HX8369 datasheet.
> I cannot find any problems. It looks good.
>
> However, if possible, please add comment on huge delays such as
> msleep(120), msleep(100), etc.
Right. I'll send a follow-up patch if this is merged right away, or
merge the comments in the next iteration of the patches.
> Acked-by: Jingoo Han <jg1.han@samsung.com>
Thanks for taking the time to review this!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-07-16 15:46 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-15 15:26 [PATCH 0/3] Few ignored framebuffer fixes/additions Maxime Ripard
2013-07-15 15:26 ` Maxime Ripard
2013-07-15 15:26 ` Maxime Ripard
2013-07-15 15:27 ` [PATCH 1/3] video: mxsfb: fix color settings for 18bit data bus and 32bpp Maxime Ripard
2013-07-15 15:27 ` Maxime Ripard
2013-07-15 15:27 ` Maxime Ripard
2013-07-15 15:27 ` [PATCH 2/3] video: hx8357: Make IM pins optional Maxime Ripard
2013-07-15 15:27 ` Maxime Ripard
2013-07-15 15:27 ` Maxime Ripard
2013-07-16 0:49 ` Jingoo Han
2013-07-16 0:49 ` Jingoo Han
2013-07-16 0:49 ` Jingoo Han
2013-07-16 3:29 ` Mike Galbraith
2013-07-16 3:29 ` Mike Galbraith
2013-07-16 3:29 ` Mike Galbraith
2013-07-19 8:35 ` 'Maxime Ripard'
2013-07-19 8:35 ` 'Maxime Ripard'
2013-07-19 8:35 ` 'Maxime Ripard'
2013-07-22 8:30 ` Jingoo Han
2013-07-22 8:30 ` Jingoo Han
2013-07-22 8:30 ` Jingoo Han
2013-07-15 15:27 ` [PATCH 3/3] fb: backlight: HX8357: Add HX8369 support Maxime Ripard
2013-07-15 15:27 ` Maxime Ripard
2013-07-15 15:27 ` Maxime Ripard
2013-07-16 2:04 ` Jingoo Han
2013-07-16 2:04 ` Jingoo Han
2013-07-16 2:04 ` Jingoo Han
2013-07-16 15:46 ` 'Maxime Ripard' [this message]
2013-07-16 15:46 ` 'Maxime Ripard'
2013-07-16 15:46 ` 'Maxime Ripard'
2013-07-17 21:37 ` [PATCH 0/3] Few ignored framebuffer fixes/additions Andrew Morton
2013-07-17 21:37 ` Andrew Morton
2013-07-17 21:37 ` Andrew Morton
2013-07-19 8:27 ` Maxime Ripard
2013-07-19 8:27 ` Maxime Ripard
2013-07-19 8:27 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130716154616.GK3125@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.