From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: use common reboot infrastructure
Date: Wed, 17 Jul 2013 20:20:04 +0100 [thread overview]
Message-ID: <20130717192004.GD16496@MacBook-Pro.local> (raw)
In-Reply-To: <1373541180-7452-1-git-send-email-marc.zyngier@arm.com>
On Thu, Jul 11, 2013 at 12:13:00PM +0100, Marc Zyngier wrote:
> Commit 7b6d864b48d9 (reboot: arm: change reboot_mode to use enum
> reboot_mode) changed the way reboot is handled on arm, which has a
> direct impact on arm64 as we share the reset driver on the VE platform.
>
> The obvious fix is to move arm64 to use the same infrastructure.
>
> Cc: Robin Holt <holt@sgi.com>
> Cc: Pawel Moll <pawel.moll@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
I just did the same before I saw your patch. Anyway, I'll take yours as
you did it first ;)
> --- a/kernel/reboot.c
> +++ b/kernel/reboot.c
> @@ -25,7 +25,7 @@ int C_A_D = 1;
> struct pid *cad_pid;
> EXPORT_SYMBOL(cad_pid);
>
> -#if defined(CONFIG_ARM) || defined(CONFIG_UNICORE32)
> +#if defined(CONFIG_ARM) || defined(CONFIG_ARM64) || defined(CONFIG_UNICORE32)
> #define DEFAULT_REBOOT_MODE = REBOOT_HARD
> #else
> #define DEFAULT_REBOOT_MODE
Do we need this or we could use the default (I think REBOOT_COLD is 0)?
--
Catalin
WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Will Deacon <Will.Deacon@arm.com>, Robin Holt <holt@sgi.com>,
Pawel Moll <Pawel.Moll@arm.com>
Subject: Re: [PATCH] arm64: use common reboot infrastructure
Date: Wed, 17 Jul 2013 20:20:04 +0100 [thread overview]
Message-ID: <20130717192004.GD16496@MacBook-Pro.local> (raw)
In-Reply-To: <1373541180-7452-1-git-send-email-marc.zyngier@arm.com>
On Thu, Jul 11, 2013 at 12:13:00PM +0100, Marc Zyngier wrote:
> Commit 7b6d864b48d9 (reboot: arm: change reboot_mode to use enum
> reboot_mode) changed the way reboot is handled on arm, which has a
> direct impact on arm64 as we share the reset driver on the VE platform.
>
> The obvious fix is to move arm64 to use the same infrastructure.
>
> Cc: Robin Holt <holt@sgi.com>
> Cc: Pawel Moll <pawel.moll@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
I just did the same before I saw your patch. Anyway, I'll take yours as
you did it first ;)
> --- a/kernel/reboot.c
> +++ b/kernel/reboot.c
> @@ -25,7 +25,7 @@ int C_A_D = 1;
> struct pid *cad_pid;
> EXPORT_SYMBOL(cad_pid);
>
> -#if defined(CONFIG_ARM) || defined(CONFIG_UNICORE32)
> +#if defined(CONFIG_ARM) || defined(CONFIG_ARM64) || defined(CONFIG_UNICORE32)
> #define DEFAULT_REBOOT_MODE = REBOOT_HARD
> #else
> #define DEFAULT_REBOOT_MODE
Do we need this or we could use the default (I think REBOOT_COLD is 0)?
--
Catalin
next prev parent reply other threads:[~2013-07-17 19:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 11:13 [PATCH] arm64: use common reboot infrastructure Marc Zyngier
2013-07-11 11:13 ` Marc Zyngier
2013-07-17 19:20 ` Catalin Marinas [this message]
2013-07-17 19:20 ` Catalin Marinas
2013-07-19 9:56 ` Jean-Christophe PLAGNIOL-VILLARD
2013-07-19 9:56 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130717192004.GD16496@MacBook-Pro.local \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.