All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 1/2] MIPS: tlbex: Fix typo in r3000 tlb store handler
@ 2013-07-18 10:45 Tony Wu
  2013-07-18 10:47 ` [PATCH v2 2/2] MIPS: tlbex: Guard tlbmiss_handler_setup_pgd Tony Wu
  0 siblings, 1 reply; 2+ messages in thread
From: Tony Wu @ 2013-07-18 10:45 UTC (permalink / raw)
  To: ralf, Jayachandran C.; +Cc: linux-mips

commit 6ba045f (MIPS: Move generated code to .text for microMIPS)
causes a panic at boot. The handler builder should test against
handle_tlbs_end, not handle_tlbs.

Signed-off-by: Tony Wu <tung7970@gmail.com>
Cc: Jayachandran C <jchandra@broadcom.com>
Acked-by: Jayachandran C. <jchandra@broadcom.com>
---
 arch/mips/mm/tlbex.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/mm/tlbex.c b/arch/mips/mm/tlbex.c
index 9ab0f90..605b6fc 100644
--- a/arch/mips/mm/tlbex.c
+++ b/arch/mips/mm/tlbex.c
@@ -1803,7 +1803,7 @@ static void __cpuinit build_r3000_tlb_store_handler(void)
 	uasm_i_j(&p, (unsigned long)tlb_do_page_fault_1 & 0x0fffffff);
 	uasm_i_nop(&p);
 
-	if (p >= handle_tlbs)
+	if (p >= handle_tlbs_end)
 		panic("TLB store handler fastpath space exceeded");
 
 	uasm_resolve_relocs(relocs, labels);
-- 
1.7.10.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH v2 2/2] MIPS: tlbex: Guard tlbmiss_handler_setup_pgd
  2013-07-18 10:45 [PATCH v2 1/2] MIPS: tlbex: Fix typo in r3000 tlb store handler Tony Wu
@ 2013-07-18 10:47 ` Tony Wu
  0 siblings, 0 replies; 2+ messages in thread
From: Tony Wu @ 2013-07-18 10:47 UTC (permalink / raw)
  To: ralf, Jayachandran C.; +Cc: linux-mips

tlbmiss_handler_setup_pgd* are only referenced when
CONFIG_MIPS_PGD_C0_CONTEXT is defined.

Signed-off-by: Tony Wu <tung7970@gmail.com>
Cc: Jayachandran C <jchandra@broadcom.com>
---
 arch/mips/mm/tlb-funcs.S |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/mips/mm/tlb-funcs.S b/arch/mips/mm/tlb-funcs.S
index 30a494d..79bca31 100644
--- a/arch/mips/mm/tlb-funcs.S
+++ b/arch/mips/mm/tlb-funcs.S
@@ -16,10 +16,12 @@
 
 #define FASTPATH_SIZE	128
 
+#ifdef CONFIG_MIPS_PGD_C0_CONTEXT
 LEAF(tlbmiss_handler_setup_pgd)
 	.space		16 * 4
 END(tlbmiss_handler_setup_pgd)
 EXPORT(tlbmiss_handler_setup_pgd_end)
+#endif
 
 LEAF(handle_tlbm)
 	.space		FASTPATH_SIZE * 4
-- 
1.7.10.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-07-18 14:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-18 10:45 [PATCH v2 1/2] MIPS: tlbex: Fix typo in r3000 tlb store handler Tony Wu
2013-07-18 10:47 ` [PATCH v2 2/2] MIPS: tlbex: Guard tlbmiss_handler_setup_pgd Tony Wu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.