All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] usbserial: append Petatel NP10T device to GSM modems list
@ 2013-07-18 14:35 Dan Bolsun
  0 siblings, 0 replies; 3+ messages in thread
From: Dan Bolsun @ 2013-07-18 14:35 UTC (permalink / raw)
  To: Matthias Urlichs; +Cc: linux-kernel, linux-usb

This patch was tested on 3.10.1 kernel.

Same models of Petatel NP10T modems have different device IDs.
Unfortunately they have no additional revision information on a board
which may treat them as different devices. Currently I've seen only
two NP10T devices with various IDs. Possibly Petatel NP10T list will
be appended upon devices with new IDs will appear.

--- linux-3.10.1/drivers/usb/serial/option.c    2013-07-01
01:13:29.000000000 +0300
+++ linux-3.10.1.np10t/drivers/usb/serial/option.c      2013-07-18
16:15:36.902600324 +0300
@@ -446,7 +446,8 @@ static void option_instat_callback(struc

 /* Hyundai Petatel Inc. products */
 #define PETATEL_VENDOR_ID                      0x1ff4
-#define PETATEL_PRODUCT_NP10T                  0x600e
+#define PETATEL_PRODUCT_NP10T_600A             0x600a
+#define PETATEL_PRODUCT_NP10T_600E             0x600e

 /* TP-LINK Incorporated products */
 #define TPLINK_VENDOR_ID                       0x2357
@@ -1333,7 +1334,8 @@ static const struct usb_device_id option
        { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
MEDIATEK_PRODUCT_DC_4COM2, 0xff, 0x02, 0x01) },
        { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
MEDIATEK_PRODUCT_DC_4COM2, 0xff, 0x00, 0x00) },
        { USB_DEVICE(CELLIENT_VENDOR_ID, CELLIENT_PRODUCT_MEN200) },
-       { USB_DEVICE(PETATEL_VENDOR_ID, PETATEL_PRODUCT_NP10T) },
+       { USB_DEVICE(PETATEL_VENDOR_ID, PETATEL_PRODUCT_NP10T_600A) },
+       { USB_DEVICE(PETATEL_VENDOR_ID, PETATEL_PRODUCT_NP10T_600E) },
        { USB_DEVICE(TPLINK_VENDOR_ID, TPLINK_PRODUCT_MA180),
          .driver_info = (kernel_ulong_t)&net_intf4_blacklist },
        { USB_DEVICE(CHANGHONG_VENDOR_ID, CHANGHONG_PRODUCT_CH690) },

Signed-off-by: Daniil Bolsun <dan.bolsun@gmail.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] usbserial: append Petatel NP10T device to GSM modems list
@ 2013-07-19  7:21 Daniil Bolsun
  2013-07-19 19:20 ` Greg KH
  0 siblings, 1 reply; 3+ messages in thread
From: Daniil Bolsun @ 2013-07-19  7:21 UTC (permalink / raw)
  To: Matthias Urlichs; +Cc: linux-kernel, linux-usb

This patch was tested on 3.10.1 kernel.

Same models of Petatel NP10T modems have different device IDs.
Unfortunately they have no additional revision information on a board
which may treat them as different devices. Currently I've seen only
two NP10T devices with various IDs. Possibly Petatel NP10T list will
be appended upon devices with new IDs will appear.

Signed-off-by: Daniil Bolsun <dan.bolsun@gmail.com>

--- linux-3.10.1/drivers/usb/serial/option.c	2013-07-01 01:13:29.000000000 +0300
+++ linux-3.10.1.np10t/drivers/usb/serial/option.c	2013-07-18 16:15:36.902600324 +0300
@@ -446,7 +446,8 @@ static void option_instat_callback(struc
 
 /* Hyundai Petatel Inc. products */
 #define PETATEL_VENDOR_ID			0x1ff4
-#define PETATEL_PRODUCT_NP10T			0x600e
+#define PETATEL_PRODUCT_NP10T_600A		0x600a
+#define PETATEL_PRODUCT_NP10T_600E		0x600e
 
 /* TP-LINK Incorporated products */
 #define TPLINK_VENDOR_ID			0x2357
@@ -1333,7 +1334,8 @@ static const struct usb_device_id option
 	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, MEDIATEK_PRODUCT_DC_4COM2, 0xff, 0x02, 0x01) },
 	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, MEDIATEK_PRODUCT_DC_4COM2, 0xff, 0x00, 0x00) },
 	{ USB_DEVICE(CELLIENT_VENDOR_ID, CELLIENT_PRODUCT_MEN200) },
-	{ USB_DEVICE(PETATEL_VENDOR_ID, PETATEL_PRODUCT_NP10T) },
+	{ USB_DEVICE(PETATEL_VENDOR_ID, PETATEL_PRODUCT_NP10T_600A) },
+	{ USB_DEVICE(PETATEL_VENDOR_ID, PETATEL_PRODUCT_NP10T_600E) },
 	{ USB_DEVICE(TPLINK_VENDOR_ID, TPLINK_PRODUCT_MA180),
 	  .driver_info = (kernel_ulong_t)&net_intf4_blacklist },
 	{ USB_DEVICE(CHANGHONG_VENDOR_ID, CHANGHONG_PRODUCT_CH690) },

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] usbserial: append Petatel NP10T device to GSM modems list
  2013-07-19  7:21 [PATCH] usbserial: append Petatel NP10T device to GSM modems list Daniil Bolsun
@ 2013-07-19 19:20 ` Greg KH
  0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2013-07-19 19:20 UTC (permalink / raw)
  To: Daniil Bolsun; +Cc: Matthias Urlichs, linux-kernel, linux-usb

On Fri, Jul 19, 2013 at 10:21:23AM +0300, Daniil Bolsun wrote:
> This patch was tested on 3.10.1 kernel.
> 
> Same models of Petatel NP10T modems have different device IDs.
> Unfortunately they have no additional revision information on a board
> which may treat them as different devices. Currently I've seen only
> two NP10T devices with various IDs. Possibly Petatel NP10T list will
> be appended upon devices with new IDs will appear.
> 
> Signed-off-by: Daniil Bolsun <dan.bolsun@gmail.com>

Much better resubmission, thanks.  I'll queue it up in a few days and
you will get an automated email from my system then.

greg k-h

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-07-19 19:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-19  7:21 [PATCH] usbserial: append Petatel NP10T device to GSM modems list Daniil Bolsun
2013-07-19 19:20 ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2013-07-18 14:35 Dan Bolsun

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.