From: grant.likely@linaro.org (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] of: match the compatible in the order set by the dts file
Date: Sat, 20 Jul 2013 06:44:39 +0100 [thread overview]
Message-ID: <20130720054439.308B33E13F0@localhost> (raw)
In-Reply-To: <51DBC58D.90002@freescale.com>
On Tue, 9 Jul 2013 16:10:53 +0800, Huang Shijie <b32955@freescale.com> wrote:
> ??? 2013???07???09??? 15:51, Sascha Hauer ??????:
> > On Tue, Jul 09, 2013 at 03:46:34PM +0800, Huang Shijie wrote:
> >> ??? 2013???07???09??? 15:05, Sascha Hauer ??????:
> >>> Why don't you set the matching order in the driver the way you want it
> >>> to be, i.e.:
> >>>
> >>> { .compatible = "fsl,imx6q-uart", ... },
> >>> { .compatible = "fsl,imx21-uart", ... },
> >>> { .compatible = "fsl,imx1-uart", ... },
> >>>
> >> yes. i can set it like this.
> >>
> >> but this method looks like a ugly workaround.
> > If a driver has different ways of supporting a single device, then
> > putting the preferred or most feature rich on top doesn't look very ugly
> > to me.
> this method makes it much _coupled_ between the driver and the dts file.
>
> IMHO, it's an unnecessary _burden_ to the driver programmer:
> he should puts the most feature compatible on the top.
>
> it's much graceful if we let the driver programmer be transparent about
> this.
Absolutely true. Applied, thanks.
g.
WARNING: multiple messages have this Message-ID (diff)
From: Grant Likely <grant.likely@linaro.org>
To: Huang Shijie <b32955@freescale.com>,
Sascha Hauer <s.hauer@pengutronix.de>
Cc: devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, rob.herring@calxeda.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] of: match the compatible in the order set by the dts file
Date: Sat, 20 Jul 2013 06:44:39 +0100 [thread overview]
Message-ID: <20130720054439.308B33E13F0@localhost> (raw)
In-Reply-To: <51DBC58D.90002@freescale.com>
On Tue, 9 Jul 2013 16:10:53 +0800, Huang Shijie <b32955@freescale.com> wrote:
> 于 2013å¹´07月09æ—¥ 15:51, Sascha Hauer 写é“:
> > On Tue, Jul 09, 2013 at 03:46:34PM +0800, Huang Shijie wrote:
> >> 于 2013å¹´07月09æ—¥ 15:05, Sascha Hauer 写é“:
> >>> Why don't you set the matching order in the driver the way you want it
> >>> to be, i.e.:
> >>>
> >>> { .compatible = "fsl,imx6q-uart", ... },
> >>> { .compatible = "fsl,imx21-uart", ... },
> >>> { .compatible = "fsl,imx1-uart", ... },
> >>>
> >> yes. i can set it like this.
> >>
> >> but this method looks like a ugly workaround.
> > If a driver has different ways of supporting a single device, then
> > putting the preferred or most feature rich on top doesn't look very ugly
> > to me.
> this method makes it much _coupled_ between the driver and the dts file.
>
> IMHO, it's an unnecessary _burden_ to the driver programmer:
> he should puts the most feature compatible on the top.
>
> it's much graceful if we let the driver programmer be transparent about
> this.
Absolutely true. Applied, thanks.
g.
WARNING: multiple messages have this Message-ID (diff)
From: Grant Likely <grant.likely@linaro.org>
To: Huang Shijie <b32955@freescale.com>,
Sascha Hauer <s.hauer@pengutronix.de>
Cc: devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, rob.herring@calxeda.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] of: match the compatible in the order set by the dts file
Date: Sat, 20 Jul 2013 06:44:39 +0100 [thread overview]
Message-ID: <20130720054439.308B33E13F0@localhost> (raw)
In-Reply-To: <51DBC58D.90002@freescale.com>
On Tue, 9 Jul 2013 16:10:53 +0800, Huang Shijie <b32955@freescale.com> wrote:
> 于 2013年07月09日 15:51, Sascha Hauer 写道:
> > On Tue, Jul 09, 2013 at 03:46:34PM +0800, Huang Shijie wrote:
> >> 于 2013年07月09日 15:05, Sascha Hauer 写道:
> >>> Why don't you set the matching order in the driver the way you want it
> >>> to be, i.e.:
> >>>
> >>> { .compatible = "fsl,imx6q-uart", ... },
> >>> { .compatible = "fsl,imx21-uart", ... },
> >>> { .compatible = "fsl,imx1-uart", ... },
> >>>
> >> yes. i can set it like this.
> >>
> >> but this method looks like a ugly workaround.
> > If a driver has different ways of supporting a single device, then
> > putting the preferred or most feature rich on top doesn't look very ugly
> > to me.
> this method makes it much _coupled_ between the driver and the dts file.
>
> IMHO, it's an unnecessary _burden_ to the driver programmer:
> he should puts the most feature compatible on the top.
>
> it's much graceful if we let the driver programmer be transparent about
> this.
Absolutely true. Applied, thanks.
g.
next prev parent reply other threads:[~2013-07-20 5:44 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-05 8:43 [PATCH] of: match the compatible in the order set by the dts file Huang Shijie
2013-07-05 8:43 ` Huang Shijie
2013-07-05 8:43 ` Huang Shijie
2013-07-09 7:05 ` Sascha Hauer
2013-07-09 7:05 ` Sascha Hauer
2013-07-09 7:46 ` Huang Shijie
2013-07-09 7:46 ` Huang Shijie
2013-07-09 7:46 ` Huang Shijie
2013-07-09 7:51 ` Sascha Hauer
2013-07-09 7:51 ` Sascha Hauer
2013-07-09 8:10 ` Huang Shijie
2013-07-09 8:10 ` Huang Shijie
2013-07-09 8:10 ` Huang Shijie
2013-07-09 12:03 ` Rob Herring
2013-07-09 12:03 ` Rob Herring
2013-07-09 14:40 ` Stephen Warren
2013-07-09 14:40 ` Stephen Warren
2013-07-10 2:58 ` Huang Shijie
2013-07-10 2:58 ` Huang Shijie
2013-07-20 5:44 ` Grant Likely [this message]
2013-07-20 5:44 ` Grant Likely
2013-07-20 5:44 ` Grant Likely
2013-07-21 6:35 ` Thierry Reding
2013-07-21 6:35 ` Thierry Reding
2013-07-21 6:35 ` Thierry Reding
2013-07-21 20:45 ` Rob Herring
2013-07-21 20:45 ` Rob Herring
2013-07-21 20:45 ` Rob Herring
2013-07-21 23:36 ` Grant Likely
2013-07-21 23:36 ` Grant Likely
2013-07-09 14:27 ` Stephen Warren
2013-07-09 14:27 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130720054439.308B33E13F0@localhost \
--to=grant.likely@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.