* [PATCH] weston: add harfbuzz dependency
@ 2013-07-23 11:01 Alex DAMIAN
2013-07-23 12:44 ` Martin Jansa
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Alex DAMIAN @ 2013-07-23 11:01 UTC (permalink / raw)
To: ross.burton, sgw, openembedded-core; +Cc: Alexandru DAMIAN
From: Alexandru DAMIAN <alexandru.damian@intel.com>
Weston 1.1.0 has a build time dependency on libharfbuzz,
so we add it.
Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com>
---
meta/recipes-graphics/wayland/weston_1.1.0.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-graphics/wayland/weston_1.1.0.bb b/meta/recipes-graphics/wayland/weston_1.1.0.bb
index 7327b98..e324134 100644
--- a/meta/recipes-graphics/wayland/weston_1.1.0.bb
+++ b/meta/recipes-graphics/wayland/weston_1.1.0.bb
@@ -18,7 +18,7 @@ SRC_URI[sha256sum] = "e7715d2c731f77a729c994a599ffdaebac1307b2dd9336136706869fa5
inherit autotools pkgconfig useradd
DEPENDS = "libxkbcommon gdk-pixbuf pixman cairo glib-2.0 jpeg"
-DEPENDS += "wayland mesa virtual/egl"
+DEPENDS += "wayland mesa virtual/egl harfbuzz"
EXTRA_OECONF = "--disable-android-compositor \
--enable-setuid-install \
--
1.8.1.2
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] weston: add harfbuzz dependency
2013-07-23 11:01 [PATCH] weston: add harfbuzz dependency Alex DAMIAN
@ 2013-07-23 12:44 ` Martin Jansa
2013-07-23 13:06 ` Damian, Alexandru
2013-07-24 8:59 ` [PATCH v2] " Alex DAMIAN
2013-07-24 12:23 ` [PATCH v3] weston: add pango dependency Alex DAMIAN
2 siblings, 1 reply; 7+ messages in thread
From: Martin Jansa @ 2013-07-23 12:44 UTC (permalink / raw)
To: Alex DAMIAN; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 1430 bytes --]
On Tue, Jul 23, 2013 at 12:01:19PM +0100, Alex DAMIAN wrote:
> From: Alexandru DAMIAN <alexandru.damian@intel.com>
>
> Weston 1.1.0 has a build time dependency on libharfbuzz,
> so we add it.
I don't see that dependency in weston/master repo, are you sure it isn't
pulled by cairo/pango?
>
> Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com>
> ---
> meta/recipes-graphics/wayland/weston_1.1.0.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-graphics/wayland/weston_1.1.0.bb b/meta/recipes-graphics/wayland/weston_1.1.0.bb
> index 7327b98..e324134 100644
> --- a/meta/recipes-graphics/wayland/weston_1.1.0.bb
> +++ b/meta/recipes-graphics/wayland/weston_1.1.0.bb
> @@ -18,7 +18,7 @@ SRC_URI[sha256sum] = "e7715d2c731f77a729c994a599ffdaebac1307b2dd9336136706869fa5
> inherit autotools pkgconfig useradd
>
> DEPENDS = "libxkbcommon gdk-pixbuf pixman cairo glib-2.0 jpeg"
> -DEPENDS += "wayland mesa virtual/egl"
> +DEPENDS += "wayland mesa virtual/egl harfbuzz"
>
> EXTRA_OECONF = "--disable-android-compositor \
> --enable-setuid-install \
> --
> 1.8.1.2
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] weston: add harfbuzz dependency
2013-07-23 12:44 ` Martin Jansa
@ 2013-07-23 13:06 ` Damian, Alexandru
2013-07-23 13:15 ` Burton, Ross
0 siblings, 1 reply; 7+ messages in thread
From: Damian, Alexandru @ 2013-07-23 13:06 UTC (permalink / raw)
To: Martin Jansa; +Cc: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 1739 bytes --]
weston.spec clearly describes the dependency.
And I found it while trying to compile. It's needed.
On Tue, Jul 23, 2013 at 1:44 PM, Martin Jansa <martin.jansa@gmail.com>wrote:
> On Tue, Jul 23, 2013 at 12:01:19PM +0100, Alex DAMIAN wrote:
> > From: Alexandru DAMIAN <alexandru.damian@intel.com>
> >
> > Weston 1.1.0 has a build time dependency on libharfbuzz,
> > so we add it.
>
> I don't see that dependency in weston/master repo, are you sure it isn't
> pulled by cairo/pango?
>
> >
> > Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com>
> > ---
> > meta/recipes-graphics/wayland/weston_1.1.0.bb | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-graphics/wayland/weston_1.1.0.bbb/meta/recipes-graphics/wayland/
> weston_1.1.0.bb
> > index 7327b98..e324134 100644
> > --- a/meta/recipes-graphics/wayland/weston_1.1.0.bb
> > +++ b/meta/recipes-graphics/wayland/weston_1.1.0.bb
> > @@ -18,7 +18,7 @@ SRC_URI[sha256sum] =
> "e7715d2c731f77a729c994a599ffdaebac1307b2dd9336136706869fa5
> > inherit autotools pkgconfig useradd
> >
> > DEPENDS = "libxkbcommon gdk-pixbuf pixman cairo glib-2.0 jpeg"
> > -DEPENDS += "wayland mesa virtual/egl"
> > +DEPENDS += "wayland mesa virtual/egl harfbuzz"
> >
> > EXTRA_OECONF = "--disable-android-compositor \
> > --enable-setuid-install \
> > --
> > 1.8.1.2
> >
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
> --
> Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
>
--
Alex Damian
Yocto Project
SSG / OTC
[-- Attachment #2: Type: text/html, Size: 3034 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] weston: add harfbuzz dependency
2013-07-23 13:06 ` Damian, Alexandru
@ 2013-07-23 13:15 ` Burton, Ross
0 siblings, 0 replies; 7+ messages in thread
From: Burton, Ross @ 2013-07-23 13:15 UTC (permalink / raw)
To: Damian, Alexandru; +Cc: Patches and discussions about the oe-core layer
On 23 July 2013 14:06, Damian, Alexandru <alexandru.damian@intel.com> wrote:
> And I found it while trying to compile. It's needed.
Sure, but it's not a direct link in weston:
$ git describe HEAD
1.1.0
$ git grep -i harfbuzz
$
However, pangocairo *is* checked for and linked against, and that
isn't in DEPENDS, so the correct fix is to add "pango" to DEPENDS.
Ross
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2] weston: add harfbuzz dependency
2013-07-23 11:01 [PATCH] weston: add harfbuzz dependency Alex DAMIAN
2013-07-23 12:44 ` Martin Jansa
@ 2013-07-24 8:59 ` Alex DAMIAN
2013-07-24 10:26 ` Martin Jansa
2013-07-24 12:23 ` [PATCH v3] weston: add pango dependency Alex DAMIAN
2 siblings, 1 reply; 7+ messages in thread
From: Alex DAMIAN @ 2013-07-24 8:59 UTC (permalink / raw)
To: ross.burton, sgw, openembedded-core; +Cc: Alexandru DAMIAN
From: Alexandru DAMIAN <alexandru.damian@intel.com>
Weston 1.1.0 has a build time dependency on pango,
so we add it.
Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com>
---
meta/recipes-graphics/wayland/weston_1.1.0.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-graphics/wayland/weston_1.1.0.bb b/meta/recipes-graphics/wayland/weston_1.1.0.bb
index 7327b98..c7c64ad 100644
--- a/meta/recipes-graphics/wayland/weston_1.1.0.bb
+++ b/meta/recipes-graphics/wayland/weston_1.1.0.bb
@@ -18,7 +18,7 @@ SRC_URI[sha256sum] = "e7715d2c731f77a729c994a599ffdaebac1307b2dd9336136706869fa5
inherit autotools pkgconfig useradd
DEPENDS = "libxkbcommon gdk-pixbuf pixman cairo glib-2.0 jpeg"
-DEPENDS += "wayland mesa virtual/egl"
+DEPENDS += "wayland mesa virtual/egl pango"
EXTRA_OECONF = "--disable-android-compositor \
--enable-setuid-install \
--
1.8.1.2
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v2] weston: add harfbuzz dependency
2013-07-24 8:59 ` [PATCH v2] " Alex DAMIAN
@ 2013-07-24 10:26 ` Martin Jansa
0 siblings, 0 replies; 7+ messages in thread
From: Martin Jansa @ 2013-07-24 10:26 UTC (permalink / raw)
To: Alex DAMIAN; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 1373 bytes --]
On Wed, Jul 24, 2013 at 09:59:28AM +0100, Alex DAMIAN wrote:
> From: Alexandru DAMIAN <alexandru.damian@intel.com>
>
> Weston 1.1.0 has a build time dependency on pango,
> so we add it.
Subject doesn't match with what commit does now.
>
> Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com>
> ---
> meta/recipes-graphics/wayland/weston_1.1.0.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-graphics/wayland/weston_1.1.0.bb b/meta/recipes-graphics/wayland/weston_1.1.0.bb
> index 7327b98..c7c64ad 100644
> --- a/meta/recipes-graphics/wayland/weston_1.1.0.bb
> +++ b/meta/recipes-graphics/wayland/weston_1.1.0.bb
> @@ -18,7 +18,7 @@ SRC_URI[sha256sum] = "e7715d2c731f77a729c994a599ffdaebac1307b2dd9336136706869fa5
> inherit autotools pkgconfig useradd
>
> DEPENDS = "libxkbcommon gdk-pixbuf pixman cairo glib-2.0 jpeg"
> -DEPENDS += "wayland mesa virtual/egl"
> +DEPENDS += "wayland mesa virtual/egl pango"
>
> EXTRA_OECONF = "--disable-android-compositor \
> --enable-setuid-install \
> --
> 1.8.1.2
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v3] weston: add pango dependency
2013-07-23 11:01 [PATCH] weston: add harfbuzz dependency Alex DAMIAN
2013-07-23 12:44 ` Martin Jansa
2013-07-24 8:59 ` [PATCH v2] " Alex DAMIAN
@ 2013-07-24 12:23 ` Alex DAMIAN
2 siblings, 0 replies; 7+ messages in thread
From: Alex DAMIAN @ 2013-07-24 12:23 UTC (permalink / raw)
To: ross.burton, sgw, openembedded-core; +Cc: Alexandru DAMIAN
From: Alexandru DAMIAN <alexandru.damian@intel.com>
Weston 1.1.0 has a build time dependency on pango,
so we add it.
Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com>
---
meta/recipes-graphics/wayland/weston_1.1.0.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-graphics/wayland/weston_1.1.0.bb b/meta/recipes-graphics/wayland/weston_1.1.0.bb
index 7327b98..c7c64ad 100644
--- a/meta/recipes-graphics/wayland/weston_1.1.0.bb
+++ b/meta/recipes-graphics/wayland/weston_1.1.0.bb
@@ -18,7 +18,7 @@ SRC_URI[sha256sum] = "e7715d2c731f77a729c994a599ffdaebac1307b2dd9336136706869fa5
inherit autotools pkgconfig useradd
DEPENDS = "libxkbcommon gdk-pixbuf pixman cairo glib-2.0 jpeg"
-DEPENDS += "wayland mesa virtual/egl"
+DEPENDS += "wayland mesa virtual/egl pango"
EXTRA_OECONF = "--disable-android-compositor \
--enable-setuid-install \
--
1.8.1.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-07-24 12:23 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-23 11:01 [PATCH] weston: add harfbuzz dependency Alex DAMIAN
2013-07-23 12:44 ` Martin Jansa
2013-07-23 13:06 ` Damian, Alexandru
2013-07-23 13:15 ` Burton, Ross
2013-07-24 8:59 ` [PATCH v2] " Alex DAMIAN
2013-07-24 10:26 ` Martin Jansa
2013-07-24 12:23 ` [PATCH v3] weston: add pango dependency Alex DAMIAN
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.