From: Peter Zijlstra <peterz@infradead.org>
To: Rakib Mullick <rakib.mullick@gmail.com>
Cc: mingo@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH, RFC] sched: update_top_cache_domain only at the times of building sched domain.
Date: Tue, 23 Jul 2013 17:47:36 +0200 [thread overview]
Message-ID: <20130723154736.GB27075@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1374594257.5382.5.camel@localhost.localdomain>
On Tue, Jul 23, 2013 at 09:44:17PM +0600, Rakib Mullick wrote:
> Currently, update_top_cache_domain() is called whenever schedule domain is built or destroyed. But, the following
> callpath shows that they're at the same callpath and can be avoided update_top_cache_domain() while destroying schedule
> domain and update only at the times of building schedule domains.
>
> partition_sched_domains()
> detach_destroy_domain()
> cpu_attach_domain()
> update_top_cache_domain()
> build_sched_domains()
> cpu_attach_domain()
> update_top_cache_domain()
>
Does it really matter?
>
> Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>
> ---
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index b7c32cb..8c6fee4 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -5102,8 +5102,8 @@ static void update_top_cache_domain(int cpu)
> * Attach the domain 'sd' to 'cpu' as its base domain. Callers must
> * hold the hotplug lock.
> */
> -static void
> -cpu_attach_domain(struct sched_domain *sd, struct root_domain *rd, int cpu)
> +static void cpu_attach_domain(struct sched_domain *sd, struct root_domain *rd,
> + int cpu, bool update_cache_domain)
> {
> struct rq *rq = cpu_rq(cpu);
> struct sched_domain *tmp;
> @@ -5138,7 +5138,8 @@ cpu_attach_domain(struct sched_domain *sd, struct root_domain *rd, int cpu)
> rcu_assign_pointer(rq->sd, sd);
> destroy_sched_domains(tmp, cpu);
>
> - update_top_cache_domain(cpu);
> + if (update_cache_domain)
> + update_top_cache_domain(cpu);
> }
>
> /* cpus with isolated domains */
> @@ -6021,7 +6022,7 @@ static int build_sched_domains(const struct cpumask *cpu_map,
> rcu_read_lock();
> for_each_cpu(i, cpu_map) {
> sd = *per_cpu_ptr(d.sd, i);
> - cpu_attach_domain(sd, d.rd, i);
> + cpu_attach_domain(sd, d.rd, i, 1);
> }
> rcu_read_unlock();
>
> @@ -6109,7 +6110,7 @@ static void detach_destroy_domains(const struct cpumask *cpu_map)
>
> rcu_read_lock();
> for_each_cpu(i, cpu_map)
> - cpu_attach_domain(NULL, &def_root_domain, i);
> + cpu_attach_domain(NULL, &def_root_domain, i, 0);
> rcu_read_unlock();
> }
This just makes the code uglier for no gain afaict.
If you really need to do this, key off @sd == NULL or something.
next prev parent reply other threads:[~2013-07-23 15:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 15:44 [PATCH, RFC] sched: update_top_cache_domain only at the times of building sched domain Rakib Mullick
2013-07-23 15:47 ` Peter Zijlstra [this message]
2013-07-23 16:09 ` Rakib Mullick
2013-07-23 16:20 ` Rakib Mullick
2013-07-23 16:53 ` Peter Zijlstra
2013-07-23 17:21 ` Rakib Mullick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130723154736.GB27075@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rakib.mullick@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.