All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Rakib Mullick <rakib.mullick@gmail.com>
Cc: mingo@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH, RFC] sched: update_top_cache_domain only at the times of building sched domain.
Date: Tue, 23 Jul 2013 18:53:19 +0200	[thread overview]
Message-ID: <20130723165319.GC27075@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <CADZ9YHj9vQU7Ki2+mCH5TPGUrn_d3V5bks9dumyEGcMwX3XApA@mail.gmail.com>

On Tue, Jul 23, 2013 at 10:20:20PM +0600, Rakib Mullick wrote:

> You mean using sd == NULL rather than using update_cache_domain variable ?

Yes, note how:

@@ -6109,7 +6110,7 @@ static void detach_destroy_domains(const struct cpumask *cpu_map)

        rcu_read_lock();
        for_each_cpu(i, cpu_map)
-               cpu_attach_domain(NULL, &def_root_domain, i);
        rcu_read_unlock();
 }

Always has NULL for sd? Which means you can do:

@@ -5138,7 +5138,8 @@ cpu_attach_domain(struct sched_domain *sd, struct root_domain *rd, int cpu)
        rcu_assign_pointer(rq->sd, sd);
        destroy_sched_domains(tmp, cpu);

-       update_top_cache_domain(cpu);
+       if (sd)
+               update_top_cache_domain(cpu);
 }

 /* cpus with isolated domains */

  reply	other threads:[~2013-07-23 16:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-23 15:44 [PATCH, RFC] sched: update_top_cache_domain only at the times of building sched domain Rakib Mullick
2013-07-23 15:47 ` Peter Zijlstra
2013-07-23 16:09   ` Rakib Mullick
2013-07-23 16:20     ` Rakib Mullick
2013-07-23 16:53       ` Peter Zijlstra [this message]
2013-07-23 17:21         ` Rakib Mullick

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130723165319.GC27075@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=rakib.mullick@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.