All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Linux MM <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Pavel Emelyanov <xemul@parallels.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Matt Mackall <mpm@selenic.com>,
	Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH] mm: Save soft-dirty bits on swapped pages
Date: Wed, 24 Jul 2013 20:37:34 +0400	[thread overview]
Message-ID: <20130724163734.GE24851@moon> (raw)
In-Reply-To: <CALCETrXYnkonpBANnUuX+aJ=B=EYFwecZO27yrqcEU8WErz9DA@mail.gmail.com>

On Wed, Jul 24, 2013 at 09:23:14AM -0700, Andy Lutomirski wrote:
> On Wed, Jul 24, 2013 at 9:08 AM, Cyrill Gorcunov <gorcunov@gmail.com> wrote:
> > Andy Lutomirski reported that in case if a page with _PAGE_SOFT_DIRTY
> > bit set get swapped out, the bit is getting lost and no longer
> > available when pte read back.
> 
> Potentially silly question (due to my completely lack of understanding
> of how swapping works in Linux): what about file-backed pages?
> (Arguably these would be best supported by filesystems instead of by
> the core vm, in which case it might make sense to drop soft-dirty
> support for these pages entirely.)

Hi Andy, if I understand you correctly "file-backed pages" are carried
in pte with _PAGE_FILE bit set and the swap soft-dirty bit won't be
used on them but _PAGE_SOFT_DIRTY will be set on write if only I've
not missed something obvious (Pavel?).

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Linux MM <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Pavel Emelyanov <xemul@parallels.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Matt Mackall <mpm@selenic.com>,
	Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH] mm: Save soft-dirty bits on swapped pages
Date: Wed, 24 Jul 2013 20:37:34 +0400	[thread overview]
Message-ID: <20130724163734.GE24851@moon> (raw)
In-Reply-To: <CALCETrXYnkonpBANnUuX+aJ=B=EYFwecZO27yrqcEU8WErz9DA@mail.gmail.com>

On Wed, Jul 24, 2013 at 09:23:14AM -0700, Andy Lutomirski wrote:
> On Wed, Jul 24, 2013 at 9:08 AM, Cyrill Gorcunov <gorcunov@gmail.com> wrote:
> > Andy Lutomirski reported that in case if a page with _PAGE_SOFT_DIRTY
> > bit set get swapped out, the bit is getting lost and no longer
> > available when pte read back.
> 
> Potentially silly question (due to my completely lack of understanding
> of how swapping works in Linux): what about file-backed pages?
> (Arguably these would be best supported by filesystems instead of by
> the core vm, in which case it might make sense to drop soft-dirty
> support for these pages entirely.)

Hi Andy, if I understand you correctly "file-backed pages" are carried
in pte with _PAGE_FILE bit set and the swap soft-dirty bit won't be
used on them but _PAGE_SOFT_DIRTY will be set on write if only I've
not missed something obvious (Pavel?).

  reply	other threads:[~2013-07-24 16:37 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-24 16:08 [PATCH] mm: Save soft-dirty bits on swapped pages Cyrill Gorcunov
2013-07-24 16:08 ` Cyrill Gorcunov
2013-07-24 16:23 ` Andy Lutomirski
2013-07-24 16:23   ` Andy Lutomirski
2013-07-24 16:37   ` Cyrill Gorcunov [this message]
2013-07-24 16:37     ` Cyrill Gorcunov
2013-07-24 17:06     ` Andy Lutomirski
2013-07-24 17:06       ` Andy Lutomirski
2013-07-24 17:17       ` Cyrill Gorcunov
2013-07-24 17:17         ` Cyrill Gorcunov
2013-07-24 17:36         ` James Bottomley
2013-07-24 17:36           ` James Bottomley
2013-07-24 17:42           ` Andy Lutomirski
2013-07-24 17:42             ` Andy Lutomirski
2013-07-24 18:15             ` Cyrill Gorcunov
2013-07-24 18:15               ` Cyrill Gorcunov
2013-07-24 18:21               ` Andy Lutomirski
2013-07-24 18:21                 ` Andy Lutomirski
2013-07-24 18:52                 ` Cyrill Gorcunov
2013-07-24 18:52                   ` Cyrill Gorcunov
2013-07-24 18:55                   ` Pavel Emelyanov
2013-07-24 18:55                     ` Pavel Emelyanov
2013-07-24 19:04                     ` Cyrill Gorcunov
2013-07-24 19:04                       ` Cyrill Gorcunov
2013-07-24 19:18                       ` Cyrill Gorcunov
2013-07-24 19:18                         ` Cyrill Gorcunov
2013-07-24 19:40                       ` Andy Lutomirski
2013-07-24 19:40                         ` Andy Lutomirski
2013-07-25  7:07                         ` Cyrill Gorcunov
2013-07-25  7:07                           ` Cyrill Gorcunov
2013-07-25  7:29                         ` Pavel Emelyanov
2013-07-25  7:29                           ` Pavel Emelyanov
2013-07-25  8:26                           ` Hush Bensen
2013-07-25  8:26                             ` Hush Bensen
2013-07-25  8:43                             ` Pavel Emelyanov
2013-07-25  8:43                               ` Pavel Emelyanov
2013-07-25 16:02                           ` Andy Lutomirski
2013-07-25 16:02                             ` Andy Lutomirski
2013-07-24 18:52   ` Pavel Emelyanov
2013-07-24 18:52     ` Pavel Emelyanov
2013-07-24 18:52 ` Pavel Emelyanov
2013-07-24 18:52   ` Pavel Emelyanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130724163734.GE24851@moon \
    --to=gorcunov@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=kosaki.motohiro@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=luto@amacapital.net \
    --cc=mpm@selenic.com \
    --cc=mtosatti@redhat.com \
    --cc=sfr@canb.auug.org.au \
    --cc=xemul@parallels.com \
    --cc=xiaoguangrong@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.