All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Myers <bpm@sgi.com>
To: Josef Bacik <jbacik@fusionio.com>
Cc: linux-btrfs@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: make the scratch device for generic/256 slightly larger
Date: Wed, 24 Jul 2013 18:07:12 -0500	[thread overview]
Message-ID: <20130724230712.GV3111@sgi.com> (raw)
In-Reply-To: <1372792638-23957-1-git-send-email-jbacik@fusionio.com>

On Tue, Jul 02, 2013 at 03:17:18PM -0400, Josef Bacik wrote:
> This is similar to a previous fix I sent.  1 gig makes us do mixed file block
> groups for btrfs, so these enospc tests will usually fail because we don't have
> space for metadata, which is the case for this test.  So jack the size up to
> 1.5gig so that btrfs can do its normal thing and pass the test.  Thanks,
> 
> Signed-off-by: Josef Bacik <jbacik@fusionio.com>

Looks fine to me.  

Reviewed-by: Ben Myers <bpm@sgi.com>

WARNING: multiple messages have this Message-ID (diff)
From: Ben Myers <bpm@sgi.com>
To: Josef Bacik <jbacik@fusionio.com>
Cc: linux-btrfs@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: make the scratch device for generic/256 slightly larger
Date: Wed, 24 Jul 2013 18:07:12 -0500	[thread overview]
Message-ID: <20130724230712.GV3111@sgi.com> (raw)
In-Reply-To: <1372792638-23957-1-git-send-email-jbacik@fusionio.com>

On Tue, Jul 02, 2013 at 03:17:18PM -0400, Josef Bacik wrote:
> This is similar to a previous fix I sent.  1 gig makes us do mixed file block
> groups for btrfs, so these enospc tests will usually fail because we don't have
> space for metadata, which is the case for this test.  So jack the size up to
> 1.5gig so that btrfs can do its normal thing and pass the test.  Thanks,
> 
> Signed-off-by: Josef Bacik <jbacik@fusionio.com>

Looks fine to me.  

Reviewed-by: Ben Myers <bpm@sgi.com>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2013-07-24 23:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-02 19:17 [PATCH] xfstests: make the scratch device for generic/256 slightly larger Josef Bacik
2013-07-02 19:17 ` Josef Bacik
2013-07-24 23:07 ` Ben Myers [this message]
2013-07-24 23:07   ` Ben Myers
2013-08-16 14:12 ` Rich Johnston
2013-08-16 14:12   ` Rich Johnston

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130724230712.GV3111@sgi.com \
    --to=bpm@sgi.com \
    --cc=jbacik@fusionio.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.