All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anton Blanchard <anton@samba.org>
To: Scott Wood <scottwood@freescale.com>
Cc: Neil Horman <nhorman@tuxdriver.com>,
	Rusty Russell <rusty@rustcorp.com.au>,
	linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] module: ppc64 module CRC relocation fix causes perf issues
Date: Thu, 25 Jul 2013 08:34:27 +1000	[thread overview]
Message-ID: <20130725083427.56e36010@kryten> (raw)
In-Reply-To: <1374274770.5357.33@snotra>


Hi Scott,

> I'm not really sure what it's supposed to look like when "perf  
> annotate" works.  It spits a bunch of unreadable[1]
> dark-blue-on-black assembly code at me, all with "0.00 :" in the left
> column.
> 
> Oh, wait -- some lines have "100.00 : " on the left, in  
> even-more-unreadable dark-red-on-black.
> 
> Apart from the annoying colors, is there anything specific I should
> be looking for?  Some sort of error message, or output that actually
> makes sense?

Thanks for testing! Ben, I think the patch is good to go.

Anton

WARNING: multiple messages have this Message-ID (diff)
From: Anton Blanchard <anton@samba.org>
To: Scott Wood <scottwood@freescale.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Rusty Russell <rusty@rustcorp.com.au>,
	Neil Horman <nhorman@tuxdriver.com>,
	<linuxppc-dev@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] module: ppc64 module CRC relocation fix causes perf issues
Date: Thu, 25 Jul 2013 08:34:27 +1000	[thread overview]
Message-ID: <20130725083427.56e36010@kryten> (raw)
In-Reply-To: <1374274770.5357.33@snotra>


Hi Scott,

> I'm not really sure what it's supposed to look like when "perf  
> annotate" works.  It spits a bunch of unreadable[1]
> dark-blue-on-black assembly code at me, all with "0.00 :" in the left
> column.
> 
> Oh, wait -- some lines have "100.00 : " on the left, in  
> even-more-unreadable dark-red-on-black.
> 
> Apart from the annoying colors, is there anything specific I should
> be looking for?  Some sort of error message, or output that actually
> makes sense?

Thanks for testing! Ben, I think the patch is good to go.

Anton

  parent reply	other threads:[~2013-07-24 22:34 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-15  4:04 [PATCH] module: ppc64 module CRC relocation fix causes perf issues Anton Blanchard
2013-07-15  4:39 ` Rusty Russell
2013-07-15  8:47 ` Benjamin Herrenschmidt
2013-07-15  8:47   ` Benjamin Herrenschmidt
2013-07-16 22:40   ` Scott Wood
2013-07-16 22:40     ` Scott Wood
2013-07-17  0:04     ` Benjamin Herrenschmidt
2013-07-17  0:04       ` Benjamin Herrenschmidt
2013-07-17  0:08       ` Scott Wood
2013-07-17  0:08         ` Scott Wood
2013-07-18  4:00         ` Anton Blanchard
2013-07-18  4:00           ` Anton Blanchard
2013-07-19 22:59           ` Scott Wood
2013-07-19 22:59             ` Scott Wood
2013-07-23 13:30             ` Michael Ellerman
2013-07-23 13:30               ` Michael Ellerman
2013-07-24 19:22               ` Scott Wood
2013-07-24 19:22                 ` Scott Wood
2013-07-24 22:34             ` Anton Blanchard [this message]
2013-07-24 22:34               ` Anton Blanchard
2013-07-24 23:14               ` Benjamin Herrenschmidt
2013-07-24 23:14                 ` Benjamin Herrenschmidt
2013-07-25 13:02                 ` Neil Horman
2013-07-25 13:02                   ` Neil Horman
2013-07-26  1:19                   ` Anton Blanchard
2013-07-26  1:19                     ` Anton Blanchard
2013-07-26 13:11                     ` Neil Horman
2013-07-26 13:11                       ` Neil Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130725083427.56e36010@kryten \
    --to=anton@samba.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=nhorman@tuxdriver.com \
    --cc=paulus@samba.org \
    --cc=rusty@rustcorp.com.au \
    --cc=scottwood@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.