From: Markus Pargmann <mpa@pengutronix.de>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] video: imxfb: Add feature to setup PWM Contrast Control Register
Date: Thu, 25 Jul 2013 13:38:56 +0000 [thread overview]
Message-ID: <20130725133824.GD16871@s25.your-server.de> (raw)
In-Reply-To: <1374395709-20898-2-git-send-email-shc_work@mail.ru>
Hi,
On Sun, Jul 21, 2013 at 12:35:09PM +0400, Alexander Shiyan wrote:
> This patch adds feature to setup PWM Contrast Control Register.
> This register is used to control the signal output at the contrast pin,
> which controls contrast of the LCD panel.
http://www.spinics.net/lists/linux-fbdev/msg10002.html
Regards,
Markus
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
> Documentation/devicetree/bindings/video/fsl,imx-fb.txt | 1 +
> drivers/video/imxfb.c | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/video/fsl,imx-fb.txt b/Documentation/devicetree/bindings/video/fsl,imx-fb.txt
> index 46da08d..be10c65 100644
> --- a/Documentation/devicetree/bindings/video/fsl,imx-fb.txt
> +++ b/Documentation/devicetree/bindings/video/fsl,imx-fb.txt
> @@ -18,6 +18,7 @@ Optional properties:
> - fsl,dmacr: DMA Control Register value. This is optional. By default, the
> register is not modified as recommended by the datasheet.
> - fsl,lscr1: LCDC Sharp Configuration Register value.
> +- fsl,pwmr: LCDC PWM Contrast Control Register value.
>
> Example:
>
> diff --git a/drivers/video/imxfb.c b/drivers/video/imxfb.c
> index 8e104c4..d98299a 100644
> --- a/drivers/video/imxfb.c
> +++ b/drivers/video/imxfb.c
> @@ -806,8 +806,8 @@ static int imxfb_init_fbinfo(struct platform_device *pdev,
>
> fbi->lscr1 = IMXFB_LSCR1_DEFAULT;
> of_property_read_u32(np, "fsl,lscr1", &fbi->lscr1);
> -
> of_property_read_u32(np, "fsl,dmacr", &fbi->dmacr);
> + of_property_read_u32(np, "fsl,pwmr", &fbi->pwmr);
>
> /* These two function pointers could be used by some specific
> * platforms. */
> --
> 1.8.1.5
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
WARNING: multiple messages have this Message-ID (diff)
From: mpa@pengutronix.de (Markus Pargmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] video: imxfb: Add feature to setup PWM Contrast Control Register
Date: Thu, 25 Jul 2013 15:38:56 +0200 [thread overview]
Message-ID: <20130725133824.GD16871@s25.your-server.de> (raw)
In-Reply-To: <1374395709-20898-2-git-send-email-shc_work@mail.ru>
Hi,
On Sun, Jul 21, 2013 at 12:35:09PM +0400, Alexander Shiyan wrote:
> This patch adds feature to setup PWM Contrast Control Register.
> This register is used to control the signal output at the contrast pin,
> which controls contrast of the LCD panel.
http://www.spinics.net/lists/linux-fbdev/msg10002.html
Regards,
Markus
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
> Documentation/devicetree/bindings/video/fsl,imx-fb.txt | 1 +
> drivers/video/imxfb.c | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/video/fsl,imx-fb.txt b/Documentation/devicetree/bindings/video/fsl,imx-fb.txt
> index 46da08d..be10c65 100644
> --- a/Documentation/devicetree/bindings/video/fsl,imx-fb.txt
> +++ b/Documentation/devicetree/bindings/video/fsl,imx-fb.txt
> @@ -18,6 +18,7 @@ Optional properties:
> - fsl,dmacr: DMA Control Register value. This is optional. By default, the
> register is not modified as recommended by the datasheet.
> - fsl,lscr1: LCDC Sharp Configuration Register value.
> +- fsl,pwmr: LCDC PWM Contrast Control Register value.
>
> Example:
>
> diff --git a/drivers/video/imxfb.c b/drivers/video/imxfb.c
> index 8e104c4..d98299a 100644
> --- a/drivers/video/imxfb.c
> +++ b/drivers/video/imxfb.c
> @@ -806,8 +806,8 @@ static int imxfb_init_fbinfo(struct platform_device *pdev,
>
> fbi->lscr1 = IMXFB_LSCR1_DEFAULT;
> of_property_read_u32(np, "fsl,lscr1", &fbi->lscr1);
> -
> of_property_read_u32(np, "fsl,dmacr", &fbi->dmacr);
> + of_property_read_u32(np, "fsl,pwmr", &fbi->pwmr);
>
> /* These two function pointers could be used by some specific
> * platforms. */
> --
> 1.8.1.5
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2013-07-25 13:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-21 8:35 [PATCH 1/2] video: imxfb: Fix retrieve values from DT Alexander Shiyan
2013-07-21 8:35 ` Alexander Shiyan
2013-07-21 8:35 ` [PATCH 2/2] video: imxfb: Add feature to setup PWM Contrast Control Register Alexander Shiyan
2013-07-21 8:35 ` Alexander Shiyan
2013-07-25 13:38 ` Markus Pargmann [this message]
2013-07-25 13:38 ` Markus Pargmann
2013-07-25 17:20 ` Alexander Shiyan
2013-07-25 17:20 ` Alexander Shiyan
2013-07-26 7:38 ` Sascha Hauer
2013-07-26 7:38 ` Sascha Hauer
2013-07-26 7:59 ` [PATCH 2/2] video: imxfb: Add feature to =?UTF-8?B?c2V0dXAgUFdNIENvb Alexander Shiyan
2013-07-26 7:59 ` [PATCH 2/2] video: imxfb: Add feature to setup PWM Contrast Control Register Alexander Shiyan
2014-07-01 6:23 ` [PATCH 2/2] video: clps711x: Fix sparse warnings Alexander Shiyan
2014-07-01 10:31 ` Alexander Shiyan
2014-07-04 8:35 ` Alexander Shiyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130725133824.GD16871@s25.your-server.de \
--to=mpa@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.