All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Retry DP aux_ch communications with a different clock after failure
Date: Fri, 26 Jul 2013 19:45:46 +0200	[thread overview]
Message-ID: <20130726174546.GF6084@phenom.ffwll.local> (raw)
In-Reply-To: <87k3kd5z3i.fsf@intel.com>

On Fri, Jul 26, 2013 at 02:40:01PM +0300, Jani Nikula wrote:
> On Sun, 21 Jul 2013, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > The w/a db makes the recommendation to both use a non-default value for
> > the initial clock and then to retry with an alternative clock for
> > Haswell with the Lakeport PCH.
> >
> > "On LPT:H, use a divider value of 63 decimal (03Fh). If there is a
> > failure, retry at least three times with 63, then retry at least three
> > times with 72 decimal (048h)."
> 
> Overall I'd prefer adding the outer repeat loop first, keeping existing
> behaviour, and only then adding the divider value changes in
> get_aux_clock_divider(). But that's in the bikeshedding dept. Either
> way,
> 
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>

Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

      reply	other threads:[~2013-07-26 17:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-21 15:00 [PATCH] drm/i915: Retry DP aux_ch communications with a different clock after failure Chris Wilson
2013-07-26 11:40 ` Jani Nikula
2013-07-26 17:45   ` Daniel Vetter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130726174546.GF6084@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.