From: Greg KH <gregkh@linuxfoundation.org>
To: Huang Shijie <b32955@freescale.com>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
shawn.guo@linaro.org, linux-arm-kernel@lists.infradead.org,
linux-serial@vger.kernel.org
Subject: Re: [PATCH v2 2/3] serial: mxs: enable the DMA only when the RTS/CTS is valid
Date: Fri, 26 Jul 2013 16:10:08 -0700 [thread overview]
Message-ID: <20130726231008.GA32627@kroah.com> (raw)
In-Reply-To: <51E648C2.3010304@freescale.com>
On Wed, Jul 17, 2013 at 03:33:22PM +0800, Huang Shijie wrote:
> 于 2013年07月16日 17:54, Uwe Kleine-König 写道:
> >On Tue, Jul 16, 2013 at 02:55:31PM +0800, Huang Shijie wrote:
> >>The original DMA support works only when RTS/CTS is enabled.
> >What is original here?
> >
> i will add more information for this in the next version.
> >>But after several patches, DMA support has lost this limit.
> >This is still misleading.
> >
> >>This patch adds an optional property for the UART DT node
> >>which indicates the UART has RTS and CTS lines.
> >>
> >>This patch also adds a macro MXS_AUART_RTSCTS, and uses it to check
> >>RTS/CTS before we enable the DMA for the UART.
> >I still think this should go to stable. The options are:
> >
> > a) also take patch 1 into stable
> > b) apply this patch without patch 1
> >
> >I don't know if option a) is OK, b) is probably preferable. And as Greg
> to Greg:
>
> I think a) is ok to me. what's your opinion?
Please reorder them, making patch 2 first, and mark it for stable, then
do patch 1, and the rest, so I don't have to take non-needed patches
into the stable tree.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: gregkh@linuxfoundation.org (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/3] serial: mxs: enable the DMA only when the RTS/CTS is valid
Date: Fri, 26 Jul 2013 16:10:08 -0700 [thread overview]
Message-ID: <20130726231008.GA32627@kroah.com> (raw)
In-Reply-To: <51E648C2.3010304@freescale.com>
On Wed, Jul 17, 2013 at 03:33:22PM +0800, Huang Shijie wrote:
> ? 2013?07?16? 17:54, Uwe Kleine-K?nig ??:
> >On Tue, Jul 16, 2013 at 02:55:31PM +0800, Huang Shijie wrote:
> >>The original DMA support works only when RTS/CTS is enabled.
> >What is original here?
> >
> i will add more information for this in the next version.
> >>But after several patches, DMA support has lost this limit.
> >This is still misleading.
> >
> >>This patch adds an optional property for the UART DT node
> >>which indicates the UART has RTS and CTS lines.
> >>
> >>This patch also adds a macro MXS_AUART_RTSCTS, and uses it to check
> >>RTS/CTS before we enable the DMA for the UART.
> >I still think this should go to stable. The options are:
> >
> > a) also take patch 1 into stable
> > b) apply this patch without patch 1
> >
> >I don't know if option a) is OK, b) is probably preferable. And as Greg
> to Greg:
>
> I think a) is ok to me. what's your opinion?
Please reorder them, making patch 2 first, and mark it for stable, then
do patch 1, and the rest, so I don't have to take non-needed patches
into the stable tree.
thanks,
greg k-h
next prev parent reply other threads:[~2013-07-26 23:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-16 6:55 [PATCH v2 0/3] serial: mxs-auart: add RTS/CTS check for DMA support Huang Shijie
2013-07-16 6:55 ` Huang Shijie
2013-07-16 6:55 ` [PATCH v2 1/3] serial: mxs: remove the MXS_AUART_DMA_CONFIG Huang Shijie
2013-07-16 6:55 ` Huang Shijie
2013-07-16 6:55 ` [PATCH v2 2/3] serial: mxs: enable the DMA only when the RTS/CTS is valid Huang Shijie
2013-07-16 6:55 ` Huang Shijie
2013-07-16 9:54 ` Uwe Kleine-König
2013-07-16 9:54 ` Uwe Kleine-König
2013-07-17 7:33 ` Huang Shijie
2013-07-17 7:33 ` Huang Shijie
2013-07-26 23:10 ` Greg KH [this message]
2013-07-26 23:10 ` Greg KH
2013-07-16 6:55 ` [PATCH v2 3/3] ARM: dts: imx28-evk: add the RTS/CTS property for auart0 Huang Shijie
2013-07-16 6:55 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130726231008.GA32627@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=b32955@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=shawn.guo@linaro.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.