Re: [Qemu-devel] [PATCH 1/6] pc: move IO_APIC_DEFAULT_ADDRESS to include/hw/i386/ioapic.h

[Igor Mammedov <imammedo@redhat.com>]

On Sun, 28 Jul 2013 11:54:46 +0200
Andreas Färber <afaerber@suse.de> wrote:

> Am 28.07.2013 09:29, schrieb Igor Mammedov:
> > From: "Michael S. Tsirkin" <mst@redhat.com>
> > 
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> 
> Missing Reviewed-bys from Gerd and me.
it changed file form apic.h to ioapic.h, so I haven't felt comfortble adding
yours Reviewed-bys.
I sure can add it if it's ok. 

> 
> Andreas
> 
> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> > ---
> >  hw/i386/pc.c             | 2 --
> >  include/hw/i386/ioapic.h | 1 +
> >  2 files changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> > index 2a87563..b0b98a8 100644
> > --- a/hw/i386/pc.c
> > +++ b/hw/i386/pc.c
> > @@ -75,8 +75,6 @@
> >  #define FW_CFG_E820_TABLE (FW_CFG_ARCH_LOCAL + 3)
> >  #define FW_CFG_HPET (FW_CFG_ARCH_LOCAL + 4)
> >  
> > -#define IO_APIC_DEFAULT_ADDRESS 0xfec00000
> > -
> >  #define E820_NR_ENTRIES		16
> >  
> >  struct e820_entry {
> > diff --git a/include/hw/i386/ioapic.h b/include/hw/i386/ioapic.h
> > index 86e63da..6245388 100644
> > --- a/include/hw/i386/ioapic.h
> > +++ b/include/hw/i386/ioapic.h
> > @@ -21,6 +21,7 @@
> >  #define HW_IOAPIC_H
> >  
> >  #define IOAPIC_NUM_PINS 24
> > +#define IO_APIC_DEFAULT_ADDRESS 0xfec00000
> >  
> >  void ioapic_eoi_broadcast(int vector);
> >  
> > 
> 
> 
> -- 
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg


-- 
Regards,
  Igor