Re: [Qemu-devel] [PATCH 5/6] pc: add Q35 to QOM composition tree under /machine

["Andreas Färber" <afaerber@suse.de>]

Am 28.07.2013 09:29, schrieb Igor Mammedov:
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
>  hw/i386/pc_q35.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
> index 0b1d2e3..5140caf 100644
> --- a/hw/i386/pc_q35.c
> +++ b/hw/i386/pc_q35.c
> @@ -130,7 +130,7 @@ static void pc_q35_init(QEMUMachineInitArgs *args)
>  
>      /* create pci host bus */
>      q35_host = Q35_HOST_DEVICE(qdev_create(NULL, TYPE_Q35_HOST_DEVICE));
> -
> +    object_property_add_child(qdev_get_machine(), "q35", OBJECT(q35_host), NULL);
>      q35_host->mch.ram_memory = ram_memory;
>      q35_host->mch.pci_address_space = pci_memory;
>      q35_host->mch.system_memory = get_system_memory();

Reviewed-by: Andreas Färber <afaerber@suse.de>

Thanks a lot, I was about to send the equivalent patch!

This is a Last Minute guest-visible change, but it matches what we have
for i440fx, so I consider this fine.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg