From: Steffen Klassert <steffen.klassert@secunet.com>
To: David Miller <davem@davemloft.net>
Cc: dan.carpenter@oracle.com, herbert@gondor.hengli.com.au,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
minipli@googlemail.com
Subject: Re: [patch -mainline v2] af_key: more info leaks in pfkey messages
Date: Mon, 29 Jul 2013 09:16:53 +0000 [thread overview]
Message-ID: <20130729091653.GS3109@secunet.com> (raw)
In-Reply-To: <20130728.132128.473273050357111535.davem@davemloft.net>
On Sun, Jul 28, 2013 at 01:21:28PM -0700, David Miller wrote:
> From: Dan Carpenter <dan.carpenter@oracle.com>
> Date: Sun, 28 Jul 2013 23:04:45 +0300
>
> > This is inspired by a5cc68f3d6 "af_key: fix info leaks in notify
> > messages". There are some struct members which don't get initialized
> > and could disclose small amounts of private information.
> >
> > Acked-by: Mathias Krause <minipli@googlemail.com>
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > v2: set ->sadb_x_policy_priority correctly instead of just clearing it
>
> I'll apply this as soon as Steffen reviews it.
The patch looks good, for the case you want to apply it directly to
the net tree:
Acked-by: Steffen Klassert <steffen.klassert@secunet.com>
WARNING: multiple messages have this Message-ID (diff)
From: Steffen Klassert <steffen.klassert@secunet.com>
To: David Miller <davem@davemloft.net>
Cc: dan.carpenter@oracle.com, herbert@gondor.hengli.com.au,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
minipli@googlemail.com
Subject: Re: [patch -mainline v2] af_key: more info leaks in pfkey messages
Date: Mon, 29 Jul 2013 11:16:53 +0200 [thread overview]
Message-ID: <20130729091653.GS3109@secunet.com> (raw)
In-Reply-To: <20130728.132128.473273050357111535.davem@davemloft.net>
On Sun, Jul 28, 2013 at 01:21:28PM -0700, David Miller wrote:
> From: Dan Carpenter <dan.carpenter@oracle.com>
> Date: Sun, 28 Jul 2013 23:04:45 +0300
>
> > This is inspired by a5cc68f3d6 "af_key: fix info leaks in notify
> > messages". There are some struct members which don't get initialized
> > and could disclose small amounts of private information.
> >
> > Acked-by: Mathias Krause <minipli@googlemail.com>
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > v2: set ->sadb_x_policy_priority correctly instead of just clearing it
>
> I'll apply this as soon as Steffen reviews it.
The patch looks good, for the case you want to apply it directly to
the net tree:
Acked-by: Steffen Klassert <steffen.klassert@secunet.com>
next prev parent reply other threads:[~2013-07-29 9:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-24 10:39 [patch -mainline] af_key: more info leaks in pfkey messages Dan Carpenter
2013-07-24 10:39 ` Dan Carpenter
2013-07-25 7:15 ` Mathias Krause
2013-07-25 7:15 ` Mathias Krause
2013-07-25 7:32 ` Steffen Klassert
2013-07-25 7:32 ` Steffen Klassert
2013-07-25 8:24 ` Dan Carpenter
2013-07-25 8:24 ` Dan Carpenter
2013-07-28 20:04 ` [patch -mainline v2] " Dan Carpenter
2013-07-28 20:04 ` Dan Carpenter
2013-07-28 20:21 ` David Miller
2013-07-28 20:21 ` David Miller
2013-07-29 9:16 ` Steffen Klassert [this message]
2013-07-29 9:16 ` Steffen Klassert
2013-07-30 23:26 ` David Miller
2013-07-30 23:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130729091653.GS3109@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.hengli.com.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=minipli@googlemail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.