Re: [Qemu-devel] [PATCH v4 0/3] qemu-help: improve -device command line help

["Michael S. Tsirkin" <mst@redhat.com>]

On Mon, Jul 29, 2013 at 05:17:42PM +0300, Marcel Apfelbaum wrote:
> Running qemu with "-device ?" option returns ~145 lines.
> It is hard to manage understanding the output.
> 
> Theses patches aim to partially solve the problem by dividing the devices
> into logical categories like "Network/Display/..." and sorting them by it.

For the series:

Reviewed-by: Michael S. Tsirkin <mst@redhat.com>


> Changes from v3:
>     - fixed a memory leak in patch 2/3
> Addressed Michael S. Tsirkin's review
>     - removed dead code
>     - qdev_print_class_devinfo can print info
>       on abstract classes
> Addressed Paolo Bonzini's review
>     - Renamed "Assembly" category to "Controller/Bridge/Hub"
> 
> Changes from v2:
> Addressed Michael S. Tsirkin's review
>    - assign category to its name explicitly
>    - refactoring of unsafe code
> Addressed Paolo Bonzini's review
>    - moved several devices to the correct category
>    - replaced Management category by USB 
> 
> Changes from v1:
> Addressed Michael S. Tsirkin review:
> Used bitmap operations on categories
> Moved category names into the header file
> 
> Changes from RFC patch:
> Made category a bitmap to support multifunction PCI devices.
> Assigned all devices to their category.
> 
> Marcel Apfelbaum (3):
>   hw: import bitmap operations in qdev-core header
>   qemu-help: Sort devices by logical functionality
>   devices: Associate devices to their logical category
> 
>  hw/9pfs/virtio-9p-device.c         |  1 +
>  hw/audio/ac97.c                    |  1 +
>  hw/audio/adlib.c                   |  1 +
>  hw/audio/cs4231a.c                 |  1 +
>  hw/audio/es1370.c                  |  1 +
>  hw/audio/gus.c                     |  1 +
>  hw/audio/hda-codec.c               |  3 +++
>  hw/audio/intel-hda.c               |  3 +++
>  hw/audio/pcspk.c                   |  1 +
>  hw/audio/pl041.c                   |  1 +
>  hw/audio/sb16.c                    |  1 +
>  hw/block/fdc.c                     |  3 +++
>  hw/block/nvme.c                    |  1 +
>  hw/block/pc_sysfw.c                |  1 +
>  hw/block/pflash_cfi01.c            |  1 +
>  hw/block/virtio-blk.c              |  1 +
>  hw/char/debugcon.c                 |  1 +
>  hw/char/imx_serial.c               |  1 +
>  hw/char/ipack.c                    |  1 +
>  hw/char/ipoctal232.c               |  1 +
>  hw/char/parallel.c                 |  1 +
>  hw/char/serial-isa.c               |  1 +
>  hw/char/serial-pci.c               |  3 +++
>  hw/char/tpci200.c                  |  1 +
>  hw/char/virtio-serial-bus.c        |  2 ++
>  hw/core/qdev-properties.c          | 13 ++++++-----
>  hw/cpu/icc_bus.c                   |  8 +++++++
>  hw/display/cirrus_vga.c            |  2 ++
>  hw/display/g364fb.c                |  1 +
>  hw/display/pl110.c                 |  3 +++
>  hw/display/qxl.c                   |  2 ++
>  hw/display/vga-isa.c               |  1 +
>  hw/display/vga-pci.c               |  1 +
>  hw/display/vmware_vga.c            |  1 +
>  hw/i2c/bitbang_i2c.c               |  1 +
>  hw/i2c/core.c                      |  1 +
>  hw/i386/kvm/pci-assign.c           |  1 +
>  hw/ide/ahci.c                      |  1 +
>  hw/ide/ich.c                       |  1 +
>  hw/ide/isa.c                       |  1 +
>  hw/ide/piix.c                      |  3 +++
>  hw/ide/qdev.c                      |  1 +
>  hw/ide/via.c                       |  1 +
>  hw/isa/i82378.c                    |  1 +
>  hw/isa/lpc_ich9.c                  |  1 +
>  hw/isa/vt82c686.c                  |  3 +++
>  hw/misc/applesmc.c                 |  1 +
>  hw/misc/debugexit.c                |  1 +
>  hw/misc/ivshmem.c                  |  1 +
>  hw/misc/pc-testdev.c               |  1 +
>  hw/misc/pci-testdev.c              |  1 +
>  hw/misc/sga.c                      |  1 +
>  hw/misc/vfio.c                     |  1 +
>  hw/net/e1000.c                     |  1 +
>  hw/net/eepro100.c                  |  3 ++-
>  hw/net/lance.c                     |  1 +
>  hw/net/mipsnet.c                   |  1 +
>  hw/net/ne2000-isa.c                |  1 +
>  hw/net/ne2000.c                    |  1 +
>  hw/net/opencores_eth.c             |  1 +
>  hw/net/pcnet-pci.c                 |  1 +
>  hw/net/rtl8139.c                   |  1 +
>  hw/net/virtio-net.c                |  1 +
>  hw/net/vmxnet3.c                   |  1 +
>  hw/pci-bridge/i82801b11.c          |  2 ++
>  hw/pci-bridge/ioh3420.c            |  1 +
>  hw/pci-bridge/pci_bridge_dev.c     |  1 +
>  hw/pci-bridge/xio3130_downstream.c |  1 +
>  hw/pci-bridge/xio3130_upstream.c   |  1 +
>  hw/pci-host/apb.c                  |  2 ++
>  hw/pci-host/ppce500.c              |  1 +
>  hw/pci-host/prep.c                 |  1 +
>  hw/pci-host/q35.c                  |  2 ++
>  hw/scsi/esp-pci.c                  |  2 ++
>  hw/scsi/esp.c                      |  1 +
>  hw/scsi/lsi53c895a.c               |  1 +
>  hw/scsi/megasas.c                  |  1 +
>  hw/scsi/scsi-bus.c                 |  1 +
>  hw/scsi/vhost-scsi.c               |  1 +
>  hw/scsi/virtio-scsi.c              |  3 +++
>  hw/scsi/vmw_pvscsi.c               |  1 +
>  hw/usb/ccid-card-emulated.c        |  1 +
>  hw/usb/ccid-card-passthru.c        |  1 +
>  hw/usb/dev-audio.c                 |  1 +
>  hw/usb/dev-bluetooth.c             |  1 +
>  hw/usb/dev-hid.c                   |  3 +++
>  hw/usb/dev-hub.c                   |  1 +
>  hw/usb/dev-network.c               |  1 +
>  hw/usb/dev-serial.c                |  2 ++
>  hw/usb/dev-smartcard-reader.c      |  1 +
>  hw/usb/dev-storage.c               |  1 +
>  hw/usb/dev-uas.c                   |  1 +
>  hw/usb/dev-wacom.c                 |  1 +
>  hw/usb/hcd-ehci-pci.c              |  2 ++
>  hw/usb/hcd-ehci-sysbus.c           |  9 +++++++
>  hw/usb/hcd-ohci.c                  |  2 ++
>  hw/usb/hcd-uhci.c                  |  1 +
>  hw/usb/hcd-xhci.c                  |  1 +
>  hw/usb/host-libusb.c               |  1 +
>  hw/usb/host-linux.c                |  1 +
>  hw/usb/redirect.c                  |  1 +
>  hw/virtio/virtio-balloon.c         |  1 +
>  hw/virtio/virtio-mmio.c            |  1 +
>  hw/virtio/virtio-pci.c             |  8 +++++++
>  hw/virtio/virtio-rng.c             |  1 +
>  hw/watchdog/wdt_i6300esb.c         |  1 +
>  hw/watchdog/wdt_ib700.c            |  1 +
>  hw/xen/xen_platform.c              |  1 +
>  hw/xen/xen_pt.c                    |  1 +
>  include/hw/qdev-core.h             | 30 ++++++++++++++++++++++++
>  qdev-monitor.c                     | 48 +++++++++++++++++++++++++++++++-------
>  111 files changed, 235 insertions(+), 16 deletions(-)
> 
> -- 
> 1.8.3.1