Re: [Qemu-devel] [PATCH v4 0/3] qemu-help: improve -device command line help

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 945 bytes --]

On 08/13/2013 03:57 AM, Markus Armbruster wrote:
> This isn't patch review, just a couple of observations and questions.
> 

> 
> Should we require devices to have at least one category?

If they can be enabled from the command line, yes.  (Consider '-device
pvpanic, which was NOT available in qemu 1.5 because it was
unconditional; and for qemu 1.6 which will be conditional in the -M
pc-1.6 but unconditional in -M pc-1.5 for back-compat - part of exposing
it as conditional in 1.6 was giving it a category).

> 
> Eric, does libvirt still parse -device help?  If yes, can it cope with
> the addition of "categories ..."?

Since qemu 1.3, libvirt has been parsing only QMP commands to learn
about device availability (qom-list-types, if I'm  not mistaken); -help
text is therefore irrelevant, so change away :)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]