From: Stephen Boyd <sboyd@codeaurora.org>
To: Kumar Gala <galak@codeaurora.org>
Cc: ohad@wizery.com,
"linux-kernel@vger.kernel.org list"
<linux-kernel@vger.kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
Jeffrey Hugo <jhugo@codeaurora.org>,
Eric Holmberg <eholmber@codeaurora.org>
Subject: Re: [PATCH] hwspinlock/msm: Add support for Qualcomm MSM HW Mutex block
Date: Mon, 29 Jul 2013 17:28:49 -0700 [thread overview]
Message-ID: <20130730002849.GE8868@codeaurora.org> (raw)
In-Reply-To: <9EB1A821-7137-4812-B58A-20F669BCA7DD@codeaurora.org>
On 07/29, Kumar Gala wrote:
>
> On Jul 29, 2013, at 4:40 PM, Stephen Boyd wrote:
>
> > On 07/29, Kumar Gala wrote:
> >>> +#include <linux/of_device.h>
> >>> +#include <linux/hwspinlock.h>
> >>> +
> >>> +#include <asm/io.h>
> >
> > <linux/io.h> please.
>
> will change, I choice <asm/io.h> since *_relaxed are arm specific.
>
I thought readl_relaxed() was universal for HAS_IOMEM arches.
Unfortunately writel_relaxed() isn't defined on all arches.
Luckily this driver depends on ARCH_MSM so it isn't a problem.
Perhaps it should just depend on HAS_IOMEM so we can use it on
arm64 and/or hexagon in the future without having to change the
Kconfig. That would require introducing writel_relaxed() into the
other arches that don't have it right now.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2013-07-30 0:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 20:11 [PATCH] hwspinlock/msm: Add support for Qualcomm MSM HW Mutex block Kumar Gala
2013-07-29 20:14 ` Kumar Gala
2013-07-29 21:40 ` Stephen Boyd
2013-07-29 21:54 ` Kumar Gala
2013-07-30 0:28 ` Stephen Boyd [this message]
2013-08-01 14:10 ` Kumar Gala
2013-08-10 19:11 ` Ohad Ben-Cohen
2013-08-12 16:30 ` Stephen Boyd
2013-08-12 17:00 ` Kumar Gala
2013-08-12 17:24 ` Kumar Gala
2013-08-13 6:01 ` Ohad Ben-Cohen
2013-08-13 13:58 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130730002849.GE8868@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=eholmber@codeaurora.org \
--cc=galak@codeaurora.org \
--cc=jhugo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.