From: Felipe Balbi <balbi@ti.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Felipe Balbi <balbi@ti.com>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Roger Quadros <rogerq@ti.com>
Subject: Re: linux-next: build failure after merge of the usb-gadget tree
Date: Tue, 30 Jul 2013 08:49:33 +0300 [thread overview]
Message-ID: <20130730054933.GB9155@radagast> (raw)
In-Reply-To: <20130730143427.9b8560de8d74ed73f0ad561b@canb.auug.org.au>
[-- Attachment #1: Type: text/plain, Size: 1286 bytes --]
Hi,
On Tue, Jul 30, 2013 at 02:34:27PM +1000, Stephen Rothwell wrote:
> Hi Felipe,
>
> After merging the usb-gadget tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> drivers/usb/phy/of.c:32:24: error: redefinition of 'of_usb_get_phy_mode'
> enum usb_phy_interface of_usb_get_phy_mode(struct device_node *np)
> ^
> In file included from drivers/usb/phy/of.c:13:0:
> include/linux/usb/of.h:33:38: note: previous definition of 'of_usb_get_phy_mode' was here
> static inline enum usb_phy_interface of_usb_get_phy_mode(struct device_node *np)
> ^
>
> Caused by commit 052a11d13bde ("usb: phy: make PHY driver selection
> possible by controller drivers"). The static inline declaration in
> include/linux/usb/of.h is exposed if at least one of CONFIG_OF or
> CONFIG_USB_PHY is not set, but drivers/usb/phy/of.c is now built if
> CONFIG_OF and CONFIG_USB_SUPPORT is set (it used to require
> CONFIG_USB_PHY to be set - see drivers/usb/Makefile). This build has
> CONFIG_OF set but CONFIG_USB_PHY not set.
>
> I have used the usb-gadget tree from next-20130729 for today.
looks like I didn't get that in my randconfigs, I'll go fix that up
Thanks
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@ti.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Felipe Balbi <balbi@ti.com>, <linux-next@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, Roger Quadros <rogerq@ti.com>
Subject: Re: linux-next: build failure after merge of the usb-gadget tree
Date: Tue, 30 Jul 2013 08:49:33 +0300 [thread overview]
Message-ID: <20130730054933.GB9155@radagast> (raw)
In-Reply-To: <20130730143427.9b8560de8d74ed73f0ad561b@canb.auug.org.au>
[-- Attachment #1: Type: text/plain, Size: 1286 bytes --]
Hi,
On Tue, Jul 30, 2013 at 02:34:27PM +1000, Stephen Rothwell wrote:
> Hi Felipe,
>
> After merging the usb-gadget tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> drivers/usb/phy/of.c:32:24: error: redefinition of 'of_usb_get_phy_mode'
> enum usb_phy_interface of_usb_get_phy_mode(struct device_node *np)
> ^
> In file included from drivers/usb/phy/of.c:13:0:
> include/linux/usb/of.h:33:38: note: previous definition of 'of_usb_get_phy_mode' was here
> static inline enum usb_phy_interface of_usb_get_phy_mode(struct device_node *np)
> ^
>
> Caused by commit 052a11d13bde ("usb: phy: make PHY driver selection
> possible by controller drivers"). The static inline declaration in
> include/linux/usb/of.h is exposed if at least one of CONFIG_OF or
> CONFIG_USB_PHY is not set, but drivers/usb/phy/of.c is now built if
> CONFIG_OF and CONFIG_USB_SUPPORT is set (it used to require
> CONFIG_USB_PHY to be set - see drivers/usb/Makefile). This build has
> CONFIG_OF set but CONFIG_USB_PHY not set.
>
> I have used the usb-gadget tree from next-20130729 for today.
looks like I didn't get that in my randconfigs, I'll go fix that up
Thanks
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-07-30 5:49 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-30 4:34 linux-next: build failure after merge of the usb-gadget tree Stephen Rothwell
2013-07-30 5:49 ` Felipe Balbi [this message]
2013-07-30 5:49 ` Felipe Balbi
-- strict thread matches above, loose matches on Subject: below --
2013-12-09 3:58 Stephen Rothwell
2013-12-09 4:11 ` Felipe Balbi
2013-12-09 4:11 ` Felipe Balbi
2013-12-09 19:40 ` Felipe Balbi
2013-12-09 19:40 ` Felipe Balbi
2013-12-09 20:43 ` Stephen Rothwell
2013-12-09 20:43 ` Stephen Rothwell
2013-12-09 21:01 ` Felipe Balbi
2013-12-09 21:01 ` Felipe Balbi
2013-12-09 21:42 ` Felipe Balbi
2013-12-09 21:42 ` Felipe Balbi
2013-12-17 4:36 ` Stephen Rothwell
2013-12-17 4:36 ` Stephen Rothwell
2013-12-17 5:08 ` Felipe Balbi
2013-12-17 5:08 ` Felipe Balbi
2013-12-17 5:13 ` Felipe Balbi
2013-12-17 5:13 ` Felipe Balbi
2013-12-16 4:40 Stephen Rothwell
2013-12-16 19:41 ` Felipe Balbi
2013-12-16 19:41 ` Felipe Balbi
2013-12-16 23:10 ` Stephen Rothwell
2013-12-16 23:10 ` Stephen Rothwell
2013-12-16 23:38 ` Felipe Balbi
2013-12-16 23:38 ` Felipe Balbi
2013-12-17 4:27 ` Stephen Rothwell
2013-12-17 4:27 ` Stephen Rothwell
2015-05-29 8:32 Stephen Rothwell
2015-05-29 15:19 ` Felipe Balbi
2020-03-16 3:37 Stephen Rothwell
2020-03-16 17:42 ` John Stultz
2020-03-16 18:11 ` John Stultz
2020-03-16 19:46 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130730054933.GB9155@radagast \
--to=balbi@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rogerq@ti.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.