From: Andrew Morton <akpm@linux-foundation.org>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Michal Hocko <mhocko@suse.cz>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kosaki.motohiro@jp.fujitsu.com, kamezawa.hiroyu@jp.fujitsu.com,
bp@suse.de, Dave Hansen <dave@linux.vnet.ibm.com>
Subject: Re: [PATCH resend] drop_caches: add some documentation and info message
Date: Tue, 30 Jul 2013 08:08:10 -0700 [thread overview]
Message-ID: <20130730080810.9a0a2d71.akpm@linux-foundation.org> (raw)
In-Reply-To: <51F7D1F0.20309@intel.com>
On Tue, 30 Jul 2013 07:47:12 -0700 Dave Hansen <dave.hansen@intel.com> wrote:
> On 07/30/2013 05:55 AM, Michal Hocko wrote:
> >> > If we add another flag in the future it can use bit 3?
> > What if we get crazy and need more of them?
>
> I really hate using bits for these kinds of interfaces. I'm forgetful
> and never remember which bit is which, and they're possible to run out of.
>
> I'm not saying do it now, but we can switch over to:
>
> echo 'slab|pagecache' > drop_caches
> or
> echo 'quiet|slab' > drop_caches
>
> any time we want and still have compatibility with the existing bitwise
> interface.
/bin/drop_caches "slab|pagecache"
That we always insist on doing such things in the kernel instead is
exhibit #1 in Why We Suck.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Michal Hocko <mhocko@suse.cz>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kosaki.motohiro@jp.fujitsu.com, kamezawa.hiroyu@jp.fujitsu.com,
bp@suse.de, Dave Hansen <dave@linux.vnet.ibm.com>
Subject: Re: [PATCH resend] drop_caches: add some documentation and info message
Date: Tue, 30 Jul 2013 08:08:10 -0700 [thread overview]
Message-ID: <20130730080810.9a0a2d71.akpm@linux-foundation.org> (raw)
In-Reply-To: <51F7D1F0.20309@intel.com>
On Tue, 30 Jul 2013 07:47:12 -0700 Dave Hansen <dave.hansen@intel.com> wrote:
> On 07/30/2013 05:55 AM, Michal Hocko wrote:
> >> > If we add another flag in the future it can use bit 3?
> > What if we get crazy and need more of them?
>
> I really hate using bits for these kinds of interfaces. I'm forgetful
> and never remember which bit is which, and they're possible to run out of.
>
> I'm not saying do it now, but we can switch over to:
>
> echo 'slab|pagecache' > drop_caches
> or
> echo 'quiet|slab' > drop_caches
>
> any time we want and still have compatibility with the existing bitwise
> interface.
/bin/drop_caches "slab|pagecache"
That we always insist on doing such things in the kernel instead is
exhibit #1 in Why We Suck.
next prev parent reply other threads:[~2013-07-30 15:08 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 12:44 [PATCH resend] drop_caches: add some documentation and info message Michal Hocko
2013-07-26 12:44 ` Michal Hocko
2013-07-26 21:37 ` Johannes Weiner
2013-07-26 21:37 ` Johannes Weiner
2013-07-29 20:57 ` Andrew Morton
2013-07-29 20:57 ` Andrew Morton
2013-07-30 7:45 ` Michal Hocko
2013-07-30 7:45 ` Michal Hocko
2013-07-30 8:25 ` Andrew Morton
2013-07-30 8:25 ` Andrew Morton
2013-07-30 12:55 ` Michal Hocko
2013-07-30 12:55 ` Michal Hocko
2013-07-30 14:39 ` Andrew Morton
2013-07-30 14:39 ` Andrew Morton
2013-07-30 14:47 ` Michal Hocko
2013-07-30 14:47 ` Michal Hocko
2013-07-30 14:47 ` Dave Hansen
2013-07-30 14:47 ` Dave Hansen
2013-07-30 14:54 ` Borislav Petkov
2013-07-30 14:54 ` Borislav Petkov
2013-07-30 15:08 ` Andrew Morton [this message]
2013-07-30 15:08 ` Andrew Morton
2013-08-01 3:11 ` KOSAKI Motohiro
2013-08-01 3:11 ` KOSAKI Motohiro
2013-08-01 3:17 ` Andrew Morton
2013-08-01 3:17 ` Andrew Morton
2013-08-02 1:39 ` KOSAKI Motohiro
2013-08-02 1:39 ` KOSAKI Motohiro
2013-08-02 7:33 ` Michal Hocko
2013-08-02 7:33 ` Michal Hocko
2013-08-03 20:16 ` KOSAKI Motohiro
2013-08-03 20:16 ` KOSAKI Motohiro
2013-08-04 8:07 ` Michal Hocko
2013-08-04 8:07 ` Michal Hocko
2013-08-05 1:13 ` KOSAKI Motohiro
2013-08-05 1:13 ` KOSAKI Motohiro
2013-08-05 7:20 ` Michal Hocko
2013-08-05 7:20 ` Michal Hocko
2013-09-17 15:14 ` Johannes Weiner
2013-09-17 15:14 ` Johannes Weiner
2013-08-02 16:04 ` Rob Landley
2013-08-02 16:04 ` Rob Landley
2013-08-02 17:10 ` Dave Hansen
2013-08-02 17:10 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130730080810.9a0a2d71.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bp@suse.de \
--cc=dave.hansen@intel.com \
--cc=dave@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.