All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Felipe Balbi <balbi@ti.com>
Cc: Rajendra Nayak <rnayak@ti.com>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	paul@pwsan.com, khilman@linaro.org, benoit.cousson@gmail.com,
	r.sricharan@ti.com, ambresh@ti.com, sourav.poddar@ti.com
Subject: Re: [PATCH v2 1/8] ARM: DRA7: id: Add cpu detection support for DRA7xx based SoCs'
Date: Tue, 30 Jul 2013 06:55:27 -0700	[thread overview]
Message-ID: <20130730135527.GM7656@atomide.com> (raw)
In-Reply-To: <20130730131837.GB28162@radagast>

* Felipe Balbi <balbi@ti.com> [130730 06:25]:
> On Tue, Jul 30, 2013 at 04:10:09PM +0300, Felipe Balbi wrote:
> > Hi,
> > 
> > On Tue, Jul 30, 2013 at 04:55:39PM +0530, Rajendra Nayak wrote:
> > > @@ -379,6 +407,13 @@ IS_OMAP_TYPE(3430, 0x3430)
> > >  # define soc_is_omap543x()		is_omap543x()
> > >  #endif
> > >  
> > > +# if defined(CONFIG_SOC_DRA7XX)
> > > +# undef soc_is_dra7xx
> > > +# undef soc_is_dra75x
> > > +# define soc_is_dra7xx()		is_dra7xx()
> > > +# define soc_is_dra75x()		is_dra75x()
> > 
> > since this platform is DT-only, couldn't we just believe DT-data to be
> > correct of_machine_is_compatible() ? 2/3 of this patch would be removed.
> 
> s/correct of_/correct and use of_

Makes sense to me. AFAIK we no longer need to initialize much
anything super early.

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/8] ARM: DRA7: id: Add cpu detection support for DRA7xx based SoCs'
Date: Tue, 30 Jul 2013 06:55:27 -0700	[thread overview]
Message-ID: <20130730135527.GM7656@atomide.com> (raw)
In-Reply-To: <20130730131837.GB28162@radagast>

* Felipe Balbi <balbi@ti.com> [130730 06:25]:
> On Tue, Jul 30, 2013 at 04:10:09PM +0300, Felipe Balbi wrote:
> > Hi,
> > 
> > On Tue, Jul 30, 2013 at 04:55:39PM +0530, Rajendra Nayak wrote:
> > > @@ -379,6 +407,13 @@ IS_OMAP_TYPE(3430, 0x3430)
> > >  # define soc_is_omap543x()		is_omap543x()
> > >  #endif
> > >  
> > > +# if defined(CONFIG_SOC_DRA7XX)
> > > +# undef soc_is_dra7xx
> > > +# undef soc_is_dra75x
> > > +# define soc_is_dra7xx()		is_dra7xx()
> > > +# define soc_is_dra75x()		is_dra75x()
> > 
> > since this platform is DT-only, couldn't we just believe DT-data to be
> > correct of_machine_is_compatible() ? 2/3 of this patch would be removed.
> 
> s/correct of_/correct and use of_

Makes sense to me. AFAIK we no longer need to initialize much
anything super early.

Regards,

Tony

  reply	other threads:[~2013-07-30 13:55 UTC|newest]

Thread overview: 82+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-30 11:25 [PATCH v2 0/8] DRA7xx core support Rajendra Nayak
2013-07-30 11:25 ` Rajendra Nayak
2013-07-30 11:25 ` [PATCH v2 1/8] ARM: DRA7: id: Add cpu detection support for DRA7xx based SoCs' Rajendra Nayak
2013-07-30 11:25   ` Rajendra Nayak
2013-07-30 13:10   ` Felipe Balbi
2013-07-30 13:10     ` Felipe Balbi
2013-07-30 13:18     ` Felipe Balbi
2013-07-30 13:18       ` Felipe Balbi
2013-07-30 13:55       ` Tony Lindgren [this message]
2013-07-30 13:55         ` Tony Lindgren
2013-07-30 14:18     ` Sricharan R
2013-07-30 14:18       ` Sricharan R
2013-07-30 14:23       ` Felipe Balbi
2013-07-30 14:23         ` Felipe Balbi
2013-07-30 14:36         ` Sricharan R
2013-07-30 14:36           ` Sricharan R
2013-07-30 15:32           ` Felipe Balbi
2013-07-30 15:32             ` Felipe Balbi
2013-07-30 18:37             ` Sricharan R
2013-07-30 18:37               ` Sricharan R
2013-07-30 18:43               ` Nishanth Menon
2013-07-30 18:43                 ` Nishanth Menon
2013-07-31  6:02                 ` Rajendra Nayak
2013-07-31  6:02                   ` Rajendra Nayak
2013-07-31  6:42                   ` Tony Lindgren
2013-07-31  6:42                     ` Tony Lindgren
2013-07-31  6:49                     ` Rajendra Nayak
2013-07-31  6:49                       ` Rajendra Nayak
2013-07-30 11:25 ` [PATCH v2 2/8] ARM: DRA7: hwmod: Reuse the soc_ops used for OMAP4/5 Rajendra Nayak
2013-07-30 11:25   ` Rajendra Nayak
2013-07-30 11:25 ` [PATCH v2 3/8] ARM: DRA7: Reuse all of PRCM and MPUSS SMP infra Rajendra Nayak
2013-07-30 11:25   ` Rajendra Nayak
2013-07-30 12:26   ` Nishanth Menon
2013-07-30 12:26     ` Nishanth Menon
2013-07-30 12:38     ` Rajendra Nayak
2013-07-30 12:38       ` Rajendra Nayak
2013-07-30 12:41       ` Nishanth Menon
2013-07-30 12:41         ` Nishanth Menon
2013-07-30 12:48         ` Rajendra Nayak
2013-07-30 12:48           ` Rajendra Nayak
2013-07-30 12:57           ` Nishanth Menon
2013-07-30 12:57             ` Nishanth Menon
2013-07-30 12:59             ` Rajendra Nayak
2013-07-30 12:59               ` Rajendra Nayak
2013-07-30 11:25 ` [PATCH v2 4/8] ARM: DRA7: Reuse io tables and add a new .init_early Rajendra Nayak
2013-07-30 11:25   ` Rajendra Nayak
2013-07-30 11:25 ` [PATCH v2 5/8] ARM: DRA7: Resue the clocksource, clockevent support Rajendra Nayak
2013-07-30 11:25   ` Rajendra Nayak
2013-07-30 11:25 ` [PATCH v2 6/8] ARM: DRA7: board-generic: Add basic DT support Rajendra Nayak
2013-07-30 11:25   ` Rajendra Nayak
2013-07-30 11:25 ` [PATCH v2 7/8] ARM: DRA7: Kconfig: Make ARCH_NR_GPIO default to 512 Rajendra Nayak
2013-07-30 11:25   ` Rajendra Nayak
2013-07-30 11:25 ` [PATCH v2 8/8] ARM: DRA7: dts: Add the dts files for dra7 SoC and dra7-evm board Rajendra Nayak
2013-07-30 11:25   ` Rajendra Nayak
2013-07-30 12:30   ` Nishanth Menon
2013-07-30 12:30     ` Nishanth Menon
2013-07-30 12:41     ` Rajendra Nayak
2013-07-30 12:41       ` Rajendra Nayak
2013-07-30 12:46       ` Nishanth Menon
2013-07-30 12:46         ` Nishanth Menon
2013-07-30 12:56         ` Rajendra Nayak
2013-07-30 12:56           ` Rajendra Nayak
2013-07-30 12:59           ` Nishanth Menon
2013-07-30 12:59             ` Nishanth Menon
2013-07-30 13:01             ` Rajendra Nayak
2013-07-30 13:01               ` Rajendra Nayak
2013-08-12 13:46               ` Benoit Cousson
2013-08-12 13:46                 ` Benoit Cousson
2013-08-12 11:44   ` Mark Rutland
2013-08-12 11:44     ` Mark Rutland
2013-08-13  7:24     ` Rajendra Nayak
2013-08-13  7:24       ` Rajendra Nayak
2013-08-13  9:46       ` Mark Rutland
2013-08-13  9:46         ` Mark Rutland
2013-08-13 10:05         ` Marc Zyngier
2013-08-13 10:05           ` Marc Zyngier
2013-08-14  9:40           ` Rajendra Nayak
2013-08-14  9:40             ` Rajendra Nayak
2013-08-02 22:28 ` [PATCH v2 0/8] DRA7xx core support Santosh Shilimkar
2013-08-02 22:28   ` Santosh Shilimkar
2013-08-04 16:14   ` Rajendra Nayak
2013-08-04 16:14     ` Rajendra Nayak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130730135527.GM7656@atomide.com \
    --to=tony@atomide.com \
    --cc=ambresh@ti.com \
    --cc=balbi@ti.com \
    --cc=benoit.cousson@gmail.com \
    --cc=khilman@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=r.sricharan@ti.com \
    --cc=rnayak@ti.com \
    --cc=sourav.poddar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.