From: Felipe Balbi <balbi@ti.com>
To: Sourav Poddar <sourav.poddar@ti.com>
Cc: balbi@ti.com, broonie@kernel.org,
spi-devel-general@lists.sourceforge.net, grant.likely@linaro.org,
linux-omap@vger.kernel.org, rnayak@ti.com
Subject: Re: [PATCHv7 1/2] drivers: spi: Add qspi flash controller
Date: Wed, 31 Jul 2013 12:48:57 +0300 [thread overview]
Message-ID: <20130731094857.GA15583@radagast> (raw)
In-Reply-To: <51F8DB98.70709@ti.com>
[-- Attachment #1: Type: text/plain, Size: 449 bytes --]
Hi,
On Wed, Jul 31, 2013 at 03:10:40PM +0530, Sourav Poddar wrote:
> >>words can be of any length (1, 2 or 4) bytes. So, I think it should be
> >>decremented by 1 only.
> >this is wrong.
> >
> hmm..got the point.
> I will pass the count address also to ti_qspi_read_data/write_data and make
> use of the switch statement to decrement the count.
why don't you return the amount of bytes to decrement in case of
success ?
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@ti.com>
To: Sourav Poddar <sourav.poddar@ti.com>
Cc: <balbi@ti.com>, <broonie@kernel.org>,
<spi-devel-general@lists.sourceforge.net>,
<grant.likely@linaro.org>, <linux-omap@vger.kernel.org>,
<rnayak@ti.com>
Subject: Re: [PATCHv7 1/2] drivers: spi: Add qspi flash controller
Date: Wed, 31 Jul 2013 12:48:57 +0300 [thread overview]
Message-ID: <20130731094857.GA15583@radagast> (raw)
In-Reply-To: <51F8DB98.70709@ti.com>
[-- Attachment #1: Type: text/plain, Size: 449 bytes --]
Hi,
On Wed, Jul 31, 2013 at 03:10:40PM +0530, Sourav Poddar wrote:
> >>words can be of any length (1, 2 or 4) bytes. So, I think it should be
> >>decremented by 1 only.
> >this is wrong.
> >
> hmm..got the point.
> I will pass the count address also to ti_qspi_read_data/write_data and make
> use of the switch statement to decrement the count.
why don't you return the amount of bytes to decrement in case of
success ?
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-07-31 9:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 5:47 [PATCHv7 0/2] Add ti qspi controller Sourav Poddar
2013-07-31 5:47 ` Sourav Poddar
[not found] ` <1375249673-2585-1-git-send-email-sourav.poddar-l0cyMroinI0@public.gmane.org>
2013-07-31 5:47 ` [PATCHv7 1/2] drivers: spi: Add qspi flash controller Sourav Poddar
2013-07-31 5:47 ` Sourav Poddar
2013-07-31 7:49 ` Felipe Balbi
2013-07-31 7:49 ` Felipe Balbi
2013-07-31 9:10 ` Sourav Poddar
2013-07-31 9:10 ` Sourav Poddar
2013-07-31 9:20 ` Felipe Balbi
2013-07-31 9:20 ` Felipe Balbi
2013-07-31 9:40 ` Sourav Poddar
2013-07-31 9:40 ` Sourav Poddar
2013-07-31 9:48 ` Felipe Balbi [this message]
2013-07-31 9:48 ` Felipe Balbi
2013-07-31 9:53 ` Sourav Poddar
2013-07-31 9:53 ` Sourav Poddar
2013-07-31 18:39 ` Trent Piepho
[not found] ` <CA+7tXijn2V7LMCKuOKxcda6r6a=JFBeSFNqGqNtYZuTF=irF1g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-08-01 4:15 ` Sourav Poddar
2013-07-31 5:47 ` [RFC/PATCH 2/2] driver: spi: Add quad spi read support Sourav Poddar
2013-07-31 5:47 ` Sourav Poddar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130731094857.GA15583@radagast \
--to=balbi@ti.com \
--cc=broonie@kernel.org \
--cc=grant.likely@linaro.org \
--cc=linux-omap@vger.kernel.org \
--cc=rnayak@ti.com \
--cc=sourav.poddar@ti.com \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.