All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [RESEND PATCH v10 1/8] drivers: phy: add generic PHY framework
Date: Thu, 01 Aug 2013 01:40:24 +0000	[thread overview]
Message-ID: <20130801014024.GA6941@kroah.com> (raw)
In-Reply-To: <1374842963-13545-2-git-send-email-kishon@ti.com>

On Fri, Jul 26, 2013 at 06:19:16PM +0530, Kishon Vijay Abraham I wrote:
> +static int phy_get_id(void)
> +{
> +	int ret;
> +	int id;
> +
> +	ret = ida_pre_get(&phy_ida, GFP_KERNEL);
> +	if (!ret)
> +		return -ENOMEM;
> +
> +	ret = ida_get_new(&phy_ida, &id);
> +	if (ret < 0)
> +		return ret;
> +
> +	return id;
> +}

ida_simple_get() instead?  And if you do that, you can get rid of this
function entirely.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: kyungmin.park@samsung.com, balbi@ti.com, jg1.han@samsung.com,
	s.nawrocki@samsung.com, kgene.kim@samsung.com,
	stern@rowland.harvard.edu, broonie@kernel.org,
	tomasz.figa@gmail.com, arnd@arndb.de, grant.likely@linaro.org,
	tony@atomide.com, swarren@nvidia.com, devicetree@vger.kernel.org,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-usb@vger.kernel.org, linux-media@vger.kernel.org,
	linux-fbdev@vger.kernel.org, akpm@linux-foundation.org,
	balajitk@ti.com, george.cherian@ti.com, nsekhar@ti.com,
	linux@arm.linux.org.uk, Tomasz Figa <t.figa@samsung.com>
Subject: Re: [RESEND PATCH v10 1/8] drivers: phy: add generic PHY framework
Date: Wed, 31 Jul 2013 18:40:24 -0700	[thread overview]
Message-ID: <20130801014024.GA6941@kroah.com> (raw)
In-Reply-To: <1374842963-13545-2-git-send-email-kishon@ti.com>

On Fri, Jul 26, 2013 at 06:19:16PM +0530, Kishon Vijay Abraham I wrote:
> +static int phy_get_id(void)
> +{
> +	int ret;
> +	int id;
> +
> +	ret = ida_pre_get(&phy_ida, GFP_KERNEL);
> +	if (!ret)
> +		return -ENOMEM;
> +
> +	ret = ida_get_new(&phy_ida, &id);
> +	if (ret < 0)
> +		return ret;
> +
> +	return id;
> +}

ida_simple_get() instead?  And if you do that, you can get rid of this
function entirely.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: gregkh@linuxfoundation.org (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH v10 1/8] drivers: phy: add generic PHY framework
Date: Wed, 31 Jul 2013 18:40:24 -0700	[thread overview]
Message-ID: <20130801014024.GA6941@kroah.com> (raw)
In-Reply-To: <1374842963-13545-2-git-send-email-kishon@ti.com>

On Fri, Jul 26, 2013 at 06:19:16PM +0530, Kishon Vijay Abraham I wrote:
> +static int phy_get_id(void)
> +{
> +	int ret;
> +	int id;
> +
> +	ret = ida_pre_get(&phy_ida, GFP_KERNEL);
> +	if (!ret)
> +		return -ENOMEM;
> +
> +	ret = ida_get_new(&phy_ida, &id);
> +	if (ret < 0)
> +		return ret;
> +
> +	return id;
> +}

ida_simple_get() instead?  And if you do that, you can get rid of this
function entirely.

thanks,

greg k-h

  parent reply	other threads:[~2013-08-01  1:40 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-26 12:49 [RESEND PATCH v10 0/8] PHY framework Kishon Vijay Abraham I
2013-07-26 12:53 ` Kishon Vijay Abraham I
2013-07-26 12:49 ` Kishon Vijay Abraham I
2013-07-26 12:49 ` Kishon Vijay Abraham I
2013-07-26 12:49 ` [RESEND PATCH v10 1/8] drivers: phy: add generic " Kishon Vijay Abraham I
2013-07-26 12:53   ` Kishon Vijay Abraham I
2013-07-26 12:49   ` Kishon Vijay Abraham I
2013-07-26 12:49   ` Kishon Vijay Abraham I
2013-07-29 15:28   ` Kamil Debski
2013-07-29 15:28     ` Kamil Debski
2013-07-29 15:28     ` Kamil Debski
2013-07-29 15:30     ` Kishon Vijay Abraham I
2013-07-29 15:42       ` Kishon Vijay Abraham I
2013-07-29 15:30       ` Kishon Vijay Abraham I
2013-07-29 15:30       ` Kishon Vijay Abraham I
2013-07-29 15:51   ` Sylwester Nawrocki
2013-07-29 15:51     ` Sylwester Nawrocki
2013-07-29 15:51     ` Sylwester Nawrocki
2013-07-30  5:12     ` Kishon Vijay Abraham I
2013-07-30  5:24       ` Kishon Vijay Abraham I
2013-07-30  5:12       ` Kishon Vijay Abraham I
2013-07-30  5:12       ` Kishon Vijay Abraham I
2013-08-01  1:40   ` Greg KH [this message]
2013-08-01  1:40     ` Greg KH
2013-08-01  1:40     ` Greg KH
2013-07-26 12:49 ` [RESEND PATCH v10 2/8] usb: phy: omap-usb2: use the new " Kishon Vijay Abraham I
2013-07-26 12:53   ` Kishon Vijay Abraham I
2013-07-26 12:49   ` Kishon Vijay Abraham I
2013-07-26 12:49   ` Kishon Vijay Abraham I
2013-07-26 12:49 ` [RESEND PATCH v10 3/8] usb: phy: twl4030: " Kishon Vijay Abraham I
2013-07-26 12:53   ` Kishon Vijay Abraham I
2013-07-26 12:49   ` Kishon Vijay Abraham I
2013-07-26 12:49   ` Kishon Vijay Abraham I
2013-07-26 12:49 ` [RESEND PATCH v10 4/8] arm: omap3: twl: add phy consumer data in twl4030_usb_data Kishon Vijay Abraham I
2013-07-26 12:52   ` Kishon Vijay Abraham I
2013-07-26 12:49   ` Kishon Vijay Abraham I
2013-07-26 12:49   ` Kishon Vijay Abraham I
2013-07-26 12:49 ` [RESEND PATCH v10 5/8] ARM: dts: omap: update usb_otg_hs data Kishon Vijay Abraham I
2013-07-26 12:52   ` Kishon Vijay Abraham I
2013-07-26 12:49   ` Kishon Vijay Abraham I
2013-07-26 12:49   ` Kishon Vijay Abraham I
     [not found] ` <1374842963-13545-1-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2013-07-26 12:49   ` [RESEND PATCH v10 6/8] usb: musb: omap2430: use the new generic PHY framework Kishon Vijay Abraham I
2013-07-26 12:52     ` Kishon Vijay Abraham I
2013-07-26 12:49     ` Kishon Vijay Abraham I
2013-07-26 12:49     ` Kishon Vijay Abraham I
2013-07-26 12:49 ` [RESEND PATCH v10 7/8] usb: phy: omap-usb2: remove *set_suspend* callback from omap-usb2 Kishon Vijay Abraham I
2013-07-26 12:51   ` Kishon Vijay Abraham I
2013-07-26 12:49   ` Kishon Vijay Abraham I
2013-07-26 12:49   ` Kishon Vijay Abraham I
2013-07-26 12:49 ` [RESEND PATCH v10 8/8] usb: phy: twl4030-usb: remove *set_suspend* and *phy_init* ops Kishon Vijay Abraham I
2013-07-26 12:51   ` Kishon Vijay Abraham I
2013-07-26 12:49   ` Kishon Vijay Abraham I
2013-07-26 12:49   ` Kishon Vijay Abraham I

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130801014024.GA6941@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.