From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] USBIP:stub_dev.c fixing string splitted into multiple line issue
Date: Thu, 01 Aug 2013 07:17:05 +0000 [thread overview]
Message-ID: <20130801071705.GK5002@mwanda> (raw)
In-Reply-To: <1375292922-13724-1-git-send-email-kumargauravgupta3@gmail.com>
On Wed, Jul 31, 2013 at 10:26:15PM +0200, Julia Lawall wrote:
> On Wed, 31 Jul 2013, Kumar Gaurav wrote:
>
> > Fixed String splitted into multiple line issue using macro
>
> I'm not an expert on this kind of style issue, but I prefer strings that
> look like strings.
>
Yeah. This patch makes the code more abstract and harder to
understand.
regards,
dan carpenter
next prev parent reply other threads:[~2013-08-01 7:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 17:49 [PATCH] USBIP:stub_dev.c fixing string splitted into multiple line issue Kumar Gaurav
2013-07-31 20:26 ` Julia Lawall
2013-08-01 7:17 ` Dan Carpenter [this message]
2013-08-02 2:40 ` Kumar Gaurav
2013-08-02 5:57 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130801071705.GK5002@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.