From: Kumar Gaurav <kumargauravgupta3@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] USBIP:stub_dev.c fixing string splitted into multiple line issue
Date: Fri, 02 Aug 2013 02:40:35 +0000 [thread overview]
Message-ID: <51FB1953.5050401@gmail.com> (raw)
In-Reply-To: <1375292922-13724-1-git-send-email-kumargauravgupta3@gmail.com>
On Thursday 01 August 2013 10:27 AM, Jiany Wu wrote:
> I have the same idea with julia.
> It is more difficult to check the log if we use MACRO instead of the
> strings.
> If we search in the system log, according to the string, we will find
> out the macro first. later we also need to find out where the macro is
> using.
>
>
> 2013/8/1 Julia Lawall <julia.lawall@lip6.fr <mailto:julia.lawall@lip6.fr>>
>
> On Wed, 31 Jul 2013, Kumar Gaurav wrote:
>
> > Fixed String splitted into multiple line issue using macro
>
> I'm not an expert on this kind of style issue, but I prefer
> strings that
> look like strings.
>
> julia
>
> > Signed-off-by: Kumar Gaurav <kumargauravgupta3@gmail.com
> <mailto:kumargauravgupta3@gmail.com>>
> > ---
> > drivers/staging/usbip/stub_dev.c | 17 ++++++++++-------
> > 1 file changed, 10 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/staging/usbip/stub_dev.c
> b/drivers/staging/usbip/stub_dev.c
> > index 83d629a..3b881e1 100644
> > --- a/drivers/staging/usbip/stub_dev.c
> > +++ b/drivers/staging/usbip/stub_dev.c
> > @@ -30,6 +30,8 @@
> > * In most cases, wildcard matching will be okay because driver
> binding can be
> > * changed dynamically by a userland program.
> > */
> > +#define USBIP_REG_INTF "register new interface (bus %u dev %u
> ifn %u)\n"
> > +#define USBIP_REG_DEV "register new device (bus %u dev %u ifn
> %u)\n"
> > static struct usb_device_id stub_table[] = {
> > #if 0
> > /* just an example */
> > @@ -357,8 +359,9 @@ static int stub_probe(struct usb_interface
> *interface,
> > busid_priv = get_busid_priv(udev_busid);
> > if (!busid_priv || (busid_priv->status = STUB_BUSID_REMOV) ||
> > (busid_priv->status = STUB_BUSID_OTHER)) {
> > - dev_info(&interface->dev, "%s is not in
> match_busid table... "
> > - "skip!\n", udev_busid);
> > + dev_info(&interface->dev,
> > + "%s is not in match_busid table... skip!\n",
> > + udev_busid);
> >
> > /*
> > * Return value should be ENODEV or ENOXIO to
> continue trying
> > @@ -386,8 +389,7 @@ static int stub_probe(struct usb_interface
> *interface,
> > return -ENODEV;
> >
> > busid_priv->interf_count++;
> > - dev_info(&interface->dev, "usbip-host: register
> new interface "
> > - "(bus %u dev %u ifn %u)\n",
> > + dev_info(&interface->dev, USBIP_REG_INTF,
> > udev->bus->busnum, udev->devnum,
> > interface->cur_altsetting->desc.bInterfaceNumber);
> >
> > @@ -412,8 +414,8 @@ static int stub_probe(struct usb_interface
> *interface,
> > if (!sdev)
> > return -ENOMEM;
> >
> > - dev_info(&interface->dev, "usbip-host: register new device "
> > - "(bus %u dev %u ifn %u)\n", udev->bus->busnum,
> udev->devnum,
> > + dev_info(&interface->dev, USBIP_REG_DEV,
> > + udev->bus->busnum, udev->devnum,
> > interface->cur_altsetting->desc.bInterfaceNumber);
> >
> > busid_priv->interf_count = 0;
> > @@ -426,7 +428,8 @@ static int stub_probe(struct usb_interface
> *interface,
> >
> > err = stub_add_files(&interface->dev);
> > if (err) {
> > - dev_err(&interface->dev, "stub_add_files for
> %s\n", udev_busid);
> > + dev_err(&interface->dev, "stub_add_files for %s\n",
> > + udev_busid);
> > usb_set_intfdata(interface, NULL);
> > usb_put_intf(interface);
> > usb_put_dev(udev);
> > --
> > 1.7.9.5
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe
> kernel-janitors" in
> > the body of a message to majordomo@vger.kernel.org
> <mailto:majordomo@vger.kernel.org>
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
> --
> To unsubscribe from this list: send the line "unsubscribe
> kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> <mailto:majordomo@vger.kernel.org>
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
Thanks you all for suggestions. I'll try finding some other way.
Regargs
Kumar Gaurav
next prev parent reply other threads:[~2013-08-02 2:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 17:49 [PATCH] USBIP:stub_dev.c fixing string splitted into multiple line issue Kumar Gaurav
2013-07-31 20:26 ` Julia Lawall
2013-08-01 7:17 ` Dan Carpenter
2013-08-02 2:40 ` Kumar Gaurav [this message]
2013-08-02 5:57 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FB1953.5050401@gmail.com \
--to=kumargauravgupta3@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.