From: Johannes Weiner <hannes@cmpxchg.org>
To: Michal Hocko <mhocko@suse.cz>
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Joonsoo Kim <js1304@gmail.com>, Minchan Kim <minchan@kernel.org>,
Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>
Subject: Re: [PATCH 1/4] mm, page_alloc: add likely macro to help compiler optimization
Date: Fri, 2 Aug 2013 16:47:10 -0400 [thread overview]
Message-ID: <20130802204710.GX715@cmpxchg.org> (raw)
In-Reply-To: <20130802162722.GA29220@dhcp22.suse.cz>
On Fri, Aug 02, 2013 at 06:27:22PM +0200, Michal Hocko wrote:
> On Fri 02-08-13 11:07:56, Joonsoo Kim wrote:
> > We rarely allocate a page with ALLOC_NO_WATERMARKS and it is used
> > in slow path. For making fast path more faster, add likely macro to
> > help compiler optimization.
>
> The code is different in mmotm tree (see mm: page_alloc: rearrange
> watermark checking in get_page_from_freelist)
Yes, please rebase this on top.
> Besides that, make sure you provide numbers which prove your claims
> about performance optimizations.
Isn't that a bit overkill? We know it's a likely path (we would
deadlock constantly if a sizable portion of allocations were to ignore
the watermarks). Does he have to justify that likely in general makes
sense?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: Michal Hocko <mhocko@suse.cz>
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Joonsoo Kim <js1304@gmail.com>, Minchan Kim <minchan@kernel.org>,
Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>
Subject: Re: [PATCH 1/4] mm, page_alloc: add likely macro to help compiler optimization
Date: Fri, 2 Aug 2013 16:47:10 -0400 [thread overview]
Message-ID: <20130802204710.GX715@cmpxchg.org> (raw)
In-Reply-To: <20130802162722.GA29220@dhcp22.suse.cz>
On Fri, Aug 02, 2013 at 06:27:22PM +0200, Michal Hocko wrote:
> On Fri 02-08-13 11:07:56, Joonsoo Kim wrote:
> > We rarely allocate a page with ALLOC_NO_WATERMARKS and it is used
> > in slow path. For making fast path more faster, add likely macro to
> > help compiler optimization.
>
> The code is different in mmotm tree (see mm: page_alloc: rearrange
> watermark checking in get_page_from_freelist)
Yes, please rebase this on top.
> Besides that, make sure you provide numbers which prove your claims
> about performance optimizations.
Isn't that a bit overkill? We know it's a likely path (we would
deadlock constantly if a sizable portion of allocations were to ignore
the watermarks). Does he have to justify that likely in general makes
sense?
next prev parent reply other threads:[~2013-08-02 20:47 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-02 2:07 [PATCH 1/4] mm, page_alloc: add likely macro to help compiler optimization Joonsoo Kim
2013-08-02 2:07 ` Joonsoo Kim
2013-08-02 2:07 ` [PATCH 2/4] mm, migrate: allocation new page lazyily in unmap_and_move() Joonsoo Kim
2013-08-02 2:07 ` Joonsoo Kim
2013-08-02 19:41 ` Johannes Weiner
2013-08-02 19:41 ` Johannes Weiner
2013-08-05 7:41 ` Joonsoo Kim
2013-08-05 7:41 ` Joonsoo Kim
2013-08-02 2:07 ` [PATCH 3/4] mm: move pgtable related functions to right place Joonsoo Kim
2013-08-02 2:07 ` Joonsoo Kim
2013-08-02 2:07 ` [PATCH 4/4] swap: clean-up #ifdef in page_mapping() Joonsoo Kim
2013-08-02 2:07 ` Joonsoo Kim
2013-08-02 19:43 ` Johannes Weiner
2013-08-02 19:43 ` Johannes Weiner
2013-08-02 16:27 ` [PATCH 1/4] mm, page_alloc: add likely macro to help compiler optimization Michal Hocko
2013-08-02 16:27 ` Michal Hocko
2013-08-02 20:47 ` Johannes Weiner [this message]
2013-08-02 20:47 ` Johannes Weiner
2013-08-02 21:36 ` Michal Hocko
2013-08-02 21:36 ` Michal Hocko
2013-08-05 8:10 ` Joonsoo Kim
2013-08-05 8:10 ` Joonsoo Kim
2013-08-05 8:50 ` Joonsoo Kim
2013-08-05 8:50 ` Joonsoo Kim
2013-08-05 8:59 ` Michal Hocko
2013-08-05 8:59 ` Michal Hocko
2013-08-05 20:52 ` Johannes Weiner
2013-08-05 20:52 ` Johannes Weiner
2013-08-02 19:26 ` Johannes Weiner
2013-08-02 19:26 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130802204710.GX715@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=js1304@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=minchan@kernel.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.