From: Michael Ellerman <michael@ellerman.id.au>
To: Nathan Fontenot <nfont@linux.vnet.ibm.com>
Cc: linux-mm <linux-mm@kvack.org>,
isimatu.yasuaki@jp.fujitsu.com, linuxppc-dev@lists.ozlabs.org,
LKML <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 2/8] Mark powerpc memory resources as busy
Date: Mon, 5 Aug 2013 13:11:12 +1000 [thread overview]
Message-ID: <20130805031111.GA5347@concordia> (raw)
In-Reply-To: <51FC0315.1010601@linux.vnet.ibm.com>
On Fri, Aug 02, 2013 at 02:05:57PM -0500, Nathan Fontenot wrote:
> On 08/01/2013 09:28 PM, Michael Ellerman wrote:
> > On Wed, Jul 24, 2013 at 01:36:34PM -0500, Nathan Fontenot wrote:
> >> Memory I/O resources need to be marked as busy or else we cannot remove
> >> them when doing memory hot remove.
> >
> > I would have thought it was the opposite?
>
> Me too.
>
> As it turns out the code in kernel/resource.c checks to make sure the
> IORESOURCE_BUSY flag is set when trying to release a resource.
OK, I guess there's probably some sane reason, but it does seem
backward.
cheers
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <michael@ellerman.id.au>
To: Nathan Fontenot <nfont@linux.vnet.ibm.com>
Cc: linux-mm <linux-mm@kvack.org>,
isimatu.yasuaki@jp.fujitsu.com, linuxppc-dev@lists.ozlabs.org,
LKML <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 2/8] Mark powerpc memory resources as busy
Date: Mon, 5 Aug 2013 13:11:12 +1000 [thread overview]
Message-ID: <20130805031111.GA5347@concordia> (raw)
In-Reply-To: <51FC0315.1010601@linux.vnet.ibm.com>
On Fri, Aug 02, 2013 at 02:05:57PM -0500, Nathan Fontenot wrote:
> On 08/01/2013 09:28 PM, Michael Ellerman wrote:
> > On Wed, Jul 24, 2013 at 01:36:34PM -0500, Nathan Fontenot wrote:
> >> Memory I/O resources need to be marked as busy or else we cannot remove
> >> them when doing memory hot remove.
> >
> > I would have thought it was the opposite?
>
> Me too.
>
> As it turns out the code in kernel/resource.c checks to make sure the
> IORESOURCE_BUSY flag is set when trying to release a resource.
OK, I guess there's probably some sane reason, but it does seem
backward.
cheers
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-08-05 3:11 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-24 18:33 [PATCH 0/8] Correct memory hot add/remove for powerpc Nathan Fontenot
2013-07-24 18:33 ` Nathan Fontenot
2013-07-24 18:35 ` [PATCH 1/8] register bootmem pages for powerpc when sparse vmemmap is not defined Nathan Fontenot
2013-07-24 18:35 ` Nathan Fontenot
2013-08-02 2:27 ` Michael Ellerman
2013-08-02 2:27 ` Michael Ellerman
2013-08-02 2:27 ` Michael Ellerman
2013-08-02 19:04 ` Nathan Fontenot
2013-08-02 19:04 ` Nathan Fontenot
2013-07-24 18:36 ` [PATCH 2/8] Mark powerpc memory resources as busy Nathan Fontenot
2013-07-24 18:36 ` Nathan Fontenot
2013-08-02 2:28 ` Michael Ellerman
2013-08-02 2:28 ` Michael Ellerman
2013-08-02 2:28 ` Michael Ellerman
2013-08-02 19:05 ` Nathan Fontenot
2013-08-02 19:05 ` Nathan Fontenot
2013-08-05 3:11 ` Michael Ellerman [this message]
2013-08-05 3:11 ` Michael Ellerman
2013-07-24 18:37 ` [PATCH 3/8] Add all memory via sysfs probe interface at once Nathan Fontenot
2013-07-24 18:37 ` Nathan Fontenot
2013-08-02 2:32 ` Michael Ellerman
2013-08-02 2:32 ` Michael Ellerman
2013-08-02 2:32 ` Michael Ellerman
2013-08-02 19:13 ` Nathan Fontenot
2013-08-02 19:13 ` Nathan Fontenot
2013-08-05 3:13 ` Michael Ellerman
2013-08-05 3:13 ` Michael Ellerman
2013-08-06 20:44 ` Nathan Fontenot
2013-08-06 20:44 ` Nathan Fontenot
2013-08-09 7:16 ` Benjamin Herrenschmidt
2013-08-09 7:16 ` Benjamin Herrenschmidt
2013-08-09 7:16 ` Benjamin Herrenschmidt
2013-07-24 18:39 ` [PATCH 4/8] Create a sysfs release file for hot removing memory Nathan Fontenot
2013-07-24 18:39 ` Nathan Fontenot
2013-07-24 18:41 ` [PATCH 5/8] Add notifiers for memory hot add/remove Nathan Fontenot
2013-07-24 18:41 ` Nathan Fontenot
2013-07-24 18:44 ` [PATCH 6/8] Update the powerpc arch specific memory add/remove handlers Nathan Fontenot
2013-07-24 18:44 ` Nathan Fontenot
2013-07-24 18:45 ` [PATCH 7/8] Add memory hot add/remove notifier handlers for pwoerpc Nathan Fontenot
2013-07-24 18:45 ` Nathan Fontenot
2013-07-24 18:47 ` [PATCH 8/8] Remove no longer needed powerpc memory node update handler Nathan Fontenot
2013-07-24 18:47 ` Nathan Fontenot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130805031111.GA5347@concordia \
--to=michael@ellerman.id.au \
--cc=gregkh@linuxfoundation.org \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nfont@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.