From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Sebastian Hesselbarth
<sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] i2c: add sanity check to i2c_put_adapter
Date: Mon, 5 Aug 2013 12:47:07 +0200 [thread overview]
Message-ID: <20130805104706.GC9694@katana> (raw)
In-Reply-To: <51FF70FE.1090804-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 860 bytes --]
On Mon, Aug 05, 2013 at 11:31:42AM +0200, Sebastian Hesselbarth wrote:
> On 08/05/13 11:00, Wolfram Sang wrote:
> >On Thu, Aug 01, 2013 at 02:10:46PM +0200, Sebastian Hesselbarth wrote:
> >>i2c_put_adapter dereferences i2c_adapter pointer passed without check
> >>for NULL. This adds a check for non-NULL pointer to allow i2c_put_adapter
> >>called with NULL and behave the same way i2c_release_client does already.
> >
> >What about using WARN for the NULL case to point out the ref-counting
> >imbalance?
>
> Wolfram,
>
> I was just adding this to (a) make it consistent with i2c_release_client
> and (b) it allows to simplify drivers where you need to release the
> adapter during probe failures. But that patch is so small, feel free to
> squash in anything you like.
I am not forcing you to do this, I am calling for opinions here.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: add sanity check to i2c_put_adapter
Date: Mon, 5 Aug 2013 12:47:07 +0200 [thread overview]
Message-ID: <20130805104706.GC9694@katana> (raw)
In-Reply-To: <51FF70FE.1090804@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 860 bytes --]
On Mon, Aug 05, 2013 at 11:31:42AM +0200, Sebastian Hesselbarth wrote:
> On 08/05/13 11:00, Wolfram Sang wrote:
> >On Thu, Aug 01, 2013 at 02:10:46PM +0200, Sebastian Hesselbarth wrote:
> >>i2c_put_adapter dereferences i2c_adapter pointer passed without check
> >>for NULL. This adds a check for non-NULL pointer to allow i2c_put_adapter
> >>called with NULL and behave the same way i2c_release_client does already.
> >
> >What about using WARN for the NULL case to point out the ref-counting
> >imbalance?
>
> Wolfram,
>
> I was just adding this to (a) make it consistent with i2c_release_client
> and (b) it allows to simplify drivers where you need to release the
> adapter during probe failures. But that patch is so small, feel free to
> squash in anything you like.
I am not forcing you to do this, I am calling for opinions here.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-08-05 10:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 12:10 [PATCH] i2c: add sanity check to i2c_put_adapter Sebastian Hesselbarth
2013-08-01 12:10 ` Sebastian Hesselbarth
[not found] ` <1375359046-17472-1-git-send-email-sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-08-05 9:00 ` Wolfram Sang
2013-08-05 9:00 ` Wolfram Sang
2013-08-05 9:31 ` Sebastian Hesselbarth
2013-08-05 9:31 ` Sebastian Hesselbarth
[not found] ` <51FF70FE.1090804-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-08-05 10:47 ` Wolfram Sang [this message]
2013-08-05 10:47 ` Wolfram Sang
2013-08-07 15:05 ` Wolfram Sang
2013-08-07 15:05 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130805104706.GC9694@katana \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.