All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aristeu Rozanski <aris-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Jens Axboe <axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>,
	containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>,
	Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Vivek Goyal <vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 15/23] cgroup: make hierarchy iterators deal with cgroup_subsys_state instead of cgroup
Date: Mon, 5 Aug 2013 14:10:49 -0400	[thread overview]
Message-ID: <20130805181049.GC7878@redhat.com> (raw)
In-Reply-To: <1375393801-4817-16-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>

On Thu, Aug 01, 2013 at 05:49:53PM -0400, Tejun Heo wrote:
> cgroup is currently in the process of transitioning to using css
> (cgroup_subsys_state) as the primary handle instead of cgroup in
> subsystem API.  For hierarchy iterators, this is beneficial because
> 
> * In most cases, css is the only thing subsystems care about anyway.
> 
> * On the planned unified hierarchy, iterations for different
>   subsystems will need to skip over different subtrees of the
>   hierarchy depending on which subsystems are enabled on each cgroup.
>   Passing around css makes it unnecessary to explicitly specify the
>   subsystem in question as css is intersection between cgroup and
>   subsystem
> 
> * For the planned unified hierarchy, css's would need to be created
>   and destroyed dynamically independent from cgroup hierarchy.  Having
>   cgroup core manage css iteration makes enforcing deref rules a lot
>   easier.
> 
> Most subsystem conversions are straight-forward.  Noteworthy changes
> are
> 
> * blkio: cgroup_to_blkcg() is no longer used.  Removed.
> 
> * freezer: cgroup_freezer() is no longer used.  Removed.
> 
> * devices: cgroup_to_devcgroup() is no longer used.  Removed.

Acked-by: Aristeu Rozanski <aris-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

-- 
Aristeu

WARNING: multiple messages have this Message-ID (diff)
From: Aristeu Rozanski <aris@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: lizefan@huawei.com, containers@lists.linux-foundation.org,
	cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
	Johannes Weiner <hannes@cmpxchg.org>,
	Michal Hocko <mhocko@suse.cz>,
	Balbir Singh <bsingharora@gmail.com>,
	Matt Helsley <matthltc@us.ibm.com>,
	Vivek Goyal <vgoyal@redhat.com>, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH 15/23] cgroup: make hierarchy iterators deal with cgroup_subsys_state instead of cgroup
Date: Mon, 5 Aug 2013 14:10:49 -0400	[thread overview]
Message-ID: <20130805181049.GC7878@redhat.com> (raw)
In-Reply-To: <1375393801-4817-16-git-send-email-tj@kernel.org>

On Thu, Aug 01, 2013 at 05:49:53PM -0400, Tejun Heo wrote:
> cgroup is currently in the process of transitioning to using css
> (cgroup_subsys_state) as the primary handle instead of cgroup in
> subsystem API.  For hierarchy iterators, this is beneficial because
> 
> * In most cases, css is the only thing subsystems care about anyway.
> 
> * On the planned unified hierarchy, iterations for different
>   subsystems will need to skip over different subtrees of the
>   hierarchy depending on which subsystems are enabled on each cgroup.
>   Passing around css makes it unnecessary to explicitly specify the
>   subsystem in question as css is intersection between cgroup and
>   subsystem
> 
> * For the planned unified hierarchy, css's would need to be created
>   and destroyed dynamically independent from cgroup hierarchy.  Having
>   cgroup core manage css iteration makes enforcing deref rules a lot
>   easier.
> 
> Most subsystem conversions are straight-forward.  Noteworthy changes
> are
> 
> * blkio: cgroup_to_blkcg() is no longer used.  Removed.
> 
> * freezer: cgroup_freezer() is no longer used.  Removed.
> 
> * devices: cgroup_to_devcgroup() is no longer used.  Removed.

Acked-by: Aristeu Rozanski <aris@redhat.com>

-- 
Aristeu


  parent reply	other threads:[~2013-08-05 18:10 UTC|newest]

Thread overview: 136+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-01 21:49 [PATCHSET cgroup/for-3.12] cgroup: use cgroup_subsys_state as the primary subsystem interface handle Tejun Heo
2013-08-01 21:49 ` Tejun Heo
     [not found] ` <1375393801-4817-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-08-01 21:49   ` [PATCH 01/23] cgroup: s/cgroup_subsys_state/cgroup_css/ s/task_subsys_state/task_css/ Tejun Heo
2013-08-01 21:49     ` Tejun Heo
2013-08-01 21:49   ` [PATCH 02/23] cpuset: drop "const" qualifiers from struct cpuset instances Tejun Heo
2013-08-01 21:49     ` Tejun Heo
2013-08-01 21:49   ` [PATCH 03/23] netprio_cgroup: pass around @css instead of @cgroup and kill struct cgroup_netprio_state Tejun Heo
2013-08-01 21:49     ` Tejun Heo
     [not found]     ` <1375393801-4817-4-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-08-01 22:07       ` David Miller
2013-08-01 22:07         ` David Miller
2013-08-02 11:42       ` Neil Horman
2013-08-02 11:42         ` Neil Horman
2013-08-01 21:49   ` [PATCH 04/23] hugetlb_cgroup: pass around @hugetlb_cgroup instead of @cgroup Tejun Heo
2013-08-01 21:49     ` Tejun Heo
     [not found]     ` <1375393801-4817-5-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-08-02  4:35       ` Aneesh Kumar K.V
2013-08-02  4:35         ` Aneesh Kumar K.V
2013-08-02  4:35       ` Aneesh Kumar K.V
2013-08-02 13:10       ` Michal Hocko
2013-08-02 13:10         ` Michal Hocko
2013-08-01 21:49   ` [PATCH 05/23] cgroup: add subsystem pointer to cgroup_subsys_state Tejun Heo
2013-08-01 21:49     ` Tejun Heo
2013-08-01 21:49   ` [PATCH 06/23] cgroup: add/update accessors which obtain subsys specific data from css Tejun Heo
2013-08-01 21:49     ` Tejun Heo
2013-08-01 21:49   ` [PATCH 07/23] cgroup: add css_parent() Tejun Heo
2013-08-01 21:49     ` Tejun Heo
2013-08-01 21:49   ` [PATCH 08/23] cgroup: pass around cgroup_subsys_state instead of cgroup in subsystem methods Tejun Heo
2013-08-01 21:49   ` [PATCH 09/23] cgroup: add subsys backlink pointer to cftype Tejun Heo
2013-08-01 21:49   ` [PATCH 10/23] cgroup: pin cgroup_subsys_state when opening a cgroupfs file Tejun Heo
2013-08-01 21:49     ` Tejun Heo
2013-08-01 21:49   ` [PATCH 11/23] cgroup: add cgroup->dummy_css Tejun Heo
2013-08-01 21:49     ` Tejun Heo
2013-08-01 21:49   ` [PATCH 12/23] cgroup: pass around cgroup_subsys_state instead of cgroup in file methods Tejun Heo
2013-08-01 21:49     ` Tejun Heo
     [not found]     ` <1375393801-4817-13-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-08-02 13:27       ` Michal Hocko
2013-08-02 13:27         ` Michal Hocko
2013-08-05 14:19       ` Vivek Goyal
2013-08-05 14:19         ` Vivek Goyal
2013-08-05 18:04       ` Aristeu Rozanski
2013-08-05 18:04         ` Aristeu Rozanski
2013-08-06  6:48       ` Daniel Wagner
2013-08-06  6:48         ` Daniel Wagner
2013-08-01 21:49   ` [PATCH 13/23] cgroup: convert cgroup_next_sibling() to cgroup_next_child() Tejun Heo
2013-08-01 21:49     ` Tejun Heo
2013-08-01 21:49   ` [PATCH 14/23] cgroup: always use cgroup_next_child() to walk the children list Tejun Heo
2013-08-01 21:49     ` Tejun Heo
2013-08-01 21:49   ` [PATCH 15/23] cgroup: make hierarchy iterators deal with cgroup_subsys_state instead of cgroup Tejun Heo
2013-08-01 21:49     ` Tejun Heo
     [not found]     ` <1375393801-4817-16-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-08-02 13:32       ` Michal Hocko
2013-08-02 13:32         ` Michal Hocko
2013-08-02 13:32       ` Michal Hocko
2013-08-05 14:25       ` Vivek Goyal
2013-08-05 14:25         ` Vivek Goyal
2013-08-05 18:10       ` Aristeu Rozanski [this message]
2013-08-05 18:10         ` Aristeu Rozanski
2013-08-01 21:49   ` [PATCH 16/23] cgroup: relocate cgroup_advance_iter() Tejun Heo
2013-08-01 21:49     ` Tejun Heo
     [not found]     ` <1375393801-4817-17-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-08-02  3:25       ` Li Zefan
2013-08-02  3:25         ` Li Zefan
     [not found]         ` <51FB26C6.2020100-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-08-02 19:35           ` Tejun Heo
2013-08-02 19:35           ` Tejun Heo
2013-08-02 19:35             ` Tejun Heo
2013-08-01 21:49   ` [PATCH 17/23] cgroup: rename cgroup_iter to cgroup_task_iter Tejun Heo
2013-08-01 21:49     ` Tejun Heo
     [not found]     ` <1375393801-4817-18-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-08-02 13:35       ` Michal Hocko
2013-08-02 13:35         ` Michal Hocko
2013-08-02 13:35       ` Michal Hocko
2013-08-01 21:49   ` [PATCH 18/23] cgroup: make cgroup_task_iter remember the cgroup being iterated Tejun Heo
2013-08-01 21:49     ` Tejun Heo
     [not found]     ` <1375393801-4817-19-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-08-02 13:38       ` Michal Hocko
2013-08-02 13:38         ` Michal Hocko
2013-08-01 21:49   ` [PATCH 19/23] cgroup: remove struct cgroup_scanner Tejun Heo
2013-08-01 21:49   ` [PATCH 20/23] cgroup: make task iterators deal with cgroup_subsys_state instead of cgroup Tejun Heo
2013-08-01 21:49     ` Tejun Heo
     [not found]     ` <1375393801-4817-21-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-08-02 13:40       ` Michal Hocko
2013-08-02 13:40         ` Michal Hocko
2013-08-01 21:49   ` Tejun Heo
2013-08-01 21:49   ` [PATCH 21/23] cgroup: make cftype->[un]register_event() " Tejun Heo
2013-08-01 21:50   ` [PATCH 22/23] cgroup: make cgroup_taskset " Tejun Heo
2013-08-01 21:50   ` [PATCH 23/23] cgroup: unexport cgroup_css() Tejun Heo
2013-08-02  3:24   ` [PATCHSET cgroup/for-3.12] cgroup: use cgroup_subsys_state as the primary subsystem interface handle Li Zefan
2013-08-02  3:24     ` Li Zefan
2013-08-09  0:12   ` Tejun Heo
2013-08-09  0:12     ` Tejun Heo
2013-08-09  0:12   ` Tejun Heo
2013-08-01 21:49 ` [PATCH 08/23] cgroup: pass around cgroup_subsys_state instead of cgroup in subsystem methods Tejun Heo
     [not found]   ` <1375393801-4817-9-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-08-02  3:54     ` Li Zefan
2013-08-02  3:54       ` Li Zefan
     [not found]       ` <51FB2D70.3040208-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-08-02 19:36         ` Tejun Heo
2013-08-02 19:36         ` Tejun Heo
2013-08-02 19:36           ` Tejun Heo
2013-08-02  4:02     ` Li Zefan
2013-08-02  4:02       ` Li Zefan
     [not found]       ` <51FB2F3D.5050904-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-08-02 19:41         ` Tejun Heo
2013-08-02 19:41           ` Tejun Heo
2013-08-02 13:19     ` Michal Hocko
2013-08-02 13:19     ` Michal Hocko
2013-08-02 13:19       ` Michal Hocko
     [not found]       ` <20130802131901.GB25432-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2013-08-02 13:43         ` Michal Hocko
2013-08-02 13:43         ` Michal Hocko
2013-08-02 13:43           ` Michal Hocko
     [not found]           ` <20130802134305.GI25432-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2013-08-02 19:52             ` Tejun Heo
2013-08-02 19:52               ` Tejun Heo
2013-08-02 19:38         ` Tejun Heo
2013-08-02 19:38         ` Tejun Heo
2013-08-02 19:38           ` Tejun Heo
2013-08-02 20:24     ` [PATCH v2 " Tejun Heo
2013-08-02 20:24       ` Tejun Heo
     [not found]       ` <20130802202408.GH29736-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2013-08-06  7:19         ` Daniel Wagner
2013-08-06  7:19           ` Daniel Wagner
2013-08-06  7:19         ` Daniel Wagner
2013-08-02 20:24     ` Tejun Heo
2013-08-05 12:44     ` [PATCH " Vivek Goyal
2013-08-05 12:44       ` Vivek Goyal
2013-08-05 17:57     ` Aristeu Rozanski
2013-08-05 17:57       ` Aristeu Rozanski
2013-08-01 21:49 ` [PATCH 09/23] cgroup: add subsys backlink pointer to cftype Tejun Heo
2013-08-05 12:49   ` Vivek Goyal
     [not found]   ` <1375393801-4817-10-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-08-05 12:49     ` Vivek Goyal
2013-08-01 21:49 ` [PATCH 19/23] cgroup: remove struct cgroup_scanner Tejun Heo
2013-08-01 21:49 ` [PATCH 21/23] cgroup: make cftype->[un]register_event() deal with cgroup_subsys_state instead of cgroup Tejun Heo
     [not found]   ` <1375393801-4817-22-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-08-02  4:08     ` Li Zefan
2013-08-02  4:08       ` Li Zefan
     [not found]       ` <51FB30D3.9030900-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-08-02 19:44         ` Tejun Heo
2013-08-02 19:44           ` Tejun Heo
2013-08-02 19:44         ` Tejun Heo
2013-08-02  4:08     ` Li Zefan
2013-08-02 13:42     ` Michal Hocko
2013-08-02 13:42       ` Michal Hocko
2013-08-02 13:42     ` Michal Hocko
2013-08-02 20:24     ` [PATCH v2 " Tejun Heo
2013-08-02 20:24       ` Tejun Heo
2013-08-01 21:50 ` [PATCH 22/23] cgroup: make cgroup_taskset " Tejun Heo
     [not found]   ` <1375393801-4817-23-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-08-06  6:53     ` Daniel Wagner
2013-08-06  6:53     ` Daniel Wagner
2013-08-06  6:53       ` Daniel Wagner
2013-08-01 21:50 ` [PATCH 23/23] cgroup: unexport cgroup_css() Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130805181049.GC7878@redhat.com \
    --to=aris-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mhocko-AlSwsSmVLrQ@public.gmane.org \
    --cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.