Commit "ARM: Turn most board directories into regular build directories" break kwb images

From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: barebox@lists.infradead.org
Subject: Commit "ARM: Turn most board directories into regular build directories" break kwb images
Date: Tue, 6 Aug 2013 11:49:45 +0200	[thread overview]
Message-ID: <20130806114945.065bda07@skate> (raw)

Hello Sascha,

Your commit 6bbb24cf8d0b0a060c57d9c07610210cdf2dcc96 ('ARM: Turn most
board directories into regular build directories') apparently breaks
the build of kwbimage for Marvell EBU platforms.

The kwbimage is built as follows:

KWBIMAGE_OPTS = \
        -c -i $(srctree)/$(BOARD)/kwbimage.cfg -d $(TEXT_BASE) -e $(TEXT_BASE)

quiet_cmd_kwbimage = KWB     $@
      cmd_kwbimage = scripts/kwbimage -p $< $(KWBIMAGE_OPTS) -o $@ || \
        echo "WARNING: Couldn't create KWB image due to previous errors."

quiet_cmd_kwbimage_uart = KWBUART $@
      cmd_kwbimage_uart = scripts/kwbimage -m uart -p $< $(KWBIMAGE_OPTS) -o $@ || \
        echo "WARNING Couldn't create KWB image due to previous errors."

so we rely on the $(BOARD) variable to contain
arch/arm/boards/<theboard>/. Unfortunately, with your commit, this is
no longer the case.

Your commit made the assumption that only those boards that have a
config.h should stay in board-y, but the Marvell EBU boards should also
stay in board-y, or another solution needs to be found.

I've temporarily worked around the problem by re-adding:

+board-$(CONFIG_MACH_GLOBALSCALE_GURUPLUG)      += globalscale-guruplug

into arch/arm/Makefile.

Since I haven't yet grasped the entire philosophy of the Barebox build
system, I'm not sure what the correct fix is.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox