From: Sascha Hauer <s.hauer@pengutronix.de>
To: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: barebox@lists.infradead.org
Subject: Re: Commit "ARM: Turn most board directories into regular build directories" break kwb images
Date: Tue, 6 Aug 2013 13:50:40 +0200 [thread overview]
Message-ID: <20130806115040.GD26614@pengutronix.de> (raw)
In-Reply-To: <20130806114945.065bda07@skate>
Hi Thomas,
On Tue, Aug 06, 2013 at 11:49:45AM +0200, Thomas Petazzoni wrote:
> Hello Sascha,
>
> Your commit 6bbb24cf8d0b0a060c57d9c07610210cdf2dcc96 ('ARM: Turn most
> board directories into regular build directories') apparently breaks
> the build of kwbimage for Marvell EBU platforms.
>
> The kwbimage is built as follows:
>
> KWBIMAGE_OPTS = \
> -c -i $(srctree)/$(BOARD)/kwbimage.cfg -d $(TEXT_BASE) -e $(TEXT_BASE)
>
> quiet_cmd_kwbimage = KWB $@
> cmd_kwbimage = scripts/kwbimage -p $< $(KWBIMAGE_OPTS) -o $@ || \
> echo "WARNING: Couldn't create KWB image due to previous errors."
>
> quiet_cmd_kwbimage_uart = KWBUART $@
> cmd_kwbimage_uart = scripts/kwbimage -m uart -p $< $(KWBIMAGE_OPTS) -o $@ || \
> echo "WARNING Couldn't create KWB image due to previous errors."
>
> so we rely on the $(BOARD) variable to contain
> arch/arm/boards/<theboard>/. Unfortunately, with your commit, this is
> no longer the case.
>
> Your commit made the assumption that only those boards that have a
> config.h should stay in board-y, but the Marvell EBU boards should also
> stay in board-y, or another solution needs to be found.
>
> I've temporarily worked around the problem by re-adding:
>
> +board-$(CONFIG_MACH_GLOBALSCALE_GURUPLUG) += globalscale-guruplug
>
> into arch/arm/Makefile.
>
> Since I haven't yet grasped the entire philosophy of the Barebox build
> system, I'm not sure what the correct fix is.
The best fix for this would be to switch the mvebu boards over to
multiboard support. I already created an initial patch for the cubox,
but got distracted somewhere in between.
However, I think for now we should just partly revert 6bbb24cf8d0b0a06
for mvebu.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2013-08-06 11:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-06 9:49 Commit "ARM: Turn most board directories into regular build directories" break kwb images Thomas Petazzoni
2013-08-06 11:50 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130806115040.GD26614@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.