Re: [PATCH v2] drm: use ida to allocate connector ids

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Wed, Aug 07, 2013 at 04:28:35AM -0400, Ilia Mirkin wrote:
> On Wed, Aug 7, 2013 at 4:00 AM, Ville Syrjälä
> <ville.syrjala@linux.intel.com> wrote:
> > On Tue, Jul 30, 2013 at 03:51:49AM -0400, Ilia Mirkin wrote:
> >> @@ -722,8 +741,9 @@ int drm_connector_init(struct drm_device *dev,
> >>       connector->dev = dev;
> >>       connector->funcs = funcs;
> >>       connector->connector_type = connector_type;
> >> -     connector->connector_type_id =
> >> -             ++drm_connector_enum_list[connector_type].count; /* TODO */
> >> +     ret = ida_get_new_above(count, 1, &connector->connector_type_id);
> >> +     if (ret)
> >> +             goto out;
> >
> > Leak.
> 
> I assume this is in reference to the drm_mode_object_get above? I just
> noticed that... or was there something else too?

Just the obj id.

-- 
Ville Syrjälä
Intel OTC