Re: [Qemu-devel] [PATCH v2 for-1.6] mips: revert commit b332d24a8e1290954029814d09156b06ede358e2

[Aurelien Jarno <aurelien@aurel32.net>]

On Tue, Aug 06, 2013 at 01:35:12PM +0200, Andreas Färber wrote:
> Am 06.08.2013 13:08, schrieb Aurelien Jarno:
> > Now that this code path is not triggered anymore during the tests,
> > revert commit b332d24a8e1290954029814d09156b06ede358e2. Booting a MIPS
> > target without kernel nor bios doesn't really make sense. At the same
> > time replace fprintf(stderr, ...) by error_report().
> > 
> > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> > ---
> >  hw/mips/mips_fulong2e.c |    4 +++-
> >  hw/mips/mips_jazz.c     |    5 +++--
> >  hw/mips/mips_malta.c    |    7 ++++---
> >  hw/mips/mips_mipssim.c  |    7 ++++---
> >  4 files changed, 14 insertions(+), 9 deletions(-)
> > 
> > v1 -> v2: replace fprintf(stderr, ...) by error_report()
> 
> If you drop the two remaining \n then feel free to commit with my
> Reviewed-by.
> 

Thanks for the review, I have just applied it with the mentioned
changes.


-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net