From: Dan Carpenter <dan.carpenter@oracle.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
Chris Wilson <chris@chris-wilson.co.uk>
Cc: David Airlie <airlied@linux.ie>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
kernel-janitors@vger.kernel.org
Subject: [patch v2] drm/i915: fix a limit check in hsw_compute_wm_results()
Date: Fri, 09 Aug 2013 10:07:31 +0000 [thread overview]
Message-ID: <20130809100731.GA31727@elgon.mountain> (raw)
In-Reply-To: <20130809095826.GA4313@cantiga.alporthouse.com>
The '!' here was not intended. Since '!' has higher precedence than
compare, it means the check is never true.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
v2: My first patch was wrong.
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 96234c6..0f5eb21 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -2685,7 +2685,7 @@ static void hsw_compute_wm_results(struct drm_device *dev,
* a WM level. */
results->enable_fbc_wm = true;
for (level = 1; level <= max_level; level++) {
- if (!lp_results[level - 1].fbc_val > lp_maximums->fbc) {
+ if (lp_results[level - 1].fbc_val > lp_maximums->fbc) {
results->enable_fbc_wm = false;
lp_results[level - 1].fbc_val = 0;
}
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
Chris Wilson <chris@chris-wilson.co.uk>
Cc: David Airlie <airlied@linux.ie>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
kernel-janitors@vger.kernel.org
Subject: [patch v2] drm/i915: fix a limit check in hsw_compute_wm_results()
Date: Fri, 9 Aug 2013 13:07:31 +0300 [thread overview]
Message-ID: <20130809100731.GA31727@elgon.mountain> (raw)
In-Reply-To: <20130809095826.GA4313@cantiga.alporthouse.com>
The '!' here was not intended. Since '!' has higher precedence than
compare, it means the check is never true.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
v2: My first patch was wrong.
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 96234c6..0f5eb21 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -2685,7 +2685,7 @@ static void hsw_compute_wm_results(struct drm_device *dev,
* a WM level. */
results->enable_fbc_wm = true;
for (level = 1; level <= max_level; level++) {
- if (!lp_results[level - 1].fbc_val > lp_maximums->fbc) {
+ if (lp_results[level - 1].fbc_val > lp_maximums->fbc) {
results->enable_fbc_wm = false;
lp_results[level - 1].fbc_val = 0;
}
next prev parent reply other threads:[~2013-08-09 10:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-09 9:43 [patch] drm/i915: precedence bug in hsw_compute_wm_results() Dan Carpenter
2013-08-09 9:43 ` Dan Carpenter
2013-08-09 9:58 ` Chris Wilson
2013-08-09 9:58 ` Chris Wilson
2013-08-09 10:07 ` Dan Carpenter [this message]
2013-08-09 10:07 ` [patch v2] drm/i915: fix a limit check " Dan Carpenter
2013-08-09 10:29 ` [Intel-gfx] " Ville Syrjälä
2013-08-09 10:29 ` Ville Syrjälä
2013-08-09 16:27 ` Daniel Vetter
2013-08-09 16:27 ` Daniel Vetter
2013-08-09 10:04 ` [patch] drm/i915: precedence bug " Ville Syrjälä
2013-08-09 10:04 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130809100731.GA31727@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=airlied@linux.ie \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.