From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/3] ltrace: Fix "strndup not declared" build failure on powerpc/uclibc
Date: Fri, 9 Aug 2013 12:29:06 +0200 [thread overview]
Message-ID: <20130809122906.052d226a@skate> (raw)
In-Reply-To: <1376041019-26688-4-git-send-email-jezz@sysmic.org>
Dear J?r?me Pouiller,
On Fri, 9 Aug 2013 11:36:59 +0200, J?r?me Pouiller wrote:
> On some systems, strndup is declared only if _GNU_SOURCE is defined
>
> Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
Shouldn't this be globally defined by adding a -D_GNU_SOURCE to the
CFLAGS at the package level?
If not, then anyway your patch needs a Signed-off-by line, and should
be submitted upstream.
Thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-08-09 10:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-09 9:36 [Buildroot] [PATCH 0/3] Fix ltrace autobuilder failures Jérôme Pouiller
2013-08-09 9:36 ` [Buildroot] [PATCH 1/3] ltrace: Explicit enable/disable of libunwind Jérôme Pouiller
2013-08-09 10:23 ` Baruch Siach
2013-08-09 10:24 ` Thomas Petazzoni
2013-08-09 9:36 ` [Buildroot] [PATCH 2/3] ltrace: Fix a May be unitialized variable Jérôme Pouiller
2013-08-09 10:20 ` Baruch Siach
2013-08-09 10:28 ` Thomas Petazzoni
2013-08-09 9:36 ` [Buildroot] [PATCH 3/3] ltrace: Fix "strndup not declared" build failure on powerpc/uclibc Jérôme Pouiller
2013-08-09 10:24 ` Baruch Siach
2013-08-09 10:29 ` Thomas Petazzoni [this message]
2013-08-09 11:05 ` Thomas De Schampheleire
2013-08-09 20:30 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130809122906.052d226a@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.