From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/3] ltrace: Fix "strndup not declared" build failure on powerpc/uclibc
Date: Fri, 9 Aug 2013 22:30:33 +0200 [thread overview]
Message-ID: <20130809223033.55b19b09@skate> (raw)
In-Reply-To: <CAAXf6LVxFHWaLChhMAROEhBzNpcy1rg0N882CADwwW3oMHe5mQ@mail.gmail.com>
Dear Thomas De Schampheleire,
On Fri, 9 Aug 2013 13:05:53 +0200, Thomas De Schampheleire wrote:
> > Shouldn't this be globally defined by adding a -D_GNU_SOURCE to the
> > CFLAGS at the package level?
>
> When you say 'package level' you mean in ltrace.mk in buildroot?
Yes, that's what I meant, but I agree that I might have been wrong.
> In this case I don't think it's correct: ltrace itself is responsible
> for including the right header files, and setting the right macros, so
> that any used interface is available. Hence, I consider it a patch to
> ltrace (that should be upstreamed), not something we should fix in
> buildroot itself.
Hum, yes, you're right.
J?r?me, sorry then, your original patch was OK. Just add your
Signed-off-by on it.
Can you resend your small patch series with the various minor comments
addressed?
Thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
prev parent reply other threads:[~2013-08-09 20:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-09 9:36 [Buildroot] [PATCH 0/3] Fix ltrace autobuilder failures Jérôme Pouiller
2013-08-09 9:36 ` [Buildroot] [PATCH 1/3] ltrace: Explicit enable/disable of libunwind Jérôme Pouiller
2013-08-09 10:23 ` Baruch Siach
2013-08-09 10:24 ` Thomas Petazzoni
2013-08-09 9:36 ` [Buildroot] [PATCH 2/3] ltrace: Fix a May be unitialized variable Jérôme Pouiller
2013-08-09 10:20 ` Baruch Siach
2013-08-09 10:28 ` Thomas Petazzoni
2013-08-09 9:36 ` [Buildroot] [PATCH 3/3] ltrace: Fix "strndup not declared" build failure on powerpc/uclibc Jérôme Pouiller
2013-08-09 10:24 ` Baruch Siach
2013-08-09 10:29 ` Thomas Petazzoni
2013-08-09 11:05 ` Thomas De Schampheleire
2013-08-09 20:30 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130809223033.55b19b09@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.