All of lore.kernel.org
 help / color / mirror / Atom feed
From: konrad.wilk@oracle.com (Konrad Rzeszutek Wilk)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 03/10] arm: make SWIOTLB available
Date: Fri, 9 Aug 2013 11:29:56 -0400	[thread overview]
Message-ID: <20130809152956.GC5637@phenom.dumpdata.com> (raw)
In-Reply-To: <1375720256-8014-3-git-send-email-stefano.stabellini@eu.citrix.com>

On Mon, Aug 05, 2013 at 05:30:49PM +0100, Stefano Stabellini wrote:
> IOMMU_HELPER is needed because SWIOTLB calls iommu_is_span_boundary,
> provided by lib/iommu_helper.c.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>

And Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

Thanks.
> CC: will.deacon at arm.com
> CC: linux at arm.linux.org.uk
> 
> 
> Changes in v3:
> - dma_capable: do not treat dma_mask as a limit;
> - remove SWIOTLB dependency on NEED_SG_DMA_LENGTH.
> ---
>  arch/arm/Kconfig                   |    6 ++++++
>  arch/arm/include/asm/dma-mapping.h |   30 ++++++++++++++++++++++++++++++
>  2 files changed, 36 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index ba412e0..c0bfb33 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1832,6 +1832,12 @@ config CC_STACKPROTECTOR
>  	  neutralized via a kernel panic.
>  	  This feature requires gcc version 4.2 or above.
>  
> +config SWIOTLB
> +	def_bool y
> +
> +config IOMMU_HELPER
> +	def_bool SWIOTLB
> +
>  config XEN_DOM0
>  	def_bool y
>  	depends on XEN
> diff --git a/arch/arm/include/asm/dma-mapping.h b/arch/arm/include/asm/dma-mapping.h
> index 5b579b9..5b8eef9 100644
> --- a/arch/arm/include/asm/dma-mapping.h
> +++ b/arch/arm/include/asm/dma-mapping.h
> @@ -86,6 +86,36 @@ static inline dma_addr_t virt_to_dma(struct device *dev, void *addr)
>  }
>  #endif
>  
> +static inline dma_addr_t phys_to_dma(struct device *dev, phys_addr_t paddr)
> +{
> +	unsigned int offset = paddr & ~PAGE_MASK;
> +	return pfn_to_dma(dev, paddr >> PAGE_SHIFT) + offset;
> +}
> +
> +static inline phys_addr_t dma_to_phys(struct device *dev, dma_addr_t dev_addr)
> +{
> +	unsigned int offset = dev_addr & ~PAGE_MASK;
> +	return (dma_to_pfn(dev, dev_addr) << PAGE_SHIFT) + offset;
> +}
> +
> +static inline bool dma_capable(struct device *dev, dma_addr_t addr, size_t size)
> +{
> +	u64 limit, mask = *dev->dma_mask;
> +
> +	limit = (mask + 1) & ~mask;
> +	if (limit && size > limit)
> +		return 0;
> +
> +	if ((addr | (addr + size - 1)) & ~mask)
> +		return 0;
> +
> +	return 1;
> +}
> +
> +static inline void dma_mark_clean(void *addr, size_t size)
> +{
> +}
> +
>  /*
>   * DMA errors are defined by all-bits-set in the DMA address.
>   */
> -- 
> 1.7.2.5
> 

WARNING: multiple messages have this Message-ID (diff)
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, Ian.Campbell@citrix.com,
	will.deacon@arm.com, linux@arm.linux.org.uk
Subject: Re: [PATCH v3 03/10] arm: make SWIOTLB available
Date: Fri, 9 Aug 2013 11:29:56 -0400	[thread overview]
Message-ID: <20130809152956.GC5637@phenom.dumpdata.com> (raw)
In-Reply-To: <1375720256-8014-3-git-send-email-stefano.stabellini@eu.citrix.com>

On Mon, Aug 05, 2013 at 05:30:49PM +0100, Stefano Stabellini wrote:
> IOMMU_HELPER is needed because SWIOTLB calls iommu_is_span_boundary,
> provided by lib/iommu_helper.c.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>

And Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

Thanks.
> CC: will.deacon@arm.com
> CC: linux@arm.linux.org.uk
> 
> 
> Changes in v3:
> - dma_capable: do not treat dma_mask as a limit;
> - remove SWIOTLB dependency on NEED_SG_DMA_LENGTH.
> ---
>  arch/arm/Kconfig                   |    6 ++++++
>  arch/arm/include/asm/dma-mapping.h |   30 ++++++++++++++++++++++++++++++
>  2 files changed, 36 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index ba412e0..c0bfb33 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1832,6 +1832,12 @@ config CC_STACKPROTECTOR
>  	  neutralized via a kernel panic.
>  	  This feature requires gcc version 4.2 or above.
>  
> +config SWIOTLB
> +	def_bool y
> +
> +config IOMMU_HELPER
> +	def_bool SWIOTLB
> +
>  config XEN_DOM0
>  	def_bool y
>  	depends on XEN
> diff --git a/arch/arm/include/asm/dma-mapping.h b/arch/arm/include/asm/dma-mapping.h
> index 5b579b9..5b8eef9 100644
> --- a/arch/arm/include/asm/dma-mapping.h
> +++ b/arch/arm/include/asm/dma-mapping.h
> @@ -86,6 +86,36 @@ static inline dma_addr_t virt_to_dma(struct device *dev, void *addr)
>  }
>  #endif
>  
> +static inline dma_addr_t phys_to_dma(struct device *dev, phys_addr_t paddr)
> +{
> +	unsigned int offset = paddr & ~PAGE_MASK;
> +	return pfn_to_dma(dev, paddr >> PAGE_SHIFT) + offset;
> +}
> +
> +static inline phys_addr_t dma_to_phys(struct device *dev, dma_addr_t dev_addr)
> +{
> +	unsigned int offset = dev_addr & ~PAGE_MASK;
> +	return (dma_to_pfn(dev, dev_addr) << PAGE_SHIFT) + offset;
> +}
> +
> +static inline bool dma_capable(struct device *dev, dma_addr_t addr, size_t size)
> +{
> +	u64 limit, mask = *dev->dma_mask;
> +
> +	limit = (mask + 1) & ~mask;
> +	if (limit && size > limit)
> +		return 0;
> +
> +	if ((addr | (addr + size - 1)) & ~mask)
> +		return 0;
> +
> +	return 1;
> +}
> +
> +static inline void dma_mark_clean(void *addr, size_t size)
> +{
> +}
> +
>  /*
>   * DMA errors are defined by all-bits-set in the DMA address.
>   */
> -- 
> 1.7.2.5
> 

WARNING: multiple messages have this Message-ID (diff)
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: xen-devel@lists.xensource.com, linux@arm.linux.org.uk,
	Ian.Campbell@citrix.com, will.deacon@arm.com,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 03/10] arm: make SWIOTLB available
Date: Fri, 9 Aug 2013 11:29:56 -0400	[thread overview]
Message-ID: <20130809152956.GC5637@phenom.dumpdata.com> (raw)
In-Reply-To: <1375720256-8014-3-git-send-email-stefano.stabellini@eu.citrix.com>

On Mon, Aug 05, 2013 at 05:30:49PM +0100, Stefano Stabellini wrote:
> IOMMU_HELPER is needed because SWIOTLB calls iommu_is_span_boundary,
> provided by lib/iommu_helper.c.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>

And Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

Thanks.
> CC: will.deacon@arm.com
> CC: linux@arm.linux.org.uk
> 
> 
> Changes in v3:
> - dma_capable: do not treat dma_mask as a limit;
> - remove SWIOTLB dependency on NEED_SG_DMA_LENGTH.
> ---
>  arch/arm/Kconfig                   |    6 ++++++
>  arch/arm/include/asm/dma-mapping.h |   30 ++++++++++++++++++++++++++++++
>  2 files changed, 36 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index ba412e0..c0bfb33 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1832,6 +1832,12 @@ config CC_STACKPROTECTOR
>  	  neutralized via a kernel panic.
>  	  This feature requires gcc version 4.2 or above.
>  
> +config SWIOTLB
> +	def_bool y
> +
> +config IOMMU_HELPER
> +	def_bool SWIOTLB
> +
>  config XEN_DOM0
>  	def_bool y
>  	depends on XEN
> diff --git a/arch/arm/include/asm/dma-mapping.h b/arch/arm/include/asm/dma-mapping.h
> index 5b579b9..5b8eef9 100644
> --- a/arch/arm/include/asm/dma-mapping.h
> +++ b/arch/arm/include/asm/dma-mapping.h
> @@ -86,6 +86,36 @@ static inline dma_addr_t virt_to_dma(struct device *dev, void *addr)
>  }
>  #endif
>  
> +static inline dma_addr_t phys_to_dma(struct device *dev, phys_addr_t paddr)
> +{
> +	unsigned int offset = paddr & ~PAGE_MASK;
> +	return pfn_to_dma(dev, paddr >> PAGE_SHIFT) + offset;
> +}
> +
> +static inline phys_addr_t dma_to_phys(struct device *dev, dma_addr_t dev_addr)
> +{
> +	unsigned int offset = dev_addr & ~PAGE_MASK;
> +	return (dma_to_pfn(dev, dev_addr) << PAGE_SHIFT) + offset;
> +}
> +
> +static inline bool dma_capable(struct device *dev, dma_addr_t addr, size_t size)
> +{
> +	u64 limit, mask = *dev->dma_mask;
> +
> +	limit = (mask + 1) & ~mask;
> +	if (limit && size > limit)
> +		return 0;
> +
> +	if ((addr | (addr + size - 1)) & ~mask)
> +		return 0;
> +
> +	return 1;
> +}
> +
> +static inline void dma_mark_clean(void *addr, size_t size)
> +{
> +}
> +
>  /*
>   * DMA errors are defined by all-bits-set in the DMA address.
>   */
> -- 
> 1.7.2.5
> 

  reply	other threads:[~2013-08-09 15:29 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-05 16:29 [PATCH v3 0/10] enable swiotlb-xen on arm and arm64 Stefano Stabellini
2013-08-05 16:29 ` Stefano Stabellini
2013-08-05 16:29 ` Stefano Stabellini
2013-08-05 16:30 ` [PATCH v3 01/10] swiotlb: replace dma_length with sg_dma_len() macro Stefano Stabellini
2013-08-05 16:30   ` Stefano Stabellini
2013-08-05 16:30   ` Stefano Stabellini
2013-08-05 16:30 ` [PATCH v3 02/10] swiotlb-xen: " Stefano Stabellini
2013-08-05 16:30   ` Stefano Stabellini
2013-08-05 16:30   ` Stefano Stabellini
2013-08-05 16:30 ` [PATCH v3 03/10] arm: make SWIOTLB available Stefano Stabellini
2013-08-05 16:30   ` Stefano Stabellini
2013-08-05 16:30   ` Stefano Stabellini
2013-08-09 15:29   ` Konrad Rzeszutek Wilk [this message]
2013-08-09 15:29     ` Konrad Rzeszutek Wilk
2013-08-09 15:29     ` Konrad Rzeszutek Wilk
2013-08-05 16:30 ` [PATCH v3 04/10] arm: introduce a global dma_ops pointer Stefano Stabellini
2013-08-05 16:30   ` Stefano Stabellini
2013-08-05 16:30   ` Stefano Stabellini
2013-08-09 15:36   ` Konrad Rzeszutek Wilk
2013-08-09 15:36     ` Konrad Rzeszutek Wilk
2013-08-09 15:36     ` Konrad Rzeszutek Wilk
2013-08-05 16:30 ` [PATCH v3 05/10] arm64: do not initialize arm64_swiotlb if dma_ops is already set Stefano Stabellini
2013-08-05 16:30   ` Stefano Stabellini
2013-08-05 16:30   ` Stefano Stabellini
2013-08-05 16:30 ` [PATCH v3 06/10] xen/arm,arm64: move Xen initialization earlier Stefano Stabellini
2013-08-05 16:30   ` Stefano Stabellini
2013-08-05 16:30   ` Stefano Stabellini
2013-08-05 16:30 ` [PATCH v3 07/10] xen: introduce XENMEM_get_dma_buf and xen_put_dma_buf Stefano Stabellini
2013-08-05 16:30   ` Stefano Stabellini
2013-08-05 16:30   ` Stefano Stabellini
2013-08-09 15:36   ` Konrad Rzeszutek Wilk
2013-08-09 15:36     ` Konrad Rzeszutek Wilk
2013-08-09 15:50     ` Konrad Rzeszutek Wilk
2013-08-09 15:50       ` Konrad Rzeszutek Wilk
2013-08-14 16:41       ` Stefano Stabellini
2013-08-14 16:41         ` Stefano Stabellini
2013-08-14 16:41         ` Stefano Stabellini
2013-08-14 16:43     ` Stefano Stabellini
2013-08-14 16:43       ` Stefano Stabellini
2013-08-14 16:43       ` Stefano Stabellini
2013-08-05 16:30 ` [PATCH v3 08/10] xen: make xen_create_contiguous_region return the dma address Stefano Stabellini
2013-08-05 16:30   ` Stefano Stabellini
2013-08-05 16:30   ` Stefano Stabellini
2013-08-05 16:30 ` [PATCH v3 09/10] swiotlb-xen: support autotranslate guests Stefano Stabellini
2013-08-05 16:30   ` Stefano Stabellini
2013-08-05 16:30   ` Stefano Stabellini
2013-08-09 15:45   ` Konrad Rzeszutek Wilk
2013-08-09 15:45     ` Konrad Rzeszutek Wilk
2013-08-14 13:01     ` Stefano Stabellini
2013-08-14 13:01       ` Stefano Stabellini
2013-08-14 13:01       ` Stefano Stabellini
2013-08-05 16:30 ` [PATCH v3 10/10] xen/arm,arm64: enable SWIOTLB_XEN Stefano Stabellini
2013-08-05 16:30   ` Stefano Stabellini
2013-08-05 16:30   ` Stefano Stabellini
2013-08-09 15:38   ` Konrad Rzeszutek Wilk
2013-08-09 15:38     ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130809152956.GC5637@phenom.dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.